Skip to content

feat(auth): reCAPTCHA Public preview #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 12, 2023
Merged

feat(auth): reCAPTCHA Public preview #2129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b10d9d6
Defined reCAPTCHA config. (#1574)
Xiaoshouzi-gh Feb 14, 2022
ad904c4
Create/Update tenant with ReCAPTCHA Config (#1586)
Xiaoshouzi-gh Mar 7, 2022
21c7deb
Project config - Recaptcha config (#1595)
Xiaoshouzi-gh Mar 8, 2022
73bfb6b
Recapcha integ test (#1599)
Xiaoshouzi-gh Mar 9, 2022
fbc18f7
Account defender support for reCAPTCHA (#1616)
Xiaoshouzi-gh May 3, 2022
1a0458d
address tech review feedback (#1685)
Xiaoshouzi-gh May 4, 2022
5c1d5c0
Update integration test for recapcha account defender
Xiaoshouzi-gh Mar 2, 2023
6868fd2
fix rebasing caused tests failure
Xiaoshouzi-gh Mar 30, 2023
199c56b
Apply suggestions from code review
Xiaoshouzi-gh Mar 31, 2023
ca3c818
update recaptcha key type
Xiaoshouzi-gh Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: pragatimodi <[email protected]>
  • Loading branch information
@Xiaoshouzi-gh @pragatimodi
Xiaoshouzi-gh and pragatimodi committed Apr 12, 2023
commit 199c56be7b6fd8deb6e9cbfc6306c7a87441853c
4 changes: 1 addition & 3 deletions src/auth/project-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export interface UpdateProjectConfigRequest {

/**
* Response received when getting or updating the project config.
* Currently only includes the reCAPTCHA and SMS Region config.
*/
export interface ProjectConfigServerResponse {
smsRegionConfig?: SmsRegionConfig;
Expand All @@ -60,7 +59,6 @@ export interface ProjectConfigServerResponse {

/**
* Request to update the project config.
* Currently only includes the reCAPTCHA and SMS Region config.
*/
export interface ProjectConfigClientRequest {
smsRegionConfig?: SmsRegionConfig;
Expand Down Expand Up @@ -145,7 +143,7 @@ export class ProjectConfig {
* Build the corresponding server request for a UpdateProjectConfigRequest object.
* @param configOptions - The properties to convert to a server request.
* @returns The equivalent server request.
*
*
* @internal
*/
public static buildServerRequest(configOptions: UpdateProjectConfigRequest): ProjectConfigClientRequest {
Expand Down
28 changes: 24 additions & 4 deletions test/integration/auth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,12 @@ describe('admin.auth', () => {
multiFactorConfig: mfaConfig,
recaptchaConfig: {
emailPasswordEnforcementState: 'AUDIT',
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
managedRules: [
{
endScore: 0.1,
action: 'BLOCK',
},
],
useAccountDefender: true,
},
};
Expand Down Expand Up @@ -1263,7 +1268,12 @@ describe('admin.auth', () => {
multiFactorConfig: mfaConfig,
recaptchaConfig: {
emailPasswordEnforcementState: 'AUDIT',
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
managedRules: [
{
endScore: 0.1,
action: 'BLOCK',
},
],
useAccountDefender: true,
},
};
Expand All @@ -1276,7 +1286,12 @@ describe('admin.auth', () => {
multiFactorConfig: mfaConfig,
recaptchaConfig: {
emailPasswordEnforcementState: 'OFF',
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
managedRules: [
{
endScore: 0.1,
action: 'BLOCK',
},
],
},
};
const expectedProjectConfigSmsEnabledTotpDisabled: any = {
Expand All @@ -1293,7 +1308,12 @@ describe('admin.auth', () => {
},
recaptchaConfig: {
emailPasswordEnforcementState: 'OFF',
managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
managedRules: [
{
endScore: 0.1,
action: 'BLOCK',
},
],
},
};

Expand Down