Skip to content

Adding the engines config to package.json #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2018
Merged

Adding the engines config to package.json #329

merged 1 commit into from
Aug 6, 2018

Conversation

@hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Aug 3, 2018 •
edited
Loading

A wise man told me we should add the engines attribute to our package.json (#328). He's usually right :)

schmidt-sebastian
schmidt-sebastian approved these changes Aug 4, 2018
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@hiranya911 hiranya911 merged commit 8fe2428 into master Aug 6, 2018
@hiranya911 hiranya911 deleted the hkj-node-engines branch August 6, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiranya911 @schmidt-sebastian