Add clarifying javadoc to FirebaseCrashlytics#setCrashlyticsCollectionEnabled #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage ReportAffected SDKsNo changes between base commit (0c89bff) and head commit (1409294). Test Logs
NotesHTML coverage reports can be produced locally with |
Contributor
Binary Size ReportAffected SDKs
Test Logs |
Contributor
|
@mrichards: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cbonnie
reviewed
Apr 23, 2020
| * sending them to Crashlytics. | ||
| * | ||
| * @param enabled whether to enable automatic data collection. | ||
| * @param enabled whether to enable automatic data collection. When set to `false`, the new value |
There was a problem hiding this comment.
Suggest:
* @param specifies whether to enable automatic data collection...
cbonnie
approved these changes
Apr 23, 2020
mrwillis21
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a behavior change; it just clarifies the existing behavior in the javadoc.