fix(test_lab): client info details can be undefined (fixes #64) (#80)

Salakar · web-flow · commit 2be43afc7158 · 2023-05-03T14:07:36.000-07:00
diff --git a/src/firebase_functions/test_lab_fn.py b/src/firebase_functions/test_lab_fn.py
@@ -222,7 +222,7 @@ def _event_handler(func: _C1, raw: _ce.CloudEvent) -> None:
         ),
         client_info=ClientInfo(
             client=event_data["clientInfo"]["client"],
-            details=event_data["clientInfo"]["details"],
+            details=event_data["clientInfo"].get("details", {}),
         ),
         test_matrix_id=event_data["testMatrixId"],
     )
diff --git a/tests/test_test_lab_fn.py b/tests/test_test_lab_fn.py
@@ -78,9 +78,6 @@ def test_event_handler(self):
                 },
                 "clientInfo": {
                     "client": "gcloud",
-                    "details": {
-                        "someKey": "someValue",
-                    },
                 },
                 "testMatrixId": "testmatrix-123",
             })

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ def _event_handler(func: _C1, raw: _ce.CloudEvent) -> None:`
`222`	`222`	`),`
`223`	`223`	`client_info=ClientInfo(`
`224`	`224`	`client=event_data["clientInfo"]["client"],`
`225`		`- details=event_data["clientInfo"]["details"],`
	`225`	`+ details=event_data["clientInfo"].get("details", {}),`
`226`	`226`	`),`
`227`	`227`	`test_matrix_id=event_data["testMatrixId"],`
`228`	`228`	`)`