Address review comments

Author: Athira M

common/api-review/remote-config.api.md

@@ -41,6 +41,7 @@ export function fetchConfig(remoteConfig: RemoteConfig): Promise<void>;
 export interface FetchResponse {
     config?: FirebaseRemoteConfigObject;
     eTag?: string;
+    // Warning: (ae-forgotten-export) The symbol "FirebaseExperimentDescription" needs to be exported by the entry point index.d.ts
     experiments?: FirebaseExperimentDescription[];
     status: number;
     templateVersion?: number;
@@ -52,22 +53,6 @@ export type FetchStatus = 'no-fetch-yet' | 'success' | 'failure' | 'throttle';
 // @public
 export type FetchType = 'BASE' | 'REALTIME';
 
-// @public
-export interface FirebaseExperimentDescription {
-    // (undocumented)
-    affectedParameterKeys?: string[];
-    // (undocumented)
-    experimentId: string;
-    // (undocumented)
-    experimentStartTime: string;
-    // (undocumented)
-    timeToLiveMillis: string;
-    // (undocumented)
-    triggerTimeoutMillis: string;
-    // (undocumented)
-    variantId: string;
-}
-
 // @public
 export interface FirebaseRemoteConfigObject {
     // (undocumented)

docs-devsite/_toc.yaml

@@ -649,8 +649,6 @@ toc:
     path: /docs/reference/js/remote-config.customsignals.md
   - title: FetchResponse
     path: /docs/reference/js/remote-config.fetchresponse.md
-  - title: FirebaseExperimentDescription
-    path: /docs/reference/js/remote-config.firebaseexperimentdescription.md
   - title: FirebaseRemoteConfigObject
     path: /docs/reference/js/remote-config.firebaseremoteconfigobject.md
   - title: RemoteConfig

docs-devsite/remote-config.fetchresponse.md

@@ -26,7 +26,7 @@ export interface FetchResponse
 |  --- | --- | --- |
 |  [config](./remote-config.fetchresponse.md#fetchresponseconfig) | [FirebaseRemoteConfigObject](./remote-config.firebaseremoteconfigobject.md#firebaseremoteconfigobject_interface) | Defines the map of parameters returned as "entries" in the fetch response body.<p>Only defined for 200 responses. |
 |  [eTag](./remote-config.fetchresponse.md#fetchresponseetag) | string | Defines the ETag response header value.<p>Only defined for 200 and 304 responses. |
-|  [experiments](./remote-config.fetchresponse.md#fetchresponseexperiments) | [FirebaseExperimentDescription](./remote-config.firebaseexperimentdescription.md#firebaseexperimentdescription_interface)<!-- -->\[\] | A/B Test and Rollout experiment metadata.<p>Only defined for 200 responses. |
+|  [experiments](./remote-config.fetchresponse.md#fetchresponseexperiments) | FirebaseExperimentDescription\[\] | A/B Test and Rollout experiment metadata. |
 |  [status](./remote-config.fetchresponse.md#fetchresponsestatus) | number | The HTTP status, which is useful for differentiating success responses with data from those without.<p>The Remote Config client is modeled after the native <code>Fetch</code> interface, so HTTP status is first-class.<p>Disambiguation: the fetch response returns a legacy "state" value that is redundant with the HTTP status code. The former is normalized into the latter. |
 |  [templateVersion](./remote-config.fetchresponse.md#fetchresponsetemplateversion) | number | The version number of the config template fetched from the server. |
 
@@ -58,7 +58,7 @@ eTag?: string;
 
 A/B Test and Rollout experiment metadata.
 
-<p>Only defined for 200 responses.
+Only defined for 200 responses.
 
 <b>Signature:</b>
 

docs-devsite/remote-config.firebaseexperimentdescription.md

@@ -42,9 +42,8 @@ The Firebase Remote Config Web SDK. This SDK does not work in a Node.js environm
 |  [ConfigUpdateObserver](./remote-config.configupdateobserver.md#configupdateobserver_interface) | Observer interface for receiving real-time Remote Config update notifications.<!-- -->NOTE: Although an <code>complete</code> callback can be provided, it will never be called because the ConfigUpdate stream is never-ending. |
 |  [CustomSignals](./remote-config.customsignals.md#customsignals_interface) | Defines the type for representing custom signals and their values.<p>The values in CustomSignals must be one of the following types:<ul> <li><code>string</code> <li><code>number</code> <li><code>null</code> </ul> |
 |  [FetchResponse](./remote-config.fetchresponse.md#fetchresponse_interface) | Defines a successful response (200 or 304).<p>Modeled after the native <code>Response</code> interface, but simplified for Remote Config's use case. |
-|  [FirebaseExperimentDescription](./remote-config.firebaseexperimentdescription.md#firebaseexperimentdescription_interface) | Defines experiment and variant attached to a config parameter. |
 |  [FirebaseRemoteConfigObject](./remote-config.firebaseremoteconfigobject.md#firebaseremoteconfigobject_interface) | Defines a self-descriptive reference for config key-value pairs. |
-|  [RemoteConfig](./remote-config.remoteconfig.md#remoteconfig_interface) | The Firebase Remote Config service interface. |
+|  [RemoteConfig](./remote-config.remoteconfig.md#remoteconfig_interface) | /\*\* The Firebase Remote Config service interface. |
 |  [RemoteConfigOptions](./remote-config.remoteconfigoptions.md#remoteconfigoptions_interface) | Options for Remote Config initialization. |
 |  [RemoteConfigSettings](./remote-config.remoteconfigsettings.md#remoteconfigsettings_interface) | Defines configuration options for the Remote Config SDK. |
 |  [Value](./remote-config.value.md#value_interface) | Wraps a value with metadata and type-safe getters. |

docs-devsite/remote-config.md

@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
 {% endcomment %}
 
 # RemoteConfig interface
-The Firebase Remote Config service interface.
+/\*\* The Firebase Remote Config service interface.
 
 <b>Signature:</b>
 

docs-devsite/remote-config.remoteconfig.md

@@ -19,7 +19,6 @@ import {
   CustomSignals,
   FetchResponse,
   FirebaseRemoteConfigObject,
-  FirebaseExperimentDescription
 } from '../public_types';
 import {
   RemoteConfigFetchClient,
@@ -49,6 +48,32 @@ interface FetchRequestBody {
   /* eslint-enable camelcase */
 }
 
+/**
+ * Defines experiment and variant attached to a config parameter.
+ */
+export interface FirebaseExperimentDescription {
+  // A string of max length 22 characters and of format: _exp_<experiment_id>
+  experimentId: string;
+
+  // The variant of the experiment assigned to the app instance.
+  variantId: string;
+
+  // When the experiment was started.
+  experimentStartTime: string;
+
+  // How long the experiment can remain in STANDBY state. Valid range from 1 ms
+  // to 6 months.
+  triggerTimeoutMillis: string;
+
+  // How long the experiment can remain in ON state. Valid range from 1 ms to 6
+  // months.
+  timeToLiveMillis: string;
+
+  // A repeated of Remote Config parameter keys that this experiment is
+  // affecting the value of.
+  affectedParameterKeys?: string[];
+}
+
 /**
  * Implements the Client abstraction for the Remote Config REST API.
  */

packages/remote-config/src/client/rest_client.ts

@@ -16,6 +16,9 @@
  */
 
 import { FirebaseApp, FirebaseError } from '@firebase/app';
+import { FirebaseExperimentDescription } from './client/rest_client';
+
+/**
 
 /**
  * The Firebase Remote Config service interface.
@@ -59,32 +62,6 @@ export interface FirebaseRemoteConfigObject {
   [key: string]: string;
 }
 
-/**
- * Defines experiment and variant attached to a config parameter.
- */
-export interface FirebaseExperimentDescription {
-  // A string of max length 22 characters and of format: _exp_<experiment_id>
-  experimentId: string;
-
-  // The variant of the experiment assigned to the app instance.
-  variantId: string;
-
-  // When the experiment was started.
-  experimentStartTime: string;
-
-  // How long the experiment can remain in STANDBY state. Valid range from 1 ms
-  // to 6 months.
-  triggerTimeoutMillis: string;
-
-  // How long the experiment can remain in ON state. Valid range from 1 ms to 6
-  // months.
-  timeToLiveMillis: string;
-
-  // A repeated of Remote Config parameter keys that this experiment is
-  // affecting the value of.
-  affectedParameterKeys?: string[];
-}
-
 /**
  * Defines a successful response (200 or 304).
  *
@@ -128,7 +105,7 @@ export interface FetchResponse {
   /**
    * A/B Test and Rollout experiment metadata.
    *
-   * <p>Only defined for 200 responses.
+   * @remarks Only defined for 200 responses.
    */
   experiments?: FirebaseExperimentDescription[];
 }