Skip to content

Fixed issue where multiple calls to connectDataConnectEmulator causes an exception #8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maneesht merged 11 commits into from
Dec 4, 2024
Merged

Fixed issue where multiple calls to connectDataConnectEmulator causes an exception #8664

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a2c6bea
Fixed issue where multiple calls to connectDataConnectEmulator throws…
maneesht Dec 3, 2024
a51822f
Undid auth changes
maneesht Dec 3, 2024
1932400
Fixed linting
maneesht Dec 3, 2024
0253a6d
Create funny-weeks-attack.md
maneesht Dec 3, 2024
2e41831
Update API reports
maneesht Dec 3, 2024
b0800ef
Removed only's and updated equality check
maneesht Dec 4, 2024
cdae5c6
Merge branch 'mtewani/fix-non-idempotent-emulator-fdc' of https://git…
maneesht Dec 4, 2024
d210372
Added return type
maneesht Dec 4, 2024
22c8fa2
Removed unnecessary changes
maneesht Dec 4, 2024
2356080
Removed query test from previous change
maneesht Dec 4, 2024
e7a7c2a
Fixed formatting
maneesht Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed query test from previous change
  • Loading branch information
@maneesht
maneesht committed Dec 4, 2024
commit 2356080882985c58cdc29666859a557cbea4436b
13 changes: 1 addition & 12 deletions packages/data-connect/test/queries.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,11 @@ import {
subscribe,
terminate,
SOURCE_CACHE,
SOURCE_SERVER,
toQueryRef
SOURCE_SERVER
} from '../src';

import { setupQueries } from './emulatorSeeder';
import { getConnectionConfig, initDatabase, PROJECT_ID } from './util';
import { serialize } from 'v8';

use(chaiAsPromised);

Expand Down Expand Up @@ -138,15 +136,6 @@ describe('DataConnect Tests', async () => {
expect(result.data).to.eq(queryResult.data);
expect(result.source).to.eq(SOURCE_CACHE);
});

it(`returns the result source as cache when data already exists`, async () => {
const taskListQuery = queryRef<TaskListResponse>(dc, 'listPosts');
const queryResult = await executeQuery(taskListQuery);
const serializedRef = queryResult.toJSON();
const newRef = queryRef(dc, serializedRef);
expect(newRef.name).to.eq(serializedRef.refInfo.name);
expect(newRef.variables).to.eq(serializedRef.refInfo.variables);
});
it(`returns the proper JSON when calling .toJSON()`, async () => {
const taskListQuery = queryRef<TaskListResponse>(dc, 'listPosts');
await executeQuery(taskListQuery);
Expand Down
Loading