Fixed operation not supported error for password only apps in a Cordova environment. (#113)

As only password providers are supported, the operation not supported error should not be shown
when getRedirectResult is called.

Author: bojeil-google

javascript/widgets/handler/callback.js

@@ -92,6 +92,19 @@ firebaseui.auth.widget.handler.handleCallback =
         firebaseui.auth.widget.handler.handleCallbackFailure_(
             app, component, /** @type {!Error} */ (error));
       }
+    } else if (error &&
+        error['code'] == 'auth/operation-not-supported-in-this-environment' &&
+        firebaseui.auth.widget.handler.common.isPasswordProviderOnly(app)) {
+      // Operation is not supported in this environment but only password
+      // provider is enabled. So allow this to proceed as a no redirect result.
+      // This will allow developers using password sign-in in Cordova to use
+      // FirebaseUI.
+      firebaseui.auth.widget.handler.handleCallbackResult_(
+          app,
+          component,
+          {
+            'user': null
+          });
     } else {
       // Go to the sign-in page with info bar error.
       firebaseui.auth.widget.handler.handleCallbackFailure_(

javascript/widgets/handler/callback_test.js

@@ -1799,3 +1799,97 @@ function testHandleCallback_nullUser_emailAuthOnly_acUnavailable() {
   });
 }
 
+
+function testHandleCallback_operationNotSupported_multiProviders() {
+  // Test when callback handler is triggered with multiple providers and
+  // the operation is not supported in this environment.
+  asyncTestCase.waitForSignals(1);
+  // Set mutliple providers.
+  app.setConfig({
+    'signInOptions': [
+      firebase.auth.EmailAuthProvider.PROVIDER_ID,
+      firebase.auth.GoogleAuthProvider.PROVIDER_ID
+    ]
+  });
+  // Callback rendered.
+  firebaseui.auth.widget.handler.handleCallback(app, container);
+  assertCallbackPage();
+  // Attempting to get redirect result. Reject with an operation not supported
+  // error.
+  testAuth.assertGetRedirectResult([], null, operationNotSupportedError);
+  testAuth.process().then(function() {
+    // Any pending credential should be cleared from storage.
+    assertFalse(firebaseui.auth.storage.hasPendingEmailCredential(
+        app.getAppId()));
+    // Redirect to the provider's sign-in page.
+    assertProviderSignInPage();
+    // Show error in info bar.
+    assertInfoBarMessage(
+        firebaseui.auth.widget.handler.common.getErrorMessage(
+            operationNotSupportedError));
+    asyncTestCase.signal();
+  });
+}
+
+
+function testHandleCallback_operationNotSupported_passwordOnly_acDisabled() {
+  // Test when callback handler is triggered with only a password provider and
+  // the operation is not supported in this environment.
+  asyncTestCase.waitForSignals(1);
+  // Set password only provider.
+  // Test with accountchooser.com disabled.
+  app.setConfig({
+    'credentialHelper': firebaseui.auth.CredentialHelper.NONE,
+    'signInOptions': [firebase.auth.EmailAuthProvider.PROVIDER_ID]
+  });
+  // Callback rendered.
+  firebaseui.auth.widget.handler.handleCallback(app, container);
+  assertCallbackPage();
+  // Attempting to get redirect result. Reject with an operation not supported
+  // error.
+  testAuth.assertGetRedirectResult([], null, operationNotSupportedError);
+  testAuth.process().then(function() {
+    // No message should be displayed.
+    assertNoInfoBarMessage();
+    // Redirect to the sign-in page with no error message.
+    assertSignInPage();
+    assertFalse(firebaseui.auth.storage.hasPendingEmailCredential(
+        app.getAppId()));
+    asyncTestCase.signal();
+  });
+}
+
+
+function testHandleCallback_operationNotSupported_passwordOnly_acEnabled() {
+  // Test when callback handler is triggered with only a password provider and
+  // the operation is not supported in this environment.
+  asyncTestCase.waitForSignals(1);
+  // Set password only provider.
+  // Test with accountchooser.com enabled.
+  app.setConfig({
+    'credentialHelper': firebaseui.auth.CredentialHelper.ACCOUNT_CHOOSER_COM,
+    'signInOptions': [firebase.auth.EmailAuthProvider.PROVIDER_ID]
+  });
+  // Simulate empty response from accountchooser.com click.
+  testAc.setSkipSelect(true);
+  // Callback rendered.
+  firebaseui.auth.widget.handler.handleCallback(app, container);
+  assertCallbackPage();
+  // Attempting to get redirect result. Reject with an operation not supported
+  // error.
+  testAuth.assertGetRedirectResult([], null, operationNotSupportedError);
+  testAuth.process().then(function() {
+    // Try select should be called.
+    testAc.assertTrySelectAccount(
+        firebaseui.auth.storage.getRememberedAccounts(app.getAppId()),
+        'http://localhost/firebaseui-widget?mode=select');
+    // Redirect to the sign-in page with no error message.
+    assertSignInPage();
+    assertFalse(firebaseui.auth.storage.hasPendingEmailCredential(
+        app.getAppId()));
+    // No message should be displayed.
+    assertNoInfoBarMessage();
+    asyncTestCase.signal();
+  });
+}
+

javascript/widgets/handler/common.js

@@ -803,6 +803,21 @@ firebaseui.auth.widget.handler.common.handleUnrecoverableError = function(
 };
 
 
+/**
+ * Helper function to check if a FirebaseUI instance only supports password
+ * providers.
+ * @param {firebaseui.auth.AuthUI} app The current FirebaseUI instance whose
+ *     configuration is used.
+ * @return {boolean} Whether only password providers are supported by the app's
+ *     current configuration.
+ */
+firebaseui.auth.widget.handler.common.isPasswordProviderOnly = function(app) {
+  var providers = app.getConfig().getProviders();
+  return providers.length == 1 &&
+      providers[0] == firebase.auth.EmailAuthProvider.PROVIDER_ID;
+};
+
+
 /**
  * Calls the appropriate sign-in start handler depending on display mode.
  *
@@ -814,9 +829,7 @@ firebaseui.auth.widget.handler.common.handleUnrecoverableError = function(
  */
 firebaseui.auth.widget.handler.common.handleSignInStart = function(
     app, container, opt_email, opt_infoBarMessage) {
-  var providers = app.getConfig().getProviders();
-  if (providers.length == 1 &&
-      providers[0] == firebase.auth.EmailAuthProvider.PROVIDER_ID) {
+  if (firebaseui.auth.widget.handler.common.isPasswordProviderOnly(app)) {
     // If info bar message is available, do not go to accountchooser.com since
     // this is a result of some error in the flow and the error message must be
     // displayed.

javascript/widgets/handler/common_test.js

@@ -1604,3 +1604,37 @@ function testGetErrorMessage_unknownError_jsonMessage() {
       firebaseui.auth.log.error.getLastCall().getArgument(0));
   assertEquals('An internal error has occurred.', message);
 }
+
+
+function testIsPasswordProviderOnly_multipleMixedProviders() {
+  // Set a password and federated providers in the FirebaseUI instance
+  // configuration.
+  app.updateConfig(
+      'signInOptions',
+      [
+        firebase.auth.GoogleAuthProvider.PROVIDER_ID,
+        firebase.auth.EmailAuthProvider.PROVIDER_ID
+      ]);
+  assertFalse(
+      firebaseui.auth.widget.handler.common.isPasswordProviderOnly(app));
+}
+
+
+function testIsPasswordProviderOnly_singlePasswordProvider() {
+  // Set a password only provider in the FirebaseUI instance configuration.
+  app.updateConfig(
+      'signInOptions',
+      [firebase.auth.EmailAuthProvider.PROVIDER_ID]);
+  assertTrue(
+      firebaseui.auth.widget.handler.common.isPasswordProviderOnly(app));
+}
+
+
+function testIsPasswordProviderOnly_singleFederatedProvider() {
+  // Set a federated only provider in the FirebaseUI instance configuration.
+  app.updateConfig(
+      'signInOptions',
+      [firebase.auth.GoogleAuthProvider.PROVIDER_ID]);
+  assertFalse(
+      firebaseui.auth.widget.handler.common.isPasswordProviderOnly(app));
+}

javascript/widgets/handler/testhelper.js

@@ -81,6 +81,12 @@ var internalError = {
   'code': 'auth/internal-error',
   'message': 'An internal error occurred.'
 };
+var operationNotSupportedError = {
+  'code': 'auth/operation-not-supported-in-this-environment',
+  'message':  'This operation is not supported in the environment this ' +
+  'application is running on. "location.protocol" must be http, https ' +
+  'or chrome-extension and web storage must be enabled.'
+};
 
 var container;
 var container2;