Skip to content

Commit ef9cf9e

Browse files
author
Andy Wermke
committed
Now using the facades for testing instead of App::make().
1 parent aa93269 commit ef9cf9e

File tree

2 files changed

+28
-37
lines changed

2 files changed

+28
-37
lines changed

tests/JsLocalization/CachingServiceTest.php

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22

33
use Mockery as m;
4-
use JsLocalization\CachingService;
4+
use JsLocalization\Facades\CachingService;
55

66
class CachingServiceTest extends TestCase
77
{
@@ -12,10 +12,8 @@ public function setUp ()
1212
{
1313
parent::setUp();
1414

15-
$this->cachingService = new CachingService;
16-
17-
Cache::forget(CachingService::CACHE_KEY);
18-
Cache::forget(CachingService::CACHE_TIMESTAMP_KEY);
15+
Cache::forget(JsLocalization\CachingService::CACHE_KEY);
16+
Cache::forget(JsLocalization\CachingService::CACHE_TIMESTAMP_KEY);
1917
}
2018

2119
public function tearDown ()
@@ -39,33 +37,33 @@ public function testGetMessagesJson ()
3937

4038
// Now refresh the cache:
4139

42-
$this->cachingService->refreshMessageCache();
40+
CachingService::refreshMessageCache();
4341

4442
$this->assertMessagesJsonEquals($this->testMessages);
4543
}
4644

4745
public function testGetLastRefreshTimestamp ()
4846
{
49-
$timestamp = $this->cachingService->getLastRefreshTimestamp();
47+
$timestamp = CachingService::getLastRefreshTimestamp();
5048
$this->assertEquals(0, $timestamp);
5149

52-
$this->cachingService->refreshMessageCache();
50+
CachingService::refreshMessageCache();
5351
$refreshTime = time();
5452

55-
$timestamp = $this->cachingService->getLastRefreshTimestamp();
53+
$timestamp = CachingService::getLastRefreshTimestamp();
5654
$this->assertEquals($refreshTime, $timestamp);
5755
}
5856

5957
public function testRefreshMessageCacheEvent ()
6058
{
6159
Event::shouldReceive('fire')->once()->with('JsLocalization.registerMessages');
6260

63-
$this->cachingService->refreshMessageCache();
61+
CachingService::refreshMessageCache();
6462
}
6563

6664
private function assertMessagesJsonEquals (array $expectedMessages)
6765
{
68-
$messagesJson = $this->cachingService->getMessagesJson();
66+
$messagesJson = CachingService::getMessagesJson();
6967
$this->assertJson($messagesJson);
7068

7169
$messages = json_decode($messagesJson, true);

tests/JsLocalization/JsLocalizationHelperTest.php

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
use JsLocalization\Facades\JsLocalizationHelper;
4+
35
class JsLocalizationHelperTest extends TestCase
46
{
57

@@ -65,95 +67,86 @@ public function tearDown ()
6567

6668
public function testResolveMessageKeyArray ()
6769
{
68-
$helper = App::make('JsLocalizationHelper');
69-
70-
$this->assertEquals($this->testKeysFlat, $helper->resolveMessageKeyArray($this->testKeys));
70+
$this->assertEquals($this->testKeysFlat, JsLocalizationHelper::resolveMessageKeyArray($this->testKeys));
7171
}
7272

7373
public function testResolveMessageArrayToMessageKeys ()
7474
{
75-
$helper = App::make('JsLocalizationHelper');
76-
77-
$this->assertEquals($this->testKeysFlat, $helper->resolveMessageArrayToMessageKeys($this->testMessages));
75+
$this->assertEquals($this->testKeysFlat, JsLocalizationHelper::resolveMessageArrayToMessageKeys($this->testMessages));
7876
}
7977

8078
public function testAddingRetrieving ()
8179
{
82-
$helper = App::make('JsLocalizationHelper');
83-
84-
$helper->addMessagesToExport($this->additionalMessageKeys);
80+
JsLocalizationHelper::addMessagesToExport($this->additionalMessageKeys);
8581

8682
$this->assertEquals(
8783
$this->additionalMessageKeysFlat,
88-
$helper->getAdditionalMessages()
84+
JsLocalizationHelper::getAdditionalMessages()
8985
);
9086

9187

9288
$this->addTestMessage('another', 'Another test text.');
9389

94-
$helper->addMessagesToExport(array('another'));
90+
JsLocalizationHelper::addMessagesToExport(array('another'));
9591

9692
$this->assertEquals(
9793
array_merge($this->additionalMessageKeysFlat, array('another')),
98-
$helper->getAdditionalMessages()
94+
JsLocalizationHelper::getAdditionalMessages()
9995
);
10096
}
10197

10298
public function testEventBasedAdding ()
10399
{
104-
$helper = App::make('JsLocalizationHelper');
105100
$additionalMessageKeys = $this->additionalMessageKeys;
106101

107102

108103
Event::listen('JsLocalization.registerMessages', function()
109-
use($helper, $additionalMessageKeys)
104+
use($additionalMessageKeys)
110105
{
111-
$helper->addMessagesToExport($additionalMessageKeys);
106+
JsLocalizationHelper::addMessagesToExport($additionalMessageKeys);
112107
});
113108

114-
$this->assertEquals(array(), $helper->getAdditionalMessages());
109+
$this->assertEquals(array(), JsLocalizationHelper::getAdditionalMessages());
115110

116-
$helper->triggerRegisterMessages();
111+
JsLocalizationHelper::triggerRegisterMessages();
117112

118113
$this->assertEquals(
119114
$this->additionalMessageKeysFlat,
120-
$helper->getAdditionalMessages()
115+
JsLocalizationHelper::getAdditionalMessages()
121116
);
122117

123118

124119
$this->addTestMessage('another', 'Another test text.');
125120

126-
Event::listen('JsLocalization.registerMessages', function() use($helper)
121+
Event::listen('JsLocalization.registerMessages', function()
127122
{
128-
$helper->addMessagesToExport(array('another'));
123+
JsLocalizationHelper::addMessagesToExport(array('another'));
129124
});
130125

131-
$helper->triggerRegisterMessages();
126+
JsLocalizationHelper::triggerRegisterMessages();
132127

133128
$this->assertEquals(
134129
array_merge($this->additionalMessageKeysFlat, array('another')),
135-
$helper->getAdditionalMessages()
130+
JsLocalizationHelper::getAdditionalMessages()
136131
);
137132
}
138133

139134
public function testAddMessageFileToExport ()
140135
{
141-
$helper = App::make('JsLocalizationHelper');
142-
143136
$fileContents = '<?php return ' . var_export($this->testMessages, true) . ';';
144137
file_put_contents($this->tmpFilePath, $fileContents);
145138

146139
$prefix = 'xyz::';
147140
$prefix .= preg_replace('/\.php$/i', '', basename($this->tmpFilePath)) . '.';
148-
$helper->addMessageFileToExport($this->tmpFilePath, 'xyz::');
141+
JsLocalizationHelper::addMessageFileToExport($this->tmpFilePath, 'xyz::');
149142

150143
$testKeysFlat = $this->testKeysFlat;
151144
array_walk($testKeysFlat, function(&$key) use($prefix)
152145
{
153146
$key = $prefix . $key;
154147
});
155148

156-
$this->assertEquals($testKeysFlat, $helper->getAdditionalMessages());
149+
$this->assertEquals($testKeysFlat, JsLocalizationHelper::getAdditionalMessages());
157150
}
158151

159152
}

0 commit comments

Comments
 (0)