Repository navigation
spec(FIX-1438): a run that stopped at its budget still closes its row as done - #1887
claude[bot] wants to merge 4 commits into
Conversation
… as done The phase's completion check receives the run's outcome word; the manager still decides nothing on it. Both shipped phases refuse a budget stop, and a refusal settles through the re-pend path that already exists. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VJZRfkY7gBbiYZhr1eanR
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
FSD Architect — coherence check only. Not owner approval, not the merge gate (never-merge spec; shared No two-direction fork. This settles the FIX-1438 enrich open wall as option 2 (phase receives the harness how-it-stopped word; manager does not override the done-condition), refuses new One clarity ask (what to change): in Soft (not blocking): product name is DevForce (D-12); No Jake ping. |
There was a problem hiding this comment.
Simplify review (spec only)
Verdict: The chosen direction is the smallest correct fix for the constraints you already locked (no manager authority inversion, no new board status, phase owns "done"). Implementation should mirror what you already have for prompts: a CompletionRunContext sibling of PromptRunContext, pass handle.outcome only in decide arm 2, and keep the manager from comparing the word except when phrasing a refusal (S3). That is one field + one spread + two one-line phase guards + lab de-special-case — not a new subsystem.
What reads heavier than the code is mostly spec surface area, not the architecture.
Where the approach did not overreach
- D1 (hand to phase, don't enforce) is expensive in prose because the cost is real (BR-7 / silent partial close). Re-opening a manager default with opt-out would shrink implementation but trades away the issue's authority model; the spec argues that honestly in D1 and Follow-ups.
- D3 (both phases refuse, including PR probe) is the actual behavior change; D1 alone fixes nothing, and the spec says so plainly.
- Rejected paths (document-only, manager veto, new
TaskStatus, boolean collapse of unknown/absent) are the simpler forks; dropping them is correct for FIX-1438's goal.
Simpler spec shape (optional polish, not a fork)
These would cut repetition without changing sign-off:
- One glossary line for two different "outcome" meanings (harness stop report:
finished/stopped-at-limit/failedvs run-row bookkeeping:running/succeeded/failed). Right now SPEC and Failure taxonomy use the same word for different enums — easy implementer footgun. - Single owner per invariant: prompt/completion split → BR-6 once; pass-through word → one BR + one PLAN guardrail; D1's "silent if ignored" cost → DECISIONS D1 only (SPEC sign-off #1 can stay one line).
- Thin PLAN surfaces: rewrite S1 as "type
isDonereceives only" (existingPromptRunContextpattern), merge S4+S5 into one row with two paths, merge S6+S7, fold S3 into S2; drop or fold V8 into VG. - Tests: table-drive the four outcome values once for V1+V2; keep V7 on injected probes — avoid duplicating eight manager scenarios or live
ghin V6.
Performance (product, not CPU)
Dominant cost is extra full agent attempts when D3 refuses a budget stop (especially conductor). Early refuse before PR/git probes saves I/O on the failure path but does not offset retries. The spec names that trade in D3; no framework hot-path concern in S2.
Alternative I would not take instead
- Manager-level "never settle on
stopped-at-limit" — fixes every phase at once but blocks the "budget hit limit but job actually done" path you describe in the five-people table. - Persist harness stop on the run row and read it inside
isDone— extra persistence + blurs who decides completion; today's rowoutcomeis attempt bookkeeping, not the harness three-way word. - Third-party package — nothing here; this is your harness contract seam.
Approval: Direction and plan sequence are right for a 1 PR implementation. I'd still fold the glossary + doc dedupe before or during implement so the worker doesn't re-derive four copies of the same guardrail.
Sent by Cursor Automation: Review For Best Approach
…s outcome Re-draft: the draft repeated the issue's claim that the harness's stop report is written to the run record. It is not — it reaches no store, and is read only by the text of a failure message. The two three-value fields are now named apart in all four documents and the figure, and the plan pins the phase-side field away from `outcome`. No decision moved. Re-draft: review round 1 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VJZRfkY7gBbiYZhr1eanR
|
Round 1 folded — Your clarity ask, and it was more than a collision. Three reviewers landed on the same line, so I checked it against the code rather than just renaming. That sentence came from FIX-1438's own Problem section, which says the same thing. The spec is corrected; the Linear issue still carries the original claim — I have not rewritten someone else's stated evidence without flagging it. Say the word and I will patch that sentence on the issue too. What changed:
On the soft note: agreed, and the spec already teaches the Lab as DevForce throughout. Not folded, recorded as implementer notes ( Round 1 of the two-round budget. Generated by Claude Code |
Round 1 added a third pinned name (the field a phase reads the stop report from must not be plainly `outcome`) without updating the heading above the table. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VJZRfkY7gBbiYZhr1eanR
…ow-ups Two lines still said "the outcome" where they mean the run's stop report: the README docs bullet and the follow-up naming D1's cost. Every remaining use of "outcome" in the set now refers to the run record's own field, or quotes the lab's assertion text verbatim. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VJZRfkY7gBbiYZhr1eanR
|
Approved |


Requested by Jake · project thread
completedfor a run that ran out of turns half-way and committed the half it managed. Nothing says soFollow the second line out of each box. Today it dead-ends: the run's own word for how it stopped is recorded and no decision reads it, so a half-finished commit closes the row.
How: a supervised run reports two facts when it ends, and only one is read. The second one is handed to the phase's completion check, which stays the only thing that decides. The manager compares nothing on it.
Sign off
Open: none. Number 1 is the one to weigh — it is the choice to hand the fact down rather than rule on it centrally. Reasoning and what lost: DECISIONS.md. The cases: BUSINESS-RULES.md.
Reviewers · look here
stopped-at-limitcontrol stops being special-cased and is caught by the same assertion as the others. If that reads wrong, the removal in the plan's S6 is wrong.Not here: any new board status. No
partial, no second hold, noneeds_input— locked on the issue, and a refused budget stop settles through terminals that already exist.Spec · Decisions · Rules · Plan · FIX-1438 · under FIX-1408 (W4) · never merges
Evidence — the finding, reproduced both ways
Run on
a34a3ab, this branch's base, 2026-09-18. No model, no network.No POC was built. The reproduction is the shipped lab, and both directions were run before the spec was written.
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction document in four files, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— are we solving the right thing, for the people named?docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
proof-of-concept code, characterization tests, or an HTML mockup built to validate the
direction (
spec-poc). None of it ships. Read it tojudge whether the shape holds; do not review it as code.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
🤖 Generated with Claude Code
https://claude.ai/code/session_018VJZRfkY7gBbiYZhr1eanR
Generated by Claude Code
The proposed direction appears safe to proceed with after correcting the non-blocking outcome-persistence ambiguity in the problem statement.
Summary
This direction document proposes passing the harness-reported terminal outcome into each phase’s completion check while leaving completion authority with the phase.
stopped-at-limitbefore applying their branch or pull-request probes.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR H["Harness result"] --> S["status"] H --> O["reported outcome"] S --> M["Manager verdict handler"] O --> M M -->|"question present"| Q["Park row"] M -->|"clean run"| P["Phase completion check"] P -->|"done"| D["Settle row"] P -->|"not done"| R["Record reason and retry"] R -->|"budget remains"| N["Re-open and resume session"] R -->|"budget exhausted"| E["Error row"]Reviews (1) · Last reviewed commit: "spec(FIX-1438): a run that stopped at it..."