From 13ec2b80ea02b636270e966a789532e88bc39158 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 23 Oct 2026 20:56:23 +0000 Subject: [PATCH 1/2] spec(FIX-2058): align the epic with its four merged child specs Owner, 2026-10-23: stores are reset and no old data is read. ER-5, the retired-shape map seam and the in-flight parks line now say so: no map entries for parks, no migrated questions, BP-030 dual-read waived for this epic's persisted shapes. From FIX-2129, FIX-2131, FIX-2132 and FIX-2133 as merged: waitingOn "user" (plain rename); a steer naming the question answers it; the board's debt pass pays a held question's deadline; the hold is the row's open questions beside the held flag, not status "held"; FIX-2137 (Done) blocks every FIX-2129 resume and stays on FIX-2132; FIX-2132 merges before FIX-2131; one wait per turn points at FIX-2133. Links to the child specs now resolve on main. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6 --- specs/epics/FIX-2058/DECISIONS.md | 45 +++++++++++-------- specs/epics/FIX-2058/SPEC.md | 24 +++++----- specs/epics/FIX-2058/figures/d2-row-mark.svg | 4 +- .../figures/open-question-deadline.svg | 4 +- specs/epics/FIX-2058/figures/ownership.svg | 4 +- 5 files changed, 46 insertions(+), 35 deletions(-) diff --git a/specs/epics/FIX-2058/DECISIONS.md b/specs/epics/FIX-2058/DECISIONS.md index 83b61f3076..6cf333fe0a 100644 --- a/specs/epics/FIX-2058/DECISIONS.md +++ b/specs/epics/FIX-2058/DECISIONS.md @@ -26,7 +26,7 @@ flowchart TD |---|---| | **Instead of** | Keeping the question and review parks as the way to stop for a person on a host without durable execution | | **Because** | A fallback is the second form this epic exists to remove: every child would build and test two paths, and a person would again have two places to look. Serverless hosts without durability are not a target | -| **Applied to questions** | The owner's rule, 2026-10-23: if code reads the answer on its next line, the stop suspends with `waitForUser` (an approval, a review, input); if the work can pick up from its brief, the task holds on its row (a question, at filing or midway, [ER-8](#who-owns-what)). The hold is one form on every host, not a fallback, and needs no durable execution. Every approval suspends, "go ahead with the plan?" included, so nobody has to learn the rule. A review is a verdict the code reads; a revision request is new direction, so it is a steer into a held task. A question in a turn with no task row has nothing to hold, so it suspends as input. The mid-task question park is retired for good | +| **Applied to questions** | The owner's rule, 2026-10-23: if code reads the answer on its next line, the stop suspends with `waitForUser` (an approval, a review, input); if the work can pick up from its brief, the task holds on its row (a question, at filing or midway, [ER-8](#who-owns-what)). The hold is one form on every host, not a fallback, and needs no durable execution. Every approval suspends, "go ahead with the plan?" included, so nobody has to learn the rule. A review is a verdict the code reads; a revision request is new direction, so its words are a steer the work takes after the verdict ([FIX-2131 D1](../../issues/FIX-2131/DECISIONS.md#d1)). A question in a turn with no task row has nothing to hold, so it suspends as input. The mid-task question park is retired for good | | **Locks in** | FIX-2063 blocks every child that suspends, FIX-2129 and FIX-2131; FIX-2133's hold waits on neither it nor FIX-2129. A host without durable execution refuses a suspension loudly ([ER-6](#who-owns-what)). The kill line: if FIX-2063 can't make durability the default on dev, local and self-hosted hosts, we stop before the review park is retired | **What would change my mind:** a host we support that can't be made durable. Then the kill line @@ -44,8 +44,8 @@ It comes down to two forms of one job: a fallback park keeps the thing the epic | | | |---|---| | **Instead of** | Holding the session's key while a request is suspended for a person | -| **Because** | A request gives the key back when it suspends, and keeping it would also hold back the `onTaskSettled` requests that must run while a task waits on a person, such as a filed task ending (#3696's engineering calls; FIX-2077). The row already carries `waitingOn: "person"` (FIX-2077 D1), so the mark exists; today the steer admission doesn't read it | -| **Locks in** | [ER-2](#who-owns-what): every path that admits a request into a task's session reads the row's mark. A steer into a task waiting on a person waits for the resume; it never starts a request beside it. A steer into a task held on a question is its answer ([ER-8](#who-owns-what)) | +| **Because** | A request gives the key back when it suspends, and keeping it would also hold back the `onTaskSettled` requests that must run while a task waits on a person, such as a filed task ending (#3696's engineering calls; FIX-2077). The row already carries the mark (FIX-2077 D1's `waitingOn`, whose value FIX-2129 renames to `"user"`), so it exists; today the steer admission doesn't read it | +| **Locks in** | [ER-2](#who-owns-what): every path that admits a request into a task's session reads the row's mark. A steer into a task waiting on a person waits for the resume; it never starts a request beside it. A steer naming the question is its answer ([ER-8](#who-owns-what)) | | **Not decided here** | Messages. A send or a call to a session waiting on a person follows rule 10 as written: it queues. Giving the key back could let one run instead; that is FIX-2070's call, and FIX-2129 pins what a message does there today with a test so the change is seen | **What would change my mind:** an engine key that holds a session's requests but lets @@ -77,9 +77,10 @@ It comes down to a person being away: the wait default fails their work within m ![Who owns what: eight rules by six issues and the closure FIX-2134, each rule with one owner](figures/ownership.svg) -A *uses* cell is a place a child must not re-decide. FIX-2137 owns no rule. It blocks FIX-2063's -default flip and FIX-2129's approval resumes; it may no longer block FIX-2132, whose question now -holds with no suspension to resume, and FIX-2132's spec confirms or drops that edge. +A *uses* cell is a place a child must not re-decide. FIX-2137 owns no rule and is Done (#3749). +It blocks FIX-2063's default flip and every FIX-2129 resume, and stays on FIX-2132: the manager's +own question holds, but a host's own harness block, judge or hook can still `ctx.suspend` +([FIX-2132 D1](../../issues/FIX-2132/DECISIONS.md#d1)). | # | Rule every child obeys | Owner | Checked at | |---|---|---|---| @@ -87,23 +88,23 @@ holds with no suspension to resume, and FIX-2132's spec confirms or drops that e | ER-2 | A task waiting on a person is marked on its row with the suspension that holds it. That mark, never the session's key, keeps its requests apart: while it waits, only `onTaskSettled` and the suspension's own answer are admitted, a steer waits for the resume, and messages follow rule 10 ([D2](#d2)). The mark lands in the same write that drops the lease. A person's stop never holds back the notices of tasks its request filed: FIX-2123 holds them while a filing request is parked, and FIX-2129 exempts a person's stop from that hold | FIX-2129 | FIX-2131's spec review; the closure's leg d | | ER-3 | A stop ends exactly once: a suspension resumes answered, deadline or cancelled, and a question's hold ends answered, deadline or cancelled ([ER-8](#who-owns-what)). Whichever comes first wins and the rest find it resolved, and every ending closes its item, an unhandled deadline included. A user's stop ends the request, closes its item and cancels its task | FIX-2129 | FIX-2131's, FIX-2132's and FIX-2133's spec review; legs b and c | | ER-4 | No task tool answers a suspension for a person. The filer answers only a question its task asked midway, by a steer, and not on a routed task; approvals, reviews and questions asked at filing are the user's (rule 11) | FIX-2131 | Every later spec review; the closure sweep | -| ER-5 | A row parked before the refactor is read through FIX-2080's one map ([FIX-2056 D3](../FIX-2056/DECISIONS.md#d3)), never a child's own read. One owner maps every parked question, harness rows included, onto the hold ([ER-8](#who-owns-what)): the rows share one shape (`awaitReview`, `parkPatch`), so no split by row is possible. Where a coding row needs its session back, FIX-2132 reads that from the harness manager's run record (`harness-manager/src/run-record.ts`), not from the row. States in flight between the refactor epics get no shim | FIX-2131 | FIX-2132's spec review | +| ER-5 | No row persisted before this work is read: stores are reset (owner, 2026-10-23). FIX-2080's retired-shape map ([FIX-2056 D3](../FIX-2056/DECISIONS.md#d3)) gains no entry for a parked question or review, harness rows included, and no question is migrated onto the hold ([ER-8](#who-owns-what)); BP-030's dual-read is waived for this epic's persisted shapes. The `parked` status goes as a write and a read. Where a coding row needs its session back, FIX-2132 reads that from the harness manager's run record (`harness-manager/src/run-record.ts`), not from the row. States in flight between the refactor epics get no shim | FIX-2131 | FIX-2132's spec review | | ER-6 | Suspending for a person needs durable execution, on by default wherever stores persist. No child builds a path for a host without it; such a host refuses a suspension loudly. A question's hold needs none | FIX-2063 | Every spec review | -| ER-7 | The Inbox answers each kind of item through one route the server trusts, and the server sets who answered. A suspension resumes through FIX-2129's route, without opening the public resume route to a `task` source (BP-031), and only after the checks the public resume path runs (`ownsRecord` and `callerReachesRequest`: flow instance, tenant, user, org) before it loads or resolves the suspension ([FIX-2129's spec](https://github.com/fixpoint-labs/flow-state-dev/blob/spec/FIX-2129/specs/issues/FIX-2129/DECISIONS.md), #3735, pending merge). A held question is answered by a steer from the user through the board's own `updateTask` action, which scopes the row to the signed-in user, tenant and org the same way, and names the question it answers ([FIX-2133 D1](https://github.com/fixpoint-labs/flow-state-dev/blob/spec/FIX-2133/specs/issues/FIX-2133/DECISIONS.md#d1), #3747, pending merge). No child builds a third route | FIX-2129; FIX-2133 builds the question leg | FIX-2131's, FIX-2132's and FIX-2133's spec review; leg b | -| ER-8 | One hold for a question. Open questions are a predicate on the task's row, whatever its status, and the one source of truth: the claim gate never claims the row, and it never settles except by cancel; a status is at most derived from it. Every change to it is one pure write both store backings call, beside the predicate in `orchestration/src/tasks/collection/`: ask, answer (a steer carrying the question's id; one carrying none answers nothing), deadline (a "no answer came" steer; [Open](#open)) and cancel. One deadline: the board's debt pass (rule 8), 7 days by default ([D3](#d3)). Before start the row is `pending`; midway, `in_progress` with no lease, re-entered on its same attempt ([FIX-2086](../../issues/FIX-2086/DECISIONS.md#d2)'s steer turn). Every claim of a row advances a turn generation that every claim-ticket write (renew, complete, fail, settle) checks, so a predecessor turn never writes after its successor's claim. Re-entry holds three invariants: at most one live turn per attempt; a row with no open question is never stranded; a stop ends exactly once. The mechanism is [FIX-2133's](https://github.com/fixpoint-labs/flow-state-dev/blob/spec/FIX-2133/specs/issues/FIX-2133/DECISIONS.md) (#3747, pending merge) to design and prove with tests, and further protocol findings go to its spec and implementation review, not to this epic. The word stays *hold*, the concept's *held on questions*; renames are FIX-2071's | FIX-2133 | FIX-2131's and FIX-2132's spec review; legs a, b and c | +| ER-7 | The Inbox answers each kind of item through one route the server trusts, and the server sets who answered. A suspension resumes through FIX-2129's route, without opening the public resume route to a `task` source (BP-031), and only after the checks the public resume path runs (`ownsRecord` and `callerReachesRequest`: flow instance, tenant, user, org) before it loads or resolves the suspension ([FIX-2129 D2](../../issues/FIX-2129/DECISIONS.md#d2)). A held question is answered by a steer from the user through the board's own `updateTask` action, which scopes the row to the signed-in user, tenant and org the same way, and names the question it answers ([FIX-2133 D1](../../issues/FIX-2133/DECISIONS.md#d1)). No child builds a third route | FIX-2129; FIX-2133 builds the question leg | FIX-2131's, FIX-2132's and FIX-2133's spec review; leg b | +| ER-8 | One hold for a question. Open questions are a predicate on the task's row, whatever its status, and the one source of truth: the claim gate never claims the row, and it never settles except by cancel; a status is at most derived from it. Every change to it is one pure write both store backings call, beside the predicate in `orchestration/src/tasks/collection/`: ask, answer (a steer carrying the question's id; one carrying none answers nothing), deadline (a "no answer came" steer; [Open](#open)) and cancel. One deadline: the board's debt pass (rule 8), 7 days by default ([D3](#d3)). Before start the row is `pending`; midway, `in_progress` with no lease, re-entered on its same attempt ([FIX-2086](../../issues/FIX-2086/DECISIONS.md#d2)'s steer turn). Every claim of a row advances a turn generation that every claim-ticket write (renew, complete, fail, settle) checks, so a predecessor turn never writes after its successor's claim. Re-entry holds three invariants: at most one live turn per attempt; a row with no open question is never stranded; a stop ends exactly once. The mechanism is [FIX-2133's](../../issues/FIX-2133/DECISIONS.md) to design and prove with tests, and further protocol findings go to its spec and implementation review, not to this epic. The word stays *hold*, the concept's *held on questions*; renames are FIX-2071's | FIX-2133 | FIX-2131's and FIX-2132's spec review; legs a, b and c | ## Coordination seams | Seam | Owner, then who else touches it | |---|---| -| The claim gate's stop arm (`orchestration/src/task-board/task-request.ts`, `stopOf`) | FIX-2129 keys it on ER-1's predicate, records the suspension on the row, and adds the cancel and the user's stop; FIX-2133 adds the refusal of a row with an open question and the settle guard (ER-8) | +| The claim gate's stop arm (`orchestration/src/task-board/task-request.ts`, `stopOf`) | FIX-2129 keys it on ER-1's predicate, records the suspension on the row, and adds the cancel and the user's stop; FIX-2133 adds the refusal of a row with an open question, which cancels the losing suspension, and the settle guard (ER-8). One wait per turn, a row never holding both, is [FIX-2133's rule](../../issues/FIX-2133/DECISIONS.md#decided-not-asked) | | The suspension record, the stop and the sweep (`core/src/types/suspension.ts`, `engine/src/durability/stop-suspended.ts`, `durability-sweeper.ts`) | FIX-2137 makes a resume skip its completed steps with trace observability off; FIX-2063 runs the sweeper on file-backed hosts; FIX-2129 adds the kind, the person-stop default deadline ([D3](#d3)) and its host setting, which FIX-2133's question deadline reads (a 7-day constant until it lands), the deadline resume and the stop that cancels. The wait gate (`core/src/types/wait-gate.ts`) stays for waits on work: `waitForUser` shares its words answered and deadline, not their shape or its mechanism, and adds `cancelled` (ER-1) | | The answer route (`engine/src/routes/resume-routes.ts`, its public re-entry check; `shift-manager/src/lib/reads.ts`, `REOPENED_SOURCES`) | FIX-2129 builds ER-7's route for suspensions, and FIX-2131's reviews answer through it. FIX-2133 answers a held question through the board's `updateTask` action, and FIX-2131 and FIX-2132 reuse it | -| Steer admission (`workforce/src/conversation-board/steer.ts`, `task-admission.ts`) | FIX-2113's gate stays for plan waits. FIX-2131 makes a steer into a task waiting on a person wait (ER-2) and a steer into a held question answer it (ER-8); FIX-2132 makes that answer start the next coding run in the same coding session | +| Steer admission (`workforce/src/conversation-board/steer.ts`, `task-admission.ts`) | FIX-2113's gate stays for plan waits. FIX-2131 makes a steer into a task waiting on a person wait (ER-2) and a steer naming a held question answer it (ER-8); FIX-2132 makes that answer start the next coding run in the same coding session | | The Inbox read (`shift-manager/src/lib/reads.ts`, `send.ts`, `surfaces/Inbox.tsx`) | FIX-2131 lists reviews through ER-1's predicate and moves `reads.ts` and `send.ts` onto it; FIX-2133 lists held questions, before start and midway, read from task rows; FIX-2131 and FIX-2132 add nothing a held question doesn't | | The task tools and the closure sweep (`orchestration/src/skills/task-tools-capability.ts`; `rules.mjs` on `fix/FIX-2087`) | FIX-2131 removes `answerTask` and `parkOnQuestion` and their allowances in the sweep. Its midway ask calls ER-8's write; what the request did before asking stands (its writes, messages and last checkpoint), and the next turn starts from the brief, that checkpoint and the answer | -| FIX-2080's retired-shape map (`orchestration/src/tasks/collection/`) | FIX-2131 adds the parked question and review entries, harness rows included, each question mapped onto ER-8's hold (ER-5). FIX-2132 adds no entry: a coding row's confirmed session comes back from the harness manager's run record, spending no try. A parked question maps onto the hold, so both wait on FIX-2133, as the graph shows | -| The hold (`updateTask` `status: "held"`, FIX-2080, and the row's open questions) | FIX-2133 owns the hold on questions (ER-8), its one write and the re-entry protocol, proved by its own tests against both backings. Its constraints: ask adds the question, drops the lease and ends the turn unsettled; the last answer or the deadline releases the hold; cancel closes every question with the row, from both backings' direct and cascade cancel (`state-backed.ts`, `resource-backed.ts`); `renewLease` and `reclaim()` refuse a row with an open question, an ask racing a renewal included; the write that closes the last question sets an owed-turn mark on the row in that same write, never relying on a wake record (owed before the row write, and absent without `RequestWakes`, `request-host.ts`); the claim gate claims a marked `in_progress` row with no lease and no open question for its same attempt, spending no fresh budget, and clears the mark atomically; every claim advances the turn generation that claim-ticket writes check (today ownership is fenced only by row, status and attempt, `internal.ts`); a wake, where the host has one, only starts the turn sooner; `updateTask` gains a question id, accepted from the public action for any question and from the filer's tool only for a midway question on a task not routed (ER-4), so filing with several questions keeps working. FIX-2131 and FIX-2132 ask through it | +| FIX-2080's retired-shape map (`orchestration/src/tasks/collection/`) | No child adds an entry: stores are reset, so no parked row is read (ER-5). FIX-2131 removes the `parked` status; FIX-2132's coding row gets its confirmed session back from the harness manager's run record, spending no try | +| The hold (the row's open questions, beside FIX-2080's `held` flag, which composes with them: both must clear) | FIX-2133 owns the hold on questions (ER-8), its one write and the re-entry protocol, proved by its own tests against both backings. Its constraints: ask adds the question, drops the lease and ends the turn unsettled; the last answer or the deadline releases the hold; cancel closes every question with the row, from both backings' direct and cascade cancel (`state-backed.ts`, `resource-backed.ts`); `renewLease` and `reclaim()` refuse a row with an open question, an ask racing a renewal included; the write that closes the last question sets an owed-turn mark on the row in that same write, never relying on a wake record (owed before the row write, and absent without `RequestWakes`, `request-host.ts`); the claim gate claims a marked `in_progress` row with no lease and no open question for its same attempt, spending no fresh budget, and clears the mark atomically; every claim advances the turn generation that claim-ticket writes check (today ownership is fenced only by row, status and attempt, `internal.ts`); a wake, where the host has one, only starts the turn sooner; `updateTask` gains a question id, accepted from the public action for any question and from the filer's tool only for a midway question on a task not routed (ER-4), so filing with several questions keeps working. FIX-2131 and FIX-2132 ask through it | ## Decided in review, recorded so no child reopens them @@ -111,13 +112,13 @@ Settled from the sources before review: - **Timeout policy per kind** (the Linear epic's open question): the concept's deadline rule. The block handles a deadline; unhandled, an approval counts as rejected and a review or input - errors, using an attempt. A held question's deadline is the sweeper's ([ER-8](#who-owns-what)). + errors, using an attempt. A held question's deadline is the board's debt pass's ([ER-8](#who-owns-what)). The default length is [D3](#d3). - **A coding run's question shares the Inbox card:** it holds its task like any question (concept, *Inbox items*, last paragraph), so its item is a question's. - **In-flight parks** (owner, 2026-10-23): nothing deploys until the related refactor epics land, so in-flight and deploy-window states between them get no BP-030 shim. Rows persisted before the - refactor are still read (ER-5). + refactor aren't read either: stores are reset (owner, later the same day; ER-5). - **Telling the filer moved to FIX-2070** (owner, 2026-10-23), with a comment there. The row's record of the question stays here, as the hold (FIX-2133). - **FIX-2133 is kept** (owner), over a proposed cut. @@ -161,8 +162,13 @@ After the merge (owner, 2026-10-23): on `pending` and `in_progress` rows alike, and a status for the pre-start case would make it two. Its midway case is the owner's, and joins it. - **FIX-2137 joins the set** as a direct-route bug, no spec: a durable resume with trace - observability off runs completed steps again. It blocks FIX-2063's default flip and FIX-2129's - approval resumes; its edge to FIX-2132 may drop ([who owns what](#who-owns-what)). + observability off runs completed steps again. It blocks FIX-2063's default flip and every + FIX-2129 resume, and FIX-2132's spec keeps its edge ([who owns what](#who-owns-what)). +- **No old data** (owner, 2026-10-23): "I don't care about old data. For now we will be resetting + everything." Stores are reset, and nothing persisted before this work is read: no retired-shape + map entries for parks, no migrated questions, and BP-030's dual-read waived for this epic's + persisted shapes ([ER-5](#who-owns-what)). So `waitingOn: "person"` becomes `"user"` as a plain + rename (FIX-2129), the stored old value unread. ## What the end-state POC showed @@ -183,6 +189,9 @@ check. `cancelled` as a person's stop's outcome, messages left to rule 10. - **2026-10-23**, after the merge: the owner decided questions hold their task and code-consumed answers suspend; ER-8 added, owned by FIX-2133. +- **2026-10-23**, the owner: no old data, stores are reset (ER-5). The epic aligned with its four + merged child specs: `waitingOn: "user"`; FIX-2137, Done, kept on FIX-2132; FIX-2132 merges + before FIX-2131. ## Open @@ -196,7 +205,7 @@ check. a question whose answer the code can't do without is input, and suspends. - **What would change my mind:** apps where a guessed answer does harm, such as spending money. Those should ask an approval, which reads as a no at its deadline. -- **What being wrong costs:** one sweeper outcome to flip in FIX-2133 before it ships. +- **What being wrong costs:** one debt-pass outcome to flip in FIX-2133 before it ships. ![Open: what an unanswered question does at its deadline. Go ahead from the brief, recommended, beside failing that try; decided by the work being able to go on, which is why it is a question](figures/open-question-deadline.svg) diff --git a/specs/epics/FIX-2058/SPEC.md b/specs/epics/FIX-2058/SPEC.md index 8d63a012ba..5d44a34990 100644 --- a/specs/epics/FIX-2058/SPEC.md +++ b/specs/epics/FIX-2058/SPEC.md @@ -91,9 +91,9 @@ The reviewed snapshot; live state is in Linear. FIX-2056 blocks every child too. | Issue | Delivers | Blocked by | |---|---|---| | [FIX-2063](https://linear.app/fixpoint-labs/issue/FIX-2063) · durable by default | Durability and the sweeper with no app config; a host without it refuses a suspension loudly. Stays in Developer Tools | FIX-2137, for the default flip | -| [FIX-2129](https://linear.app/fixpoint-labs/issue/FIX-2129) · a suspension holds its task and ends once | `waitForUser`, kinds approval, review and input; the person mark keyed on it; the claim across a resume; the row's record of its stop; the Inbox's one answer route; answered, deadline or cancelled, and a user's stop cancels the task | FIX-2063; FIX-2137, for approval resumes | -| [FIX-2131](https://linear.app/fixpoint-labs/issue/FIX-2131) · questions and reviews | A review suspends; a midway question holds its task ([ER-8](DECISIONS.md#who-owns-what)); retires both parks, `answerTask`, `unparkAndDrain`; a steer answers a question; the Inbox lists both | FIX-2063, FIX-2129, FIX-2133 | -| [FIX-2132](https://linear.app/fixpoint-labs/issue/FIX-2132) · a coding run's question | The question holds its task; the answer, a steer, starts the next run in the same coding session; the harness inbox goes; LAB-162's park is superseded | FIX-2133; FIX-2137, which may drop ([ownership](DECISIONS.md#who-owns-what)) | +| [FIX-2129](https://linear.app/fixpoint-labs/issue/FIX-2129) · a suspension holds its task and ends once | `waitForUser`, kinds approval, review and input; the person mark keyed on it; the claim across a resume; the row's record of its stop; the Inbox's one answer route; answered, deadline or cancelled, and a user's stop cancels the task | FIX-2063; FIX-2137 (Done), for every resume | +| [FIX-2131](https://linear.app/fixpoint-labs/issue/FIX-2131) · questions and reviews | A review suspends; a midway question holds its task ([ER-8](DECISIONS.md#who-owns-what)); retires both parks, `answerTask`, `unparkAndDrain`; a steer answers a question; the Inbox lists both | FIX-2063, FIX-2129, FIX-2133; merges after FIX-2132, which moves the harness parks off the shared park this removes | +| [FIX-2132](https://linear.app/fixpoint-labs/issue/FIX-2132) · a coding run's question | The question holds its task; the answer, a steer, starts the next run in the same coding session; the harness inbox goes; LAB-162's park is superseded | FIX-2133; FIX-2137 (Done): a host's own harness block may still suspend ([FIX-2132 D1](../../issues/FIX-2132/DECISIONS.md#d1)) | | [FIX-2133](https://linear.app/fixpoint-labs/issue/FIX-2133) · held on questions | The hold, one row predicate before start and midway: the claim gate refuses the row, it can't settle, one item, the last answer or the deadline releases it | — | | [FIX-2137](https://linear.app/fixpoint-labs/issue/FIX-2137) · a durable resume runs completed steps again · bug | A durable resume with trace observability off no longer runs its completed steps again. Direct route: no spec, a fix PR | — | | [FIX-2134](https://linear.app/fixpoint-labs/issue/FIX-2134) · closure · **required** | The QA plan, on one `main` commit | every other child | @@ -110,12 +110,13 @@ flowchart LR I["FIX-2056 · claim gate, steer, getTask · consumed"] -.-> B K["FIX-2137 · a durable resume runs completed steps again"] -->|"a resume that runs once"| A K -->|"a resume that runs once"| B - K -.->|"may drop"| E + K -->|"a resume that runs once"| E A["FIX-2063 · durable by default"] -->|"durable suspensions and the sweeper"| B["FIX-2129 · a suspension holds its task and ends once"] B -->|"the person mark, the answer route"| D["FIX-2131 · questions and reviews"] I -.-> G["FIX-2133 · held on questions"] G -->|"the hold"| D G -->|"the hold"| E["FIX-2132 · a coding run's question"] + E -.->|"merges first · the harness parks moved"| D A --> P["FIX-2134 · closure · required"] B --> P D --> P @@ -124,8 +125,9 @@ flowchart LR G --> P ``` -An edge is what one issue hands the next; the dashed input is consumed, not owned, and FIX-2137's -dashed edge into FIX-2132 may drop. FIX-2056 blocks +An edge is what one issue hands the next; the dashed input is consumed, not owned, and the dashed +edge from FIX-2132 to FIX-2131 is merge order only: FIX-2131 builds in parallel and merges after it. +FIX-2137, Done, stays on FIX-2132 because a host's own harness block may suspend. FIX-2056 blocks every child, drawn into the two that start first. FIX-2063 blocks the two that suspend; FIX-2133's hold needs neither it nor FIX-2129, and comes before the two that ask a question midway. @@ -142,10 +144,10 @@ hold needs neither it nor FIX-2129, and comes before the two that ask a question | Already here | What the set does with it | |---|---| -| FIX-2077 D1: an approval or input stop records `waitingOn: "person"`, drops the lease, and the resume completes the same attempt (`orchestration/src/task-board/task-request.ts:298-310`) | **Builds on.** The gaps row saying the row lapses (`task-entry.ts:533-537`) predates it | +| FIX-2077 D1: an approval or input stop records `waitingOn: "person"` (renamed `"user"` by FIX-2129; stores are reset, so the old value is not read), drops the lease, and the resume completes the same attempt (`orchestration/src/task-board/task-request.ts:298-310`) | **Builds on.** The gaps row saying the row lapses (`task-entry.ts:533-537`) predates it | | [FIX-2056 D2](../FIX-2056/DECISIONS.md#d2): marking the task and answering by steer are this epic's | **Kept and finished** by FIX-2129 and FIX-2131 | | [FIX-2056 (e)](../FIX-2056/DECISIONS.md#e): its closure sweep allows `answerTask` and `parkOnQuestion` until this epic (`rules.mjs`, on `fix/FIX-2087`; on `main` with FIX-2056's closure, before any child starts) | **Ended** by FIX-2131 | -| [FIX-2056 D3](../FIX-2056/DECISIONS.md#d3): retired rows read through FIX-2080's one map | **Extended** to parked rows ([ER-5](DECISIONS.md#who-owns-what)) | +| [FIX-2056 D3](../FIX-2056/DECISIONS.md#d3): retired rows read through FIX-2080's one map | **Unchanged:** no entry for parked rows, since stores are reset and nothing persisted before this work is read ([ER-5](DECISIONS.md#who-owns-what)) | | #3696: a parked request gives back the session's key | **Kept**; the row's mark holds a person's suspension instead ([D2](DECISIONS.md#d2)) | | Three copies of "is it a person's stop": the gate's `stopOf` (`task-request.ts`), `PERSON_REASONS` (`shift-manager/src/lib/reads.ts`) and the Lab send's own `stopOf` on it (`send.ts`) | **Replaced** by one predicate in `contracts` ([ER-1](DECISIONS.md#who-owns-what)) | | The Inbox can't answer a stop in a task's request: the public resume route refuses a `task` source, and opening it would re-enter a task's handler with caller data (BP-031) | **Replaced** by one trusted route per kind ([ER-7](DECISIONS.md#who-owns-what)), FIX-2129 | @@ -154,7 +156,7 @@ hold needs neither it nor FIX-2129, and comes before the two that ask a question | The debt | | |---|---| | **Removes** | Both parks, the harness question inbox, `answerTask`, `unparkAndDrain`, `answerQuestion()`, two extra person-stop checks, the Inbox's unanswerable task stops | -| **Adds** | `waitForUser`, one hold on questions with one pure answer-and-release write both store backings call ([ER-8](DECISIONS.md#who-owns-what)), a default deadline for a person's stop ([D3](DECISIONS.md#d3)), one trusted answer route, retired-shape map entries for parked rows | +| **Adds** | `waitForUser`, one hold on questions with one pure answer-and-release write both store backings call ([ER-8](DECISIONS.md#who-owns-what)), a default deadline for a person's stop ([D3](DECISIONS.md#d3)), one trusted answer route | **Net: down.** Six forms and three answer paths become one suspension, one hold and one trusted route per kind (ER-7). @@ -162,7 +164,7 @@ hold needs neither it nor FIX-2129, and comes before the two that ask a question **[The goal](#the-goal-and-how-well-know-its-met):** five kinds, one Inbox, the same attempt. If wrong: we wrap with a stop a person still can't find. **[The debt](#whats-already-here-and-the-debt):** -net down. If wrong: map entries nobody reads. +net down. If wrong: a second path to a person survives somewhere. 1. **[D1](DECISIONS.md#d1) · Durable execution by default comes first; no park survives as a fallback.** Questions hold their task instead and need neither. If wrong: a host we care about @@ -175,7 +177,7 @@ net down. If wrong: map entries nobody reads. **Decided by the owner:** the five objective lines; FIX-2133 kept; [questions hold their task, approvals, reviews and input suspend](DECISIONS.md#d1) (2026-10-23); the filer's message to FIX-2070; -[no shim for in-flight states](DECISIONS.md#decided-in-review-recorded-so-no-child-reopens-them); +[no shim for in-flight states, and no old data read: stores are reset](DECISIONS.md#decided-in-review-recorded-so-no-child-reopens-them); #1612 closed as superseded; D3. **Decided in review, engineering:** FIX-2130 folded into FIX-2129; LAB-162's park superseded; diff --git a/specs/epics/FIX-2058/figures/d2-row-mark.svg b/specs/epics/FIX-2058/figures/d2-row-mark.svg index 7432b7786f..f64fbf3288 100644 --- a/specs/epics/FIX-2058/figures/d2-row-mark.svg +++ b/specs/epics/FIX-2058/figures/d2-row-mark.svg @@ -1,4 +1,4 @@ -