Repository navigation
FIX-2242: the closure walk waits for FIX-2269's continued call - #4193
Conversation
FIX-2269's durability sweep continues an interrupted call a stale threshold later, so a:answer-in-request now follows the request until it completes or times out instead of stopping at interrupted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Second look / architecture pass (one file, +7/−4, Verdict: the approach is right; no better shape. Giving Optional notes for the implementer. None blocks merge.
Generated by Claude Code |
There was a problem hiding this comment.
Simplify review (FIX-2242)
Verdict: approve. This is a small, well-scoped harness fix: scene ac was stopping its poll on interrupted before FIX-2269's durability sweep could re-drive the request to completion. The diff does not widen scope or add layers elsewhere.
Approach
Parameterizing follow() with an optional ends set (default unchanged ENDED) is the right level of abstraction for this repo's goal scripts. Alternatives considered:
| Alternative | Tradeoff |
|---|---|
stopOnInterrupted?: boolean on follow() |
Smaller API for today's single caller, but another special case if a second status gets the same treatment. |
Inline new Set([...ENDED].filter(...)) at the call site |
Drops OWED_ENDS but repeats the rule and reads worse. |
Special-case interrupted inside follow() behind a scene flag |
Couples the helper to FIX-2242/2269 semantics; worse than passing ends. |
Duplicate poll loop only in sceneAC |
More duplication than this change. |
Deriving OWED_ENDS from ENDED keeps one source of truth for terminal statuses — good DRY for a file that already maintains ENDED / TERMINAL.
Parallel review notes
- Performance: No concerns. One module-level set; poll loop unchanged.
- Reuse:
legs-calls.mtsdefines a separateENDED(withoutinterrupted) fortalkThrough. Unifying across goals would be a broader cleanup, not required here; localized change is fine. - sceneED (line 256) still uses default
ENDED. That path expects park → resume → completion, not crash-before-park; I would not change it on this PR, but if FIX-2269 recovery ever applies there too, the sameOWED_ENDSknob is available.
Optional nits (non-blocking)
See inline. None block merge.
Sent by Cursor Automation: Review For Best Approach
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Code Snob — already tight on a63f8cf. No POC.
Read goals/shift-manager/workers-talk-together/scenes.mts (ENDED, OWED_ENDS, follow, the scene ac call, the scene ed call) and until in goals/shift-manager/workers-message-each-other/legs.mts.
A rewrite would not shrink this contract:
- Scene ac keeps polling through
interruptedand still recordsseen. The otherfollowstill stops oninterrupted. That is one optional end-set and one derived set. - A
throughInterruptedflag is the same size, with a narrower knob. - Calling
followagain after it returnsinterruptedstops on the same status. untildrops the status trail the assertion prints.- Inlining the filter, or a helper for one subtraction, is not shorter.
The two-line comment is why interrupted is left out. Cutting it does not change the wait.
Sent by Cursor Automation: Code Snob
…ab inventory The lab's README inventory went stale on main with FIX-2288 (#4183), which reds Test (3/3); this is the same --write output any fix would carry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
|
Test (3/3) failed in Generated by Claude Code |
|
Test (2/3) fails in Generated by Claude Code |
…sh tests (FIX-2269) Since per-worker token usage, a worker's request owes a request-end hook from its start. The dead host's frozen request never pays it, and the debt is kept per process, which both test hosts share, so the next host's dispose waited out its 10 s drain and the afterEach hook timed out. Dispose its router with a short drain first, as the orchestration crash test does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiEuGX4bfXGJoNxGQ6f
|
I ported #4204's test fix by cherry-picking its one commit that touches Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9


Follow-up to #4129 (merged), the FIX-2070 closure walk.
The problem
With FIX-2269 (#4078) merged, a call that dies after its row is written but before it parks is continued by the durability sweep, about one stale threshold later. Scene ac's
a:answer-in-requeststopped following the request as soon as it readinterrupted, so it failed on main even though the host goes on to continue and complete the request.The change
followtakes the set of statuses that end it. Fora:answer-in-requestthat set leaves outinterrupted: the scene keeps polling, up to the same 360 s, until the request completes or fails. A request that stays interrupted still times out and fails, so a never-continued call is still a finding.Verification
On
df924362e(main with FIX-2269),GOAL_SCENES=ac, real models:a:answer-in-requestFAIL, with the request read asin_progress > interrupted.c:lands-once,a:answer-in-request,a:one-placeanda:no-relay. The request wentin_progress > interrupted > in_progress > completed, and its call answeredansweredwith the codename.FIX-2279 is still open, so the passing verdict row for the whole walk will come once it lands. No changeset is needed, since this only touches a goal.
Generated by Claude Code