Skip to content

POC: fold the collection read gate into isLlmReadable - #4428

Closed
cursor[bot] wants to merge 5 commits into
mainfrom
poc/fold-collection-read-gate
Closed

cursor[bot] wants to merge 5 commits into
mainfrom
poc/fold-collection-read-gate

Conversation

@cursor

@cursor cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This does not merge. It is a subtraction against #4426 (head 358ff502). Fold it into that PR, then close this unmerged.

Subtracted

isCollectionLlmReadable repeated isLlmReadable (config.llmReadable === true). The exported gate now takes a resource ref or a collection ref. Listing, projected search, and readResource call that one check.

What a read returns is unchanged. Writes are untouched.

Still passes

  • packages/engine/test/resource-tools-path-matching.test.ts — 56 passed
  • packages/workforce/test/resource-tools-key-read.test.ts — 1 passed
  • core content, search, and manifest resource tests — 48 passed
  • pnpm --filter @flow-state-dev/core exec tsc -p tsconfig.json --noEmit — clean
  • eslint on packages/core/src/tools/resource-tools.ts — clean
Open in Web View Automation 

claude and others added 5 commits November 1, 2026 00:00
…secret fields (FIX-2436)

readResource resolved a path against every registered collection and
returned the full stored state, so a worker given resourceTools() beside a
collection it may not show the model (a user's MCP keys) could read it.
The read now reaches only a collection that opted in with llmReadable, the
gate the content and search tools already apply, and drops the fields the
collection names in secret. Any other path answers as one no collection
matches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
…k a consumer (FIX-2436)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
…ource (FIX-2436)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
The collection helper repeated the same config.llmReadable check.
The exported gate now accepts a collection ref, so list, search, and
readResource call it.

Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Nov 1, 2026 12:11am UTC
flow-state-dev-kitchen-sink Ignored Ignored Nov 1, 2026 12:11am UTC
flow-state-dev-ui Ignored Ignored Nov 1, 2026 12:11am UTC
flow-state-dev-build-site Skipped Skipped Nov 1, 2026 12:11am UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants