Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 187c5b3

Browse files
authored
[Impeller] Gaussian blur: Remove lingering BlurStyle vertex data/uniforms. (#45524)
Follow-up for #45520. Missed a few things... These were getting defaulted thanks to impeller's header gen but don't have any purpose now that we've removed the old blur style impl.
1 parent 75437a3 commit 187c5b3

File tree

3 files changed

+33
-39
lines changed

3 files changed

+33
-39
lines changed

impeller/entity/shaders/gaussian_blur/gaussian_blur.glsl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ f16vec4 Sample(f16sampler2D tex, vec2 coords) {
4141
}
4242

4343
in vec2 v_texture_coords;
44-
in vec2 v_src_texture_coords;
4544

4645
out f16vec4 frag_color;
4746

impeller/entity/shaders/gaussian_blur/gaussian_blur.vert

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,16 @@
88
uniform FrameInfo {
99
mat4 mvp;
1010
float texture_sampler_y_coord_scale;
11-
float alpha_mask_sampler_y_coord_scale;
1211
}
1312
frame_info;
1413

1514
in vec2 vertices;
1615
in vec2 texture_coords;
17-
in vec2 src_texture_coords;
1816

1917
out vec2 v_texture_coords;
20-
out vec2 v_src_texture_coords;
2118

2219
void main() {
2320
gl_Position = frame_info.mvp * vec4(vertices, 0.0, 1.0);
2421
v_texture_coords =
2522
IPRemapCoords(texture_coords, frame_info.texture_sampler_y_coord_scale);
26-
v_src_texture_coords = IPRemapCoords(
27-
src_texture_coords, frame_info.alpha_mask_sampler_y_coord_scale);
2823
}

impeller/tools/malioc.json

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -3449,11 +3449,11 @@
34493449
"load_store"
34503450
],
34513451
"longest_path_cycles": [
3452-
0.03125,
3453-
0.03125,
3454-
0.03125,
3452+
0.015625,
3453+
0.015625,
3454+
0.015625,
34553455
0.0,
3456-
4.0,
3456+
3.0,
34573457
0.0
34583458
],
34593459
"pipelines": [
@@ -3468,29 +3468,29 @@
34683468
"load_store"
34693469
],
34703470
"shortest_path_cycles": [
3471-
0.03125,
3472-
0.03125,
3473-
0.03125,
3471+
0.015625,
3472+
0.015625,
3473+
0.015625,
34743474
0.0,
3475-
4.0,
3475+
3.0,
34763476
0.0
34773477
],
34783478
"total_bound_pipelines": [
34793479
"load_store"
34803480
],
34813481
"total_cycles": [
3482-
0.03125,
3483-
0.03125,
3484-
0.03125,
3482+
0.015625,
3483+
0.015625,
3484+
0.015625,
34853485
0.0,
3486-
4.0,
3486+
3.0,
34873487
0.0
34883488
]
34893489
},
34903490
"stack_spill_bytes": 0,
34913491
"thread_occupancy": 100,
34923492
"uniform_registers_used": 22,
3493-
"work_registers_used": 10
3493+
"work_registers_used": 8
34943494
}
34953495
}
34963496
}
@@ -7028,11 +7028,11 @@
70287028
"load_store"
70297029
],
70307030
"longest_path_cycles": [
7031-
0.03125,
7032-
0.03125,
7033-
0.03125,
7031+
0.015625,
7032+
0.015625,
7033+
0.015625,
70347034
0.0,
7035-
4.0,
7035+
3.0,
70367036
0.0
70377037
],
70387038
"pipelines": [
@@ -7047,29 +7047,29 @@
70477047
"load_store"
70487048
],
70497049
"shortest_path_cycles": [
7050-
0.03125,
7051-
0.03125,
7052-
0.03125,
7050+
0.015625,
7051+
0.015625,
7052+
0.015625,
70537053
0.0,
7054-
4.0,
7054+
3.0,
70557055
0.0
70567056
],
70577057
"total_bound_pipelines": [
70587058
"load_store"
70597059
],
70607060
"total_cycles": [
7061-
0.03125,
7062-
0.03125,
7063-
0.03125,
7061+
0.015625,
7062+
0.015625,
7063+
0.015625,
70647064
0.0,
7065-
4.0,
7065+
3.0,
70667066
0.0
70677067
]
70687068
},
70697069
"stack_spill_bytes": 0,
70707070
"thread_occupancy": 100,
70717071
"uniform_registers_used": 10,
7072-
"work_registers_used": 10
7072+
"work_registers_used": 8
70737073
}
70747074
}
70757075
},
@@ -7086,8 +7086,8 @@
70867086
"load_store"
70877087
],
70887088
"longest_path_cycles": [
7089-
3.299999952316284,
7090-
7.0,
7089+
2.9700000286102295,
7090+
5.0,
70917091
0.0
70927092
],
70937093
"pipelines": [
@@ -7099,22 +7099,22 @@
70997099
"load_store"
71007100
],
71017101
"shortest_path_cycles": [
7102-
3.299999952316284,
7103-
7.0,
7102+
2.9700000286102295,
7103+
5.0,
71047104
0.0
71057105
],
71067106
"total_bound_pipelines": [
71077107
"load_store"
71087108
],
71097109
"total_cycles": [
7110-
3.3333332538604736,
7111-
7.0,
7110+
3.0,
7111+
5.0,
71127112
0.0
71137113
]
71147114
},
71157115
"thread_occupancy": 100,
71167116
"uniform_registers_used": 6,
7117-
"work_registers_used": 3
7117+
"work_registers_used": 2
71187118
}
71197119
}
71207120
}

0 commit comments

Comments
 (0)