Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 3434aff

Browse files
author
jonahwilliams
committed
[Impeller] dont provide coverage hint for subpass coverage.
1 parent a7b207d commit 3434aff

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

impeller/entity/entity_pass.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,11 @@ std::optional<Rect> EntityPass::GetSubpassCoverage(
184184
coverage_limit.value());
185185
}
186186

187-
auto entities_coverage = subpass.GetElementsCoverage(coverage_limit);
187+
// Note: I'm not sure why, but feeding the coverage limit back into the
188+
// element coverage with a scale tranform image filter (one that is center
189+
// aligned and offsets as it scales), causes the entity coverage to wildly
190+
// vary, which destabilizes the image cache.
191+
auto entities_coverage = subpass.GetElementsCoverage(std::nullopt);
188192
// The entities don't cover anything. There is nothing to do.
189193
if (!entities_coverage.has_value()) {
190194
return std::nullopt;

0 commit comments

Comments
 (0)