Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 419fb8c0ab3e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0fad4601a1fb
Choose a head ref
  • 8 commits
  • 56 files changed
  • 5 contributors

Commits on Sep 6, 2024

  1. Change "there own" to "their own" in Flutter-GPU docs (#54921) 

    Changed the word "there" to "their" in Flutter GPU doc... which I think is correct, but I could be wrong. Thanks!

- [] I listed at least one issue that this PR fixes in the description above.
- [] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @davidhicks980
    davidhicks980 authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c40bc44 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (#55001) 

    https://skia.googlesource.com/skia.git/+log/6ad117bd2efe..8f62a6a4a299

2024-09-06 [email protected] [graphite] Move SkSL compilation into MtlGraphics|ComputePipeline::Make

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7f2718d View commit details
    Browse the repository at this point in the history

  3. [impeller] fake image for fake tests. (#54974) 

    Simulator only change to allow toImage and toByteData to not fail when there is no metal context w/ impeller.
    Jonah Williams authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0563637 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (#55008) 

    https://skia.googlesource.com/skia.git/+log/8f62a6a4a299..f38ea0134dba

2024-09-06 [email protected] [graphite] Centralize handling of viewport/rtAdjust values
2024-09-06 [email protected] [Vulkan] Fix deletion of fences on failed submits.
2024-09-06 [email protected] [Vulkan] Add AHARDWAREBUFFER_FORMAT_R10G10B10A10_UNORM checks to switch statements.
2024-09-06 [email protected] [graphite] Move lingering Viewer flag handling to SetTestOptions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e562f3f View commit details
    Browse the repository at this point in the history

  5. [Impeller] opt into exp canvas. (#54913) 

    Switch back to new canvas implementation, which allows us to complete the display list/impeller interop arc of work. While we're at it, switch the subpass size rounding logic to round out if there is no image filter.

Fixes flutter/flutter#152366

Part of flutter/flutter#142054
    Jonah Williams authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    397987a View commit details
    Browse the repository at this point in the history

  6. Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (#55013) 

    https://skia.googlesource.com/skia.git/+log/f38ea0134dba..4786936b4c0c

2024-09-06 [email protected] Revert "[graphite] Swap shape inversion for ClipOps."
2024-09-06 [email protected] Update to Bazel 7
2024-09-06 [email protected] [rust png] Implement `SkPngRustCodec::onGetRepetitionCount`.
2024-09-06 [email protected] [graphite] Add replayTranslation and dstCopyOffset to intrinsic uniforms

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f0bb98a View commit details
    Browse the repository at this point in the history

  7. [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiv… 

    …er methods (#54982)

Wean the DlOpReceiver interface and implementations off of using the SkScalar, Sk[I]Rect, and SkPoint objects in favor of our own DL/Impeller versions.

The start of an ongoing effort to eventually compartmentalize all use of Skia interfaces into a single backend rendering module that is one of 2 semi-pluggable renderers.
    @flar
    flar authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    51d93f8 View commit details
    Browse the repository at this point in the history

  8. [skwasm] use temporary RawPaint objects (#54917) 

    Same as #54818, but for Skwasm.

Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
    @yjbanov
    yjbanov authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0fad460 View commit details
    Browse the repository at this point in the history
Loading