Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4c62dd81d136
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 098ec489585e
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Aug 3, 2023

  1. Roll Skia from 3b3c1a617544 to 0a376550f218 (3 revisions) (#44353) 

    https://skia.googlesource.com/skia.git/+log/3b3c1a617544..0a376550f218

2023-08-03 [email protected] Revert "Roll vulkanmemoryallocator to latest"
2023-08-03 [email protected] Make SkMask immutable, introduce SkMaskBuilder
2023-08-03 [email protected] [skunicode] Allow building more than one backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7abb060 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Fail loudly if --enable-software-rendering is used. (#44346) 

    We have tests today that are trying to testwith impeller but using software rendering, so they're not actually testing with impeller.

In an unrelated patch, I'm causing the request to enable impeller to have additional checks that Impeller related objects/configurations are set when using Impeller, which isn't true if software rendering is enabled, and is causing the tests getting disabled here to fail.

The tests are not actually testing Impeller and thus are getting added to the skip list (they now crash with this change). flutter/flutter#131888 tracks re-enabling them. They will almost certainly need different golden files than the Skia ones.

Fixes flutter/flutter#131887
    @dnfield
    dnfield authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    098ec48 View commit details
    Browse the repository at this point in the history
Loading