Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4ee648914f91
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be0c3143c5f8
Choose a head ref
  • 10 commits
  • 5 files changed
  • 3 contributors

Commits on Aug 16, 2018

  1. Roll src/third_party/skia cbd83bb..cbb7d57 (5 commits) (#6033)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    16922dd View commit details
    Browse the repository at this point in the history
  2. Roll src/third_party/skia cbb7d57..8d77d1d (12 commits) (#6034)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    9ec11b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Roll src/third_party/skia 8d77d1d..e21f0ec (5 commits) (#6036)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    9e26174 View commit details
    Browse the repository at this point in the history
  2. Fix potential null pointer dereference in FlutterDartProject (#6035)

    If `FlutterDartProject` found an `FLTLibraryPath` entry in an iOS
    application's `Info.plist`, it assumed that values that were valid
    filesystem paths were paths to bundles.  If the attempt to retrieve
    the `NSBundle` fails, `FlutterDartProject` ignored the failure and
    then would assign `nil` to a C++ `std::string`, resulting in a null
    pointer dereference.
    
    Add some failure checks to prevent this.
    jamesderlin authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    4ff4a5c View commit details
    Browse the repository at this point in the history
  3. Roll src/third_party/skia e21f0ec..bc414ed (2 commits) (#6037)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    6381bea View commit details
    Browse the repository at this point in the history
  4. Roll src/third_party/skia bc414ed..da135c3 (1 commits) (#6038)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    6b94957 View commit details
    Browse the repository at this point in the history
  5. Roll src/third_party/skia da135c3..12d13ae (7 commits) (#6039)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    93efa7e View commit details
    Browse the repository at this point in the history
  6. Roll src/third_party/skia 12d13ae..c623af2 (8 commits) (#6040)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    a7e0e87 View commit details
    Browse the repository at this point in the history
  7. Roll src/third_party/skia c623af2..ff6a73c (5 commits) (#6042)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    5bd9620 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2018

  1. Add views added to the WindowManager into the presentation view tree. (

    …#6043)
    
    The default WindowManager implementation in Android's Presentation is
    delegating addView/removeView/updateViewLayout calls to the global
    WindowManager.
    This can result in a crash when an embedded view is trying to e.g show a
    PopupWindow.
    
    This change adds a custom WindowManager that overrides
    addView (and removeView/updateViewLayout) and adds the view to the
    presentation's view tree.
    
    Note that views might keep a reference to the window manager which
    might be an issue when we move a view from one virtual display to
    another (due to a resize). For this reason when re-sizing we are not
    creating a new window manager for the new presentation, but updating the
    window manager's references to be relevant for the new presentation and
    re-use it.
    amirh authored Aug 18, 2018
    Configuration menu
    Copy the full SHA
    be0c314 View commit details
    Browse the repository at this point in the history
Loading