Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4ff696b555dc
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7eb87547cbc6
Choose a head ref
  • 3 commits
  • 18 files changed
  • 2 contributors

Commits on Nov 19, 2024

  1. Roll Skia from 78ef6b7a574f to a694b9e85a49 (5 revisions) (#56713) 

    https://skia.googlesource.com/skia.git/+log/78ef6b7a574f..a694b9e85a49

2024-11-19 [email protected] [graphite] Fix up Context's recorder tracking thread safety
2024-11-19 [email protected] SkCrabbyAvifCodec: Set mediacodec color format
2024-11-19 [email protected] SkCrabbyAvifCodec: Make a copy of the image before scaling
2024-11-19 [email protected] Refactoring proxy for FontConfig out of FontMgr
2024-11-19 [email protected] [ganesh] Fix artifacts from looping colorizer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d2a67b6 View commit details
    Browse the repository at this point in the history

  2. display_list: Extract backend-specific surface providers (#56711) 

    Extracts backend-specific code in DlSurfaceProvider to separate translation units. In particular, this allows for less conditional header includes, and more specifically, allows code relating to the Metal backend to include headers that include ARC-managed Objective-C types. Today we cast these all to void* (and manage refcounting manually) since these headers are included in dl_surface_provider.cc, which is a pure C++ translation unit.

No test changes since this patch includes no semantic changes.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    13450c2 View commit details
    Browse the repository at this point in the history

  3. EmbedderTest: templatise GetEmbedderContext (#56709) 

    In many embedder tests, we want to get at the appropriate backend-specific `EmbedderTestContext` subclass (`EmbedderTestContextGL`, etc.) in order to make backend-specific setup calls such as `SetGLFBOCallback()` or others. Formerly, this required casting the returned `EmbedderTestContext&` to the appropriate subclass in each test.

This templatises the `GetEmbedderContext()` method to return the appropriate backend-specific subclass directly.

Issue: flutter/flutter#158998

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7eb8754 View commit details
    Browse the repository at this point in the history
Loading