Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6710d10ad703
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 599dbd7382ec
Choose a head ref
  • 3 commits
  • 23 files changed
  • 3 contributors

Commits on Mar 14, 2024

  1. Multi-view View Metrics (#46174) 

    This PR adds `FlutterWindowMetricsEvent.viewId` to the embedder API.

This PR only tests the ability to send metrics event for the implicit
view. Once multiple views can be added via embedder API, we should test
the ability to send different IDs.

Part of flutter/flutter#144806
Part of flutter/flutter#142845

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @dkwingsmt
    dkwingsmt authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    72ca2e1 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from a315e4572f4e to cac09f152d9b (10 revisions) (#51398) 

    https://skia.googlesource.com/skia.git/+log/a315e4572f4e..cac09f152d9b

2024-03-13 [email protected] Roll skcms from b440ca2fa89c to d52adb9ccd98 (1 revision)
2024-03-13 [email protected] Roll vulkan-deps from 91aab7b7e25f to e6550748fb1e (4 revisions)
2024-03-13 [email protected] Fix SkTypeface_Fuchsia creation
2024-03-13 [email protected] Revert "Use Chromium's abseil-cpp to unblock the Dawn roll"
2024-03-13 [email protected] Use Chromium's abseil-cpp to unblock the Dawn roll
2024-03-13 [email protected] Manual roll ANGLE from f16eea308ae1 to 66bc9cfa0014 (21 revisions)
2024-03-13 [email protected] [Fontations-backend] Part 2 of getAdvancedMetrics()
2024-03-13 [email protected] Creating named instances for each variation in a variable font
2024-03-13 [email protected] Ensure generated ICC profiles have non-empty descriptions
2024-03-13 [email protected] Remove SK_METAL defines from GrBackendSemaphore

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    01015e9 View commit details
    Browse the repository at this point in the history

  3. [Embedder API] Add multi-view present callback (#51267) 

    Adds `FlutterCompositor.present_view_callback` to the embedder API. This new present callback adds a `view_id` member to allow embedders know which view is being presented.

The embedder API does not allow embedders to create multiple views yet. This will be added in a future  pull request.

Design doc: https://flutter.dev/go/multi-view-embedder-apis

Pull request that migrates the Windows embedder to this new embedder API: #51293

Part of flutter/flutter#144806
Part of flutter/flutter#142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @loic-sharma
    loic-sharma authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    599dbd7 View commit details
    Browse the repository at this point in the history
Loading