Comparing changes

@itsjustkevin

Follow up from sync with @itsjustkevin : Add cherry pick github actions to flutter/engine repository. Would have the same functionalities as https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml. @godofredoc would be great if we could add [actions bot token](https://valentine.corp.google.com/#/show/1702960394753966?tab=metadata) as a secret under the name FLUTTERACTIONSBOT_CP_TOKEN to the engine repository too. Thank you!

The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport. In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event. ### Issues Fixes flutter/flutter#129182 ### Testing Looking good at: https://dit-astral-test.web.app [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions) https://skia.googlesource.com/skia.git/+log/cdf214adfb4d..c29a20702356 2024-02-06 [email protected] Bring back DISABLE_LOWP 2024-02-06 [email protected] Roll ANGLE from f8c06f103a1f to 5a0615588a1a (10 revisions) 2024-02-05 [email protected] Migrates graphite's main wait mechanism from using Tick to ProcessEvents. 2024-02-05 [email protected] Roll vulkan-deps from 3a55a3d5ee47 to 83223ec30684 (1 revision) 2024-02-05 [email protected] [skottie] Fix supernormal spatial interpolation 2024-02-05 [email protected] [graphite] Add new Graphite Precompilation DMSink 2024-02-05 [email protected] Roll Dawn from dd852a700405 to c9c20468546f (26 revisions) 2024-02-05 [email protected] Roll SK Tool from 9a1a69ed50c4 to 5c8f3c7d6467 2024-02-05 [email protected] Fix skottie rules for G3 2024-02-05 [email protected] Temporarily disable animated_gif.cpp from Bazel test 2024-02-05 [email protected] Add bazel modules for Skottie and sksg 2024-02-03 [email protected] Roll vulkan-deps from a1def468c6b4 to 3a55a3d5ee47 (9 revisions) 2024-02-03 [email protected] Roll SK Tool from 8af152c5f7ce to 9a1a69ed50c4 2024-02-02 [email protected] Fix copypasta in public.bzl 2024-02-02 [email protected] Guard some gms/tests that require Skottie code 2024-02-02 [email protected] Roll jsfiddle-base from 969399a89649 to b575daa903da 2024-02-02 [email protected] Roll shaders-base from 9054c5988daf to 89826f3f6f5d 2024-02-02 [email protected] Roll skottie-base from 9ce4d2efff0c to 906e4c4c9b17 2024-02-02 [email protected] Roll debugger-app-base from 54bf3755c837 to d2ed43ed5bb9 2024-02-02 [email protected] [unicode] Fix SkBreakIterator_libgrapheme 2024-02-02 [email protected] Roll vulkan-deps from 07589c29ccba to a1def468c6b4 (1 revision) 2024-02-02 [email protected] Make SVG backend explicitly depend on JPEG+PNG for OpenType 2024-02-02 [email protected] Add Bazel target for modular build of SkResources 2024-02-02 [email protected] Remove SkAnimCodecPlayer from the public API 2024-02-02 [email protected] Roll skottie-base from 5b5661dc98c7 to 9ce4d2efff0c 2024-02-02 [email protected] Roll shaders-base from e7695f0fdff5 to 9054c5988daf 2024-02-02 [email protected] Roll jsfiddle-base from f6c22747cda4 to 969399a89649 2024-02-02 [email protected] Roll debugger-app-base from 067d72e0dddf to 54bf3755c837 2024-02-02 [email protected] Fix fuzzer-discovered timeout by caching uniform information. 2024-02-02 [email protected] [pdf] Properly handle drawing not on a page 2024-02-02 [email protected] Add method Type::isAllowedInUniform. 2024-02-02 [email protected] Remove SK_DISABLE_LOWP_RASTER_PIPELINE 2024-02-02 [email protected] [Fontations-backend] Minor: Remove return statement 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump follow-redirects from 1.14.8 to 1.15.5 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump socket.io-parser from 4.2.2 to 4.2.4 in /modules/canvaskit 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump jinja2 from 2.11.3 to 3.1.3 2024-02-02 [email protected] Update Bazel rules after vulkan_header update 2024-02-02 [email protected] Roll ANGLE from 1abfdc37320f to f8c06f103a1f (3 revisions) 2024-02-02 [email protected] Roll vulkan-deps from 82b9fb3ddb57 to 07589c29ccba (6 revisions) 2024-02-02 [email protected] Roll SK Tool from e83737e1d145 to b8aac8b590af 2024-02-02 [email protected] Roll Skia Infra from 6e97526ab534 to e83737e1d145 (14 revisions) 2024-02-02 [email protected] Roll SwiftShader from 78d1799ee43e to eb75201a4e03 (2 revisions) 2024-02-02 [email protected] Roll Dawn from 2c3a08ff64ba to dd852a700405 (8 revisions) 2024-02-02 [email protected] Revert "[pdf] Properly handle drawing not on a page" 2024-02-02 [email protected] Add BUILD.gn cleanups to zlib. 2024-02-01 [email protected] Make SkScalarContext for Windows DirectWrite explicitly decode PNGs ...

…pty (#50381) The render pass may need to apply other changes such as painting the clear color. See flutter/flutter#142639

…e sources. (#50142) Cache vk::RenderPass and vk::Framebuffer objects on the resolve texture of any render target attachments. Use these on the next frame unconditionally. Fixes flutter/flutter#141750

https://skia.googlesource.com/skia.git/+log/c29a20702356..9e68ed6caf6d 2024-02-06 [email protected] Roll ANGLE from 5a0615588a1a to e62bd70a6c74 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/9e68ed6caf6d..44106ee8edea 2024-02-06 [email protected] Roll vulkan-deps from 83223ec30684 to 32051b1fe7ae (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update Fuchsia's API level to 16. b/322503140 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing.

) I expect `Linux linux_android_emulator_tests` and `Linux linux_android_emulator_tests_api_33` to fail. When they fail, I'll fix the assertion (flutter/flutter#142746) before merging this PR.

https://dart.googlesource.com/sdk.git/+log/b62066b42af0..29265c94a6e8 2024-02-06 [email protected] Version 3.4.0-114.0.dev 2024-02-06 [email protected] Version 3.4.0-113.0.dev 2024-02-06 [email protected] Version 3.4.0-112.0.dev 2024-02-05 [email protected] Version 3.4.0-111.0.dev 2024-02-05 [email protected] Version 3.4.0-110.0.dev 2024-02-05 [email protected] Version 3.4.0-109.0.dev 2024-02-05 [email protected] Version 3.4.0-108.0.dev 2024-02-03 [email protected] Version 3.4.0-107.0.dev 2024-02-03 [email protected] Version 3.4.0-106.0.dev 2024-02-02 [email protected] Version 3.4.0-105.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

I was making sure that I could get at least one test running and passing on CI (as expected), now turn all of them on.

#50376) Minor QOL improvement. Tried taking a frame capture unsuccessfully before realizing that I was using SwiftShader.

…ites.yaml on debug and release builds"" (#50295) Reverts #50291, flutter/flutter#142811 Following is the original change description. This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner. - Tests with packages out of out/fuchsia_*_x64/ are ignored for now. - Tests with extra test command line parameters are ignored for now. The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel. This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well. - Tests not built with AOT are filtered out with variant field in test_suites.yaml. Bug: flutter/flutter#140179 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…50404) Reverts #50161 Initiated by: jonahwilliams Reason for reverting: This is causing what looks like bogus goldens on the framework -> engine roll: flutter/flutter#142966 Original PR Author: ditman Reviewed By: {yjbanov, mdebbar} This change reverts the following previous change: Original Description: The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport. In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event. ### Issues Fixes flutter/flutter#129182 ### Testing Looking good at: https://dit-astral-test.web.app [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Filed flutter/flutter#142991 to re-enable.

…a/test_suites.yaml on debug and release builds""" (#50407) Reverts "Reland "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds""" Reverts #50295 Initiated by: zanderso Reason for reverting: Timing out on CI Original PR Author: zijiehe-google-com Reviewed By: {keyonghan} This change reverts the following previous change: Original Description: Reverts #50291, flutter/flutter#142811 Following is the original change description. This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner. - Tests with packages out of out/fuchsia_*_x64/ are ignored for now. - Tests with extra test command line parameters are ignored for now. The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel. This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well. - Tests not built with AOT are filtered out with variant field in test_suites.yaml. Bug: flutter/flutter#140179 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

This is to enable rbe support. Part of flutter/flutter#142986

https://dart.googlesource.com/sdk.git/+log/29265c94a6e8..35269fa71956 2024-02-06 [email protected] Version 3.4.0-115.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Feb 6, 2024

This comparison is taking too long to generate.

Uh oh!