Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 98b036ae708e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5b2cc9d9b8fe
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Sep 5, 2023

  1. Roll Skia from 7e80aedd05b6 to 2b9fc6a2c250 (1 revision) (#45465) 

    https://skia.googlesource.com/skia.git/+log/7e80aedd05b6..2b9fc6a2c250

2023-09-05 [email protected] [bazel] Extract goldctl steps from bazel_test_gm.go into a common package.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4da0350 View commit details
    Browse the repository at this point in the history

  2. Fix iOS unittests leak in shared.invoke method channel that causes cr… 

    …ash (#45416)

Fixes flutter/flutter#133776

"The crash is due to testShareScreenInvoked presents the activityViewController, which prevents the engineViewController to be dealloc'd in the test: https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L161C4-L161C24"

This fix stubbing the presentViewController call, which prevents the viewController being alloc'd, thus preventing the leak. It is probably sufficient for this test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5b2cc9d View commit details
    Browse the repository at this point in the history
Loading