Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b27e1b38375b
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4a65910f0ab2
Choose a head ref
  • 5 commits
  • 5 files changed
  • 5 contributors

Commits on Oct 20, 2023

  1. [web] Remove workaround for safely removing slots on Safari (#47169) 

    Now that we want to support multi-view, we need to either:
1. Remove the workaround to safely remove slot elements in Safari, or
2. Fix it to support multi-view (can't use `flutterViewEmbedder.glassPaneShadow` anymore).

According to [this comment](flutter/flutter#85816 (comment)), this is the right time to remove the workaround � I tested on Desktop Safari and iOS Safari and wasn't able to reproduce the crash reported in flutter/flutter#84832.

Fixes flutter/flutter#85816
Part of flutter/flutter#134443
    @mdebbar
    mdebbar authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ebd542b View commit details
    Browse the repository at this point in the history

  2. Lower the severity of a log message (#47172) 

    This log message can print on the first frame of a platform view and is
not an error.
    @johnmccutchan
    johnmccutchan authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    bda4c45 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 9ffd5ef9a9ed to ca69b04f7dd2 (1 revision) (#47171) 

    https://skia.googlesource.com/skia.git/+log/9ffd5ef9a9ed..ca69b04f7dd2

2023-10-20 [email protected] Fix fuzzer-discovered assertion with WGSL interface-block arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8c7e168 View commit details
    Browse the repository at this point in the history

  4. Multiview pipeline (#44473) 

    This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by #45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @dkwingsmt
    dkwingsmt authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d9f2453 View commit details
    Browse the repository at this point in the history

  5. Reverts "Multiview pipeline" (#47174) 

    Reverts #44473
Initiated by: dkwingsmt
This change reverts the following previous change:
Original Description:
This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by #45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @auto-submit
    auto-submit[bot] authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4a65910 View commit details
    Browse the repository at this point in the history
Loading