Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bedc49efc85c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 71e1a0430232
Choose a head ref
  • 16 commits
  • 36 files changed
  • 4 contributors

Commits on Oct 26, 2023

  1. Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... ( 

    #47363)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d74261e View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (#47359) 

    https://skia.googlesource.com/skia.git/+log/93a0ad4d7ca6..bc8ca57868d2

2023-10-26 [email protected] Change espn page set and recapture archives
2023-10-26 [email protected] [Fontations] Add a suffix to font names to identify when backend is used

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c60f43b View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (#… 

    …47357)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 [email protected] Version 3.3.0-65.0.dev
2023-10-26 [email protected] Version 3.3.0-64.0.dev
2023-10-26 [email protected] Version 3.3.0-63.0.dev
2023-10-26 [email protected] Version 3.3.0-62.0.dev
2023-10-26 [email protected] Version 3.3.0-61.0.dev
2023-10-25 [email protected] Version 3.3.0-60.0.dev
2023-10-25 [email protected] Version 3.3.0-59.0.dev
2023-10-25 [email protected] Version 3.3.0-58.0.dev
2023-10-24 [email protected] Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    bc15dff View commit details
    Browse the repository at this point in the history

  2. Don't re-initialize the default RenderSurface when returning from hyb… 

    …rid composition mode (#47358)

When we enter hybrid composition mode we 'pause' the default RenderSurface (implemented by SurfaceView or TextureView) and swap to an ImageReader based RenderSurface.

When we return from hybrid composition mode we recreate and re-initialize the real RenderSurface as if it was being used for the first time.

This broke Platform Views in an internal app b/306122497 because we would incorrectly tell the texture to attach when it was never detached.

This CL changes the protocol so that when we return from hybrid composition mode we only swap the RenderSurface and do not re-create it. This avoids doing a bunch of unnecessary work and fixes the logic error of re-attaching textures that were never detached.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @johnmccutchan
    johnmccutchan authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7119498 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (#47365) 

    https://skia.googlesource.com/skia.git/+log/bc8ca57868d2..ec4c6b3a6690

2023-10-26 [email protected] Roll vulkan-deps from 6f757b21c505 to a2bfb92d5166 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    dbcf074 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Add FilterContents::GetSourceCoverage to enable filtered s… 

    …aveLayer clipping. (#47183)

The new method allows a caller to ask for the coverage of the input pixels required to produce an output that spans a given area. This allows the code to clip a saveLayer that has an image filter applied to it.
    @flar
    flar authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    786202e View commit details
    Browse the repository at this point in the history

  5. Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (#47366) 

    https://skia.googlesource.com/skia.git/+log/ec4c6b3a6690..2246f3473053

2023-10-27 [email protected] Roll skcms from 1227163dbdb7 to 4d94ff507876 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8a5fb39 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (#47369) 

    https://skia.googlesource.com/skia.git/+log/2246f3473053..fbdd7d97b26e

2023-10-27 [email protected] Update SKP version
2023-10-27 [email protected] Roll skcms from 4d94ff507876 to f1e5fc856f1b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d6bbca9 View commit details
    Browse the repository at this point in the history

  7. Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (#47370) 

    https://skia.googlesource.com/skia.git/+log/fbdd7d97b26e..fe61b3467547

2023-10-27 [email protected] Roll Skia Infra from 50a46e8932cc to ac82f8a7da91 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b274bc3 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (#47371) 

    https://skia.googlesource.com/skia.git/+log/fe61b3467547..5262cbff56b1

2023-10-27 [email protected] Roll Dawn from c92f9bf9379e to fd22bd69eb33 (15 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    cdd4bb4 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (#47372) 

    https://skia.googlesource.com/skia.git/+log/5262cbff56b1..22f5419438c4

2023-10-27 [email protected] Roll SK Tool from ac82f8a7da91 to 3208d90e145c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4913feb View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (#47373) 

    https://skia.googlesource.com/skia.git/+log/22f5419438c4..0122c0e18d26

2023-10-27 [email protected] Roll ANGLE from 5dd0c842d6c8 to eca38a109465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    48137f0 View commit details
    Browse the repository at this point in the history

  11. Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce… 

    …... (#47375)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d90fbf1 View commit details
    Browse the repository at this point in the history

  12. Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... ( 

    #47377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    233295f View commit details
    Browse the repository at this point in the history

  13. Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (#47379) 

    https://skia.googlesource.com/skia.git/+log/0122c0e18d26..fe9959acc5e0

2023-10-27 [email protected] [graphite] Add per-edge AA quad shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d799dc7 View commit details
    Browse the repository at this point in the history

  14. Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 re… 

    …visions)" (#47380)

Reverts #47357
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 [email protected] Version 3.3.0-65.0.dev
2023-10-26 [email protected] Version 3.3.0-64.0.dev
2023-10-26 [email protected] Version 3.3.0-63.0.dev
2023-10-26 [email protected] Version 3.3.0-62.0.dev
2023-10-26 [email protected] Version 3.3.0-61.0.dev
2023-10-25 [email protected] Version 3.3.0-60.0.dev
2023-10-25 [email protected] Version 3.3.0-59.0.dev
2023-10-25 [email protected] Version 3.3.0-58.0.dev
2023-10-24 [email protected] Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @auto-submit
    auto-submit[bot] authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    71e1a04 View commit details
    Browse the repository at this point in the history
Loading