Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c2fd5333a5d2
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba1115c30381
Choose a head ref
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Mar 15, 2024

  1. [Impeller] A toolkit for managed handles to Android NDK vended object… 

    …s. (#51334)

Only available on Android device API levels >= 29. Proc table is setup has versioning checks. All handles are type safe. Collection of handles takes into account cleanup tasks (like reparenting surface controls). The proc table contains code duplicated in ndk_helpers and I will remove that in favor of this in a subsequent patch.

Part of #51213 being chopped up.
    @chinmaygarde
    chinmaygarde authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f086ec4 View commit details
    Browse the repository at this point in the history

  2. Reverts "[Impeller] A toolkit for managed handles to Android NDK vend… 

    …ed objects. (#51334)" (#51457)

Reverts: #51334
Initiated by: matanlurey
Reason for reverting: Broke engine post-submit, see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8753367119442265873/+/u/test:_Android_Unit_Tests__API_28_/stdout.
Original PR Author: chinmaygarde

Reviewed By: {dnfield}

This change reverts the following previous change:
Only available on Android device API levels >= 29. Proc table is setup has versioning checks. All handles are type safe. Collection of handles takes into account cleanup tasks (like reparenting surface controls). The proc table contains code duplicated in ndk_helpers and I will remove that in favor of this in a subsequent patch.

Part of #51213 being chopped up.
    @auto-submit
    auto-submit[bot] authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    80a93a0 View commit details
    Browse the repository at this point in the history

  3. Add more explicit logging (just to stderr) if a try-job detects an … 

    …untriaged image (#51454)

Work towards flutter/flutter#145219.

Previously all logging would be silent in the case that `test_foo` uploads a digest that is considered "untriaged", and we'd be entirely reliant on the `flutter-gold` check to pick this up asynchronously. 

As part of debugging flutter/flutter#145219 (but probably to keep this code indefinitely, it's not harmful), we now unconditionally log the swallowed failures to `stderr` so they will show up in our LUCI logs.

/cc @gaaclarke @jonahwilliams
    @matanlurey
    matanlurey authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ba1115c View commit details
    Browse the repository at this point in the history
Loading