Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cb6115d3a6ab
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c5d2e011652b
Choose a head ref
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Feb 22, 2024

  1. Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (#50878) 

    https://skia.googlesource.com/skia.git/+log/dd8cd405d145..a285cd79614c

2024-02-22 [email protected] [graphite] Add support for text atlas garbage collection.
2024-02-22 [email protected] Add TextShaper back to modules/skottie/src/text:srcs (Take 2)
2024-02-22 [email protected] Change a local_defines to defines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5088c37 View commit details
    Browse the repository at this point in the history

  2. Build macOS engine as an xcframework (#50300) 

    Creates and adds FlutterMacOS.xcframework to out/mac or out/host.

Creates and archives FlutterMacOS.xcframework when building mac_host_engine. Archives the xcframework in a new zipped folder at `darwin-x64/framework.zip`, `darwin-x64-profile/framework.zip`, `darwin-x64-release/framework.zip`.

The FlutterMacOS.framework is also still archived currently - I thought it'd be better to keep it archived so we don't have to worry about the tool breaking until we're ready to remove it.

Part of flutter/flutter#126016.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    73a6e07 View commit details
    Browse the repository at this point in the history

  3. [Impeller] moved the kernel size assert to a more appropriate locatio… 

    …n. (#50880)

This is the more appropriate location for the assert now.  This is important if we want to fiddle with the downsample amount now the the kernel is effectively half as big.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c5d2e01 View commit details
    Browse the repository at this point in the history
Loading