Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d514a302cdff
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 17a4b66e0729
Choose a head ref
  • 8 commits
  • 53 files changed
  • 6 contributors

Commits on Mar 5, 2024

  1. [Impeller] Enable depth buffer clipping & Stencil-then-Cover path ren… 

    …dering. (#50856)

Turn the page, wash your hands.

Addresses the following issues:
* flutter/flutter#143077
* flutter/flutter#137714
* flutter/flutter#138460
* flutter/flutter#123671
* flutter/flutter#141961
* flutter/flutter#134432
    @bdero
    bdero authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3e9928e View commit details
    Browse the repository at this point in the history

  2. [fuchsia] Remove now unnecessary diagnostics directory (#51180) 

    Inspect is now published using InspectSink and we can get rid of this
directory.

I'm unsure what "debug" and "ctrl" are for so I left them untouched.

Bug: https://g-issues.fuchsia.dev/issues/320785253

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @miguelfrde
    miguelfrde authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e6974df View commit details
    Browse the repository at this point in the history

  3. Shift git version fetching to tools/gn (#51175) 

    Avoids GN invoking python scripts that run git commands to determine git
hashes.

Part of flutter/flutter#144430
    @zanderso
    zanderso authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7e30318 View commit details
    Browse the repository at this point in the history

  4. Reland "Remove migration flag and unused header files #50216" (#50259) 

    Forgot to update a pinned dependency in the previous attempt: flutter/tests#340

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @LongCatIsLooong
    LongCatIsLooong authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e10c0ae View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 9c62e7b382cf to a577399ed6fb (1 revision) (#51190) 

    https://skia.googlesource.com/skia.git/+log/9c62e7b382cf..a577399ed6fb

2024-03-05 [email protected] Revert "Use nmad in pow/log computation."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6250b9f View commit details
    Browse the repository at this point in the history

  6. Reverts "Reland: [macOS] Use CVDisplayLink to drive repaint (#51126)" (… 

    …#51192)

Reverts #51126
Initiated by: cbracken
Reason for reverting: looks like this regressed Skia benchmarks: https://flutter-flutter-perf.skia.org/e/?keys=Xbf8dce9c233bce34d20e2280e3f1d8db&selected=commit%3D39653%26name%3D%2Carch%3Dintel%2Cbranch%3Dmaster%2Cconfig%3Ddefault%2Cdevice_type%3Dnone%2Cdevice_version%3Dnone%2Chost_type%3Dmac%2Csub_result%3DtimeToFirstFrameRasterizedMicros%2Ctest%3Dflutter_gallery_macos__start_up%2C&xbaroffset=39569

The regression s
Original PR Author: knopp

Reviewed By: {cbracken}

This change reverts the following previous change:
Original Description:
This relands the PR reverted in #51095

Changes since the original PR:
- The macOS embedder does not assume particular clock when calling the embedder API, but converts CAMediaTime to engine time and back (`FlutterTimeConverter`)
- `FlutterVSyncWaiter` does not wait for displaylink callback during warmup frame. This should prevent `timeToFirstFrameRasterizedMicros` regressions.
- When enforcing frame pacing the raster thread is not blocked. This should prevent `average_frame_rasterizer_time_millis` regressions.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @auto-submit
    auto-submit[bot] authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    78cecee View commit details
    Browse the repository at this point in the history

  7. [Impeller] Turn off StC. (#51191) 

    Turn it off to unblock the engine roll while investigating golden diffs: https://flutter-gold.skia.org/search?issue=144585&crs=github&patchsets=1&corpus=flutter
    @bdero
    bdero authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6efd574 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from a577399ed6fb to 5839a94bf28b (1 revision) (#51194) 

    https://skia.googlesource.com/skia.git/+log/a577399ed6fb..5839a94bf28b

2024-03-05 [email protected] Roll Dawn from d9da44a9929a to f7e1ef5d45e2 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    17a4b66 View commit details
    Browse the repository at this point in the history
Loading