-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: d6d5fdba6ae1
head repository: flutter/engine
compare: d4850c1ae648
- 18 commits
- 48 files changed
- 8 contributors
Commits on Sep 25, 2024
-
Add
SurfaceProducer#onSurfaceAvailable, deprecate `onSurfaceCreated……`. (#55418) Closes flutter/flutter#155131. Not only did I rename the method, but I also changed the contract slightly - now `onSurfaceAvailable` is _only_ invoked _after_ `onSurfaceDestroyed` has been called. The cost is a single `boolean`, and it honestly makes the API make a lot more sense than someone having to track this themselves. /cc @johnmccutchan (OOO), and @flutter/android-reviewers.
Configuration menu - View commit details
-
Copy full SHA for 1c29585 - Browse repository at this point
Copy the full SHA 1c29585View commit details -
Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (#55433)
https://skia.googlesource.com/skia.git/+log/79e652aad7a9..9af762100cf1 2024-09-25 [email protected] [graphite] Modify key methods and comment docs to be able to accept a SamplerDesc container ptr 2024-09-25 [email protected] [bazel] Use filegroup for common_flags_config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b95b979 - Browse repository at this point
Copy the full SHA b95b979View commit details -
adds more tasks to the engine workspace (#55435)
- host_debug_unopt_arm64 - android_debug_unopt_arm64 - ios_debug_unopt_arm64 (missed in previous change) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for fe94fc9 - Browse repository at this point
Copy the full SHA fe94fc9View commit details -
Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (#55437)
https://dart.googlesource.com/sdk.git/+log/dd73afd20be5..c2728b947e46 2024-09-25 [email protected] Version 3.6.0-279.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 16bdf23 - Browse repository at this point
Copy the full SHA 16bdf23View commit details -
[Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (#5…
…5416) Resolves flutter/flutter#155627. Allow setting the clear directly as floats without conversion work. vector_math already has convenient `Colors.[color]` factories and such. Also, `ui.Color` has a color space now, which does not apply here. Adds a simple golden to verify that clear colors work: 
Configuration menu - View commit details
-
Copy full SHA for c64dffe - Browse repository at this point
Copy the full SHA c64dffeView commit details -
[scenario_app] delete get bitmap activity. (#55436)
Since we can't see the screenshot we can't really evaluate if this is failing for good/bad reasons. This also uses the whoe convertToImageREader / readback debugging API that I want to delete.
Jonah Williams authoredSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 4cc7119 - Browse repository at this point
Copy the full SHA 4cc7119View commit details -
Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (#55439)
https://skia.googlesource.com/skia.git/+log/9af762100cf1..e623a37de332 2024-09-25 [email protected] Manual roll vulkan-deps from 683d4c5faa30 to 13d1d0b93ffd (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 810bfd6 - Browse repository at this point
Copy the full SHA 810bfd6View commit details -
Add a boolean that exposes rotation/crop metadata capability. (#55434)
Closes flutter/flutter#144407. Closes flutter/flutter#155633.
Configuration menu - View commit details
-
Copy full SHA for 4709c42 - Browse repository at this point
Copy the full SHA 4709c42View commit details -
Fixes blend + color filter (#55411)
fixes flutter/flutter#155456 Thanks @jason-simmons for identifying the fix. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Configuration menu - View commit details
-
Copy full SHA for d143ca8 - Browse repository at this point
Copy the full SHA d143ca8View commit details -
Remove usages of WindowManager's getDefaultDisplay (#55002)
Removed deprecated usages of WindowManager's `getDefaultDisplay()` and replaced them with DisplayManager's `getDisplay()`. Note: Decided to keep a usage of `getDefaultDisplay()`, which can be found in FlutterView.java because it is expected to be deleted as a part of V1 embedding removal. No changes were made to that file. path to FlutterView.java: shell/platform/android/io/flutter/embedding/android/FlutterView.java Fixes [#99421](flutter/flutter#99421) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Configuration menu - View commit details
-
Copy full SHA for c0b7827 - Browse repository at this point
Copy the full SHA c0b7827View commit details -
Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (#55443)
https://skia.googlesource.com/skia.git/+log/e623a37de332..9f3b32b7b772 2024-09-25 [email protected] Remove some debugf from SkFontMgr_AndroidNDK 2024-09-25 [email protected] Manual roll Dawn from 876bb88cb063 to efd781b42ae5 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c558459 - Browse repository at this point
Copy the full SHA c558459View commit details -
[Impeller] actually fix external texture for GLES. (#55414)
Goldens are working! and incorrect! use the other texture contents to hopefully fix them. Ratther the the transform, we actually expect to use the src and dst rect to position/transform the texture. Tiled Texture contents does not support a src rect, so switch it to the regular texture contents.
Jonah Williams authoredSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 6530580 - Browse repository at this point
Copy the full SHA 6530580View commit details -
Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (#55444)
https://dart.googlesource.com/sdk.git/+log/c2728b947e46..016368ee313d 2024-09-25 [email protected] Version 3.6.0-280.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8b452c4 - Browse repository at this point
Copy the full SHA 8b452c4View commit details -
[engine] set platform thread name to ui. (#55362)
When running with merged platform and ui threads, set the dart thread name of the main thread to io.futter.ui. Also change the thread mask settings to avoid creating an unused UI thread.
Jonah Williams authoredSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 62c0e50 - Browse repository at this point
Copy the full SHA 62c0e50View commit details -
Move lint suppression from
baseline.xmlto@SuppressLint. (#55447)I think you just had the lint identifier wrong? Closes flutter/flutter#155712.
Configuration menu - View commit details
-
Copy full SHA for f7668af - Browse repository at this point
Copy the full SHA f7668afView commit details -
Reland "[canvaskit] Further improve overlay optimization by splitting…
… pictures" (#55402) This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis. Fixes flutter/flutter#149863 On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps). This is a reland of #54878 with a fix for scenes with pictures that are eventually entirely clipped out. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 7461499 - Browse repository at this point
Copy the full SHA 7461499View commit details
Commits on Sep 26, 2024
-
Reverts "Add
SurfaceProducer#onSurfaceAvailable, deprecate `onSurfa……ceCreated`. (#55418)" (#55450) Reverts: #55418 Initiated by: bdero Reason for reverting: [Engine->Framework roll breakage](flutter/flutter#155727 (comment)) Original PR Author: matanlurey Reviewed By: {jonahwilliams} This change reverts the following previous change: Closes flutter/flutter#155131. Not only did I rename the method, but I also changed the contract slightly - now `onSurfaceAvailable` is _only_ invoked _after_ `onSurfaceDestroyed` has been called. The cost is a single `boolean`, and it honestly makes the API make a lot more sense than someone having to track this themselves. /cc @johnmccutchan (OOO), and @flutter/android-reviewers.
Configuration menu - View commit details
-
Copy full SHA for 7af5b38 - Browse repository at this point
Copy the full SHA 7af5b38View commit details -
Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (…
…#55444)" (#55454) Reverts: #55444 Initiated by: bdero Reason for reverting: [Roll breakage](flutter/flutter#155727 (comment)) Original PR Author: skia-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: https://dart.googlesource.com/sdk.git/+log/c2728b947e46..016368ee313d 2024-09-25 [email protected] Version 3.6.0-280.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for d4850c1 - Browse repository at this point
Copy the full SHA d4850c1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d6d5fdba6ae1...d4850c1ae648