From 909833c7aa826ad455271d52a6ae3a8728e4c1d8 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Fri, 17 Jun 2022 21:37:36 -0700 Subject: [PATCH] Eliminate use-after-move pipeline_desc is a std::optional. It's used in test expectations after (lines 320-321) the move. This passes by value like in other tests. --- impeller/renderer/renderer_unittests.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/impeller/renderer/renderer_unittests.cc b/impeller/renderer/renderer_unittests.cc index 8f350d10bd1f0..539637d047f91 100644 --- a/impeller/renderer/renderer_unittests.cc +++ b/impeller/renderer/renderer_unittests.cc @@ -285,9 +285,8 @@ TEST_P(RendererTest, CanRenderToTexture) { auto pipeline_desc = BoxPipelineBuilder::MakeDefaultPipelineDescriptor(*context); ASSERT_TRUE(pipeline_desc.has_value()); - auto box_pipeline = context->GetPipelineLibrary() - ->GetRenderPipeline(std::move(pipeline_desc)) - .get(); + auto box_pipeline = + context->GetPipelineLibrary()->GetRenderPipeline(pipeline_desc).get(); ASSERT_TRUE(box_pipeline); VertexBufferBuilder vertex_builder;