From 82c36fb036c39cbfff46e932050fd92a1046603f Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 25 Oct 2023 11:02:46 -0700 Subject: [PATCH 1/3] Missed linter argument comment violations --- .ci.yaml | 1 - .../android/external_view_embedder/external_view_embedder.cc | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.ci.yaml b/.ci.yaml index 1f7129b80bd3a..784245b8e02b2 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -241,7 +241,6 @@ targets: - name: Linux linux_clang_tidy recipe: engine_v2/engine_v2 - presubmit: false timeout: 120 properties: config_name: linux_clang_tidy diff --git a/shell/platform/android/external_view_embedder/external_view_embedder.cc b/shell/platform/android/external_view_embedder/external_view_embedder.cc index d29a80eb16a8c..a0e516e4c10a2 100644 --- a/shell/platform/android/external_view_embedder/external_view_embedder.cc +++ b/shell/platform/android/external_view_embedder/external_view_embedder.cc @@ -79,7 +79,7 @@ void AndroidExternalViewEmbedder::SubmitFrame( // Restore the clip context after exiting this method since it's changed // below. - DlAutoCanvasRestore save(background_canvas, /*doSave=*/true); + DlAutoCanvasRestore save(background_canvas, /*do_save=*/true); for (size_t i = 0; i < current_frame_view_count; i++) { int64_t view_id = composition_order_[i]; From b087a22b076f3f5f86e70b7c710ba13cec8536e5 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 25 Oct 2023 11:09:55 -0700 Subject: [PATCH 2/3] removed ci.yaml change --- .ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci.yaml b/.ci.yaml index 784245b8e02b2..1f7129b80bd3a 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -241,6 +241,7 @@ targets: - name: Linux linux_clang_tidy recipe: engine_v2/engine_v2 + presubmit: false timeout: 120 properties: config_name: linux_clang_tidy From fc4685bde2d4f74a94c6aa87c2ff3bfd9d4d9205 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 25 Oct 2023 11:14:20 -0700 Subject: [PATCH 3/3] added mac violations too --- impeller/display_list/dl_unittests.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/impeller/display_list/dl_unittests.cc b/impeller/display_list/dl_unittests.cc index c59ca6b01056d..9e0456d50db5d 100644 --- a/impeller/display_list/dl_unittests.cc +++ b/impeller/display_list/dl_unittests.cc @@ -1390,7 +1390,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithoutIndices) { auto vertices = flutter::DlVertices::Make( flutter::DlVertexMode::kTriangles, 3, positions.data(), - /*texture_coorindates=*/nullptr, colors.data()); + /*texture_coordinates=*/nullptr, colors.data()); flutter::DisplayListBuilder builder; flutter::DlPaint paint; @@ -1409,7 +1409,7 @@ TEST_P(DisplayListTest, DrawVerticesLinearGradientWithoutIndices) { auto vertices = flutter::DlVertices::Make( flutter::DlVertexMode::kTriangles, 3, positions.data(), - /*texture_coorindates=*/nullptr, /*colors=*/nullptr); + /*texture_coordinates=*/nullptr, /*colors=*/nullptr); std::vector colors = {flutter::DlColor::kBlue(), flutter::DlColor::kRed()}; @@ -1519,7 +1519,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithIndices) { auto vertices = flutter::DlVertices::Make( flutter::DlVertexMode::kTriangles, 6, positions.data(), - /*texture_coorindates=*/nullptr, /*colors=*/nullptr, 6, indices.data()); + /*texture_coordinates=*/nullptr, /*colors=*/nullptr, 6, indices.data()); flutter::DisplayListBuilder builder; flutter::DlPaint paint; @@ -1540,7 +1540,7 @@ TEST_P(DisplayListTest, DrawVerticesPremultipliesColors) { auto vertices = flutter::DlVertices::Make( flutter::DlVertexMode::kTriangles, 6, positions.data(), - /*texture_coorindates=*/nullptr, colors.data(), 6, indices.data()); + /*texture_coordinates=*/nullptr, colors.data(), 6, indices.data()); flutter::DisplayListBuilder builder; flutter::DlPaint paint; @@ -1668,7 +1668,7 @@ TEST_P(DisplayListTest, DrawVerticesBlendModes) { auto vertices = flutter::DlVertices::Make( flutter::DlVertexMode::kTriangles, 3, positions.data(), - /*texture_coorindates=*/nullptr, colors.data()); + /*texture_coordinates=*/nullptr, colors.data()); flutter::DisplayListBuilder builder; flutter::DlPaint paint;