Commit 5466588
authored
[Impeller] Generate a Metal library symbols file for shader debugging. (#39532)
Towards fixing #120326. This allows you
to specify the sources for the Impeller Metal Library. The user is meant to
navigate to `out/<engine_variant>/shaders/entity.metallib` when Xcode prompts
for sources.
Shader debugging with line by line profiling is still not a turnkey operation
though. This works fine on macOS. But on iOS, I had to bump up the min iOS
version level to iOS 12 at least and specify `-g` to the `metal` compiler for
the sources to show up with profiling. The performance of the shaders was
identical after the changes though so I suspect engine developers will patch in
these flags locally to develop and debug shaders.1 parent b3e9642 commit 5466588
File tree
3 files changed
+12
-2
lines changed- impeller
- renderer/backend/metal
- tools
3 files changed
+12
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
152 | 155 | | |
153 | 156 | | |
154 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
| |||
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
100 | | - | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
133 | 135 | | |
134 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
135 | 140 | | |
136 | 141 | | |
137 | 142 | | |
| |||
0 commit comments