Skip to content

Commit 32133ce

Browse files
Reverts "Try running historically flaky tests first to make flutter build apk health tests time out more often? (#158967)" (#158993)
Reverts: flutter/flutter#158967 Initiated by: matanlurey Reason for reverting: `--run-skipped` doesn't work in this repository (flutter/flutter#158972). Original PR Author: matanlurey Reviewed By: {andrewkolos} This change reverts the following previous change: I have no idea if this will work, but `6_6` is currently the suite that seems to have the most problems. Towards flutter/flutter#158560.
1 parent 09941e7 commit 32133ce

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

dev/bots/test.dart

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -236,30 +236,15 @@ Future<void> _runIntegrationToolTests() async {
236236
}
237237

238238
Future<void> _runFlutterBuildApkHealthTests() async {
239-
// Try "priming" the test environment by running historically problematic tests first.
240-
final List<String> toolIntegrationTests = Directory(path.join(_toolsPath, 'test', 'integration.shard'))
239+
final List<String> allTests = Directory(path.join(_toolsPath, 'test', 'flutter_build_apk.shard'))
241240
.listSync(recursive: true).whereType<File>()
242241
.map<String>((FileSystemEntity entry) => path.relative(entry.path, from: _toolsPath))
243242
.where((String testPath) => path.basename(testPath).endsWith('_test.dart')).toList();
244243

245244
await runDartTest(
246245
_toolsPath,
247246
forceSingleCore: true,
248-
testPaths: selectIndexOfTotalSubshard<String>(toolIntegrationTests, subshardKey: '6_6'),
249-
collectMetrics: true,
250-
runSkipped: true,
251-
);
252-
253-
// Then run the health tests after.
254-
final List<String> flutterBuildApkTests = Directory(path.join(_toolsPath, 'test', 'flutter_build_apk.shard'))
255-
.listSync(recursive: true).whereType<File>()
256-
.map<String>((FileSystemEntity entry) => path.relative(entry.path, from: _toolsPath))
257-
.where((String testPath) => path.basename(testPath).endsWith('_test.dart')).toList();
258-
259-
await runDartTest(
260-
_toolsPath,
261-
forceSingleCore: true,
262-
testPaths: selectIndexOfTotalSubshard<String>(flutterBuildApkTests),
247+
testPaths: selectIndexOfTotalSubshard<String>(allTests),
263248
collectMetrics: true,
264249
);
265250
}

dev/bots/utils.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ Future<void> runDartTest(String workingDirectory, {
342342
bool ensurePrecompiledTool = true,
343343
bool shuffleTests = true,
344344
bool collectMetrics = false,
345-
bool runSkipped = false,
346345
}) async {
347346
int? cpus;
348347
final String? cpuVariable = Platform.environment['CPU']; // CPU is set in cirrus.yml
@@ -380,8 +379,6 @@ Future<void> runDartTest(String workingDirectory, {
380379
'--coverage=$coverage',
381380
if (perTestTimeout != null)
382381
'--timeout=${perTestTimeout.inMilliseconds}ms',
383-
if (runSkipped)
384-
'--run-skipped',
385382
if (testPaths != null)
386383
for (final String testPath in testPaths)
387384
testPath,

0 commit comments

Comments
 (0)