Skip to content

Commit 4115a78

Browse files
Make PipelineOwner a base class (#161789)
Such that nobody `implements` it. Currently it has private APIs used by the `RenderObject` class (e.g., the dirty lists). If someone were to implement a `PipelineOwner` outside of object.dart, they will get a runtime `noSuchMethod` crash since they won't be able to provide those private APIs and RenderObjects actually expect those APIs to exist. Will be slow to update/respond due to extremely spotty internet :( ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 883ef85 commit 4115a78

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/flutter/lib/src/rendering/binding.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@ class _BindingPipelineManifold extends ChangeNotifier implements PipelineManifol
827827
}
828828

829829
// A [PipelineOwner] that cannot have a root node.
830-
class _DefaultRootPipelineOwner extends PipelineOwner {
830+
final class _DefaultRootPipelineOwner extends PipelineOwner {
831831
_DefaultRootPipelineOwner() : super(onSemanticsUpdate: _onSemanticsUpdate);
832832

833833
@override

packages/flutter/lib/src/rendering/object.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,7 @@ class _LocalSemanticsHandle implements SemanticsHandle {
961961
/// without tying it to a specific binding implementation. All [PipelineOwner]s
962962
/// in a given tree must be attached to the same [PipelineManifold]. This
963963
/// happens automatically during [adoptChild].
964-
class PipelineOwner with DiagnosticableTreeMixin {
964+
base class PipelineOwner with DiagnosticableTreeMixin {
965965
/// Creates a pipeline owner.
966966
///
967967
/// Typically created by the binding (e.g., [RendererBinding]), but can be

packages/flutter/test/rendering/multi_view_binding_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ class FakeFlutterView extends Fake implements FlutterView {
200200
}
201201
}
202202

203-
class PipelineOwnerSpy extends PipelineOwner {
203+
final class PipelineOwnerSpy extends PipelineOwner {
204204
@override
205205
final SemanticsOwnerSpy semanticsOwner = SemanticsOwnerSpy();
206206
}

0 commit comments

Comments
 (0)