Skip to content

Commit aef7929

Browse files
authored
Report total_ui_gc_time to SkiaPerf (#125919)
Not sure why this wasn't already being reported.
1 parent 707261f commit aef7929

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

dev/devicelab/lib/tasks/perf_tests.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -936,6 +936,7 @@ class PerfTest {
936936
this.timelineFileName, {
937937
this.measureCpuGpu = true,
938938
this.measureMemory = true,
939+
this.measureTotalGCTime = true,
939940
this.saveTraceFile = false,
940941
this.testDriver,
941942
this.needsFullTimeline = true,
@@ -953,6 +954,7 @@ class PerfTest {
953954
this.testTarget, {
954955
this.measureCpuGpu = false,
955956
this.measureMemory = false,
957+
this.measureTotalGCTime = false,
956958
this.testDriver = 'test_driver/e2e_test.dart',
957959
this.needsFullTimeline = false,
958960
this.benchmarkScoreKeys = _kCommonScoreKeys,
@@ -979,6 +981,8 @@ class PerfTest {
979981
final bool measureCpuGpu;
980982
/// Whether to collect memory metrics.
981983
final bool measureMemory;
984+
/// Whether to summarize total GC time on the UI thread from the timeline.
985+
final bool measureTotalGCTime;
982986
/// Whether to collect full timeline, meaning if `--trace-startup` flag is needed.
983987
final bool needsFullTimeline;
984988
/// Whether to save the trace timeline file `*.timeline.json`.
@@ -1114,6 +1118,7 @@ class PerfTest {
11141118
if (data['90th_percentile_memory_usage'] != null) '90th_percentile_memory_usage',
11151119
if (data['99th_percentile_memory_usage'] != null) '99th_percentile_memory_usage',
11161120
],
1121+
if (measureTotalGCTime) 'total_ui_gc_time',
11171122
if (data['30hz_frame_percentage'] != null) '30hz_frame_percentage',
11181123
if (data['60hz_frame_percentage'] != null) '60hz_frame_percentage',
11191124
if (data['80hz_frame_percentage'] != null) '80hz_frame_percentage',

dev/devicelab/test/perf_tests_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ void main() {
5252
'90th_percentile_picture_cache_memory': 1,
5353
'99th_percentile_picture_cache_memory': 1,
5454
'worst_picture_cache_memory': 1,
55+
'total_ui_gc_time': 1,
5556
'new_gen_gc_count': 1,
5657
'old_gen_gc_count': 1,
5758
'average_vsync_transitions_missed': 1,
@@ -95,6 +96,7 @@ void main() {
9596
'90th_percentile_picture_cache_memory': 1,
9697
'99th_percentile_picture_cache_memory': 1,
9798
'worst_picture_cache_memory': 1,
99+
'total_ui_gc_time': 1,
98100
'new_gen_gc_count': 1,
99101
'old_gen_gc_count': 1,
100102
'average_vsync_transitions_missed': 1,

0 commit comments

Comments
 (0)