Skip to content

Commit c1091ac

Browse files
committed
Adds the JavaScript info loglevel
1 parent 0929696 commit c1091ac

File tree

12 files changed

+48
-7
lines changed

12 files changed

+48
-7
lines changed

packages/webview_flutter/webview_flutter/example/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,8 @@ flutter:
3636
- assets/sample_video.mp4
3737
- assets/www/index.html
3838
- assets/www/styles/style.css
39+
40+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
41+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
42+
dependency_overrides:
43+
{webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../../webview_flutter/webview_flutter_wkwebview}}

packages/webview_flutter/webview_flutter/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,8 @@ dev_dependencies:
2929
sdk: flutter
3030
mockito: 5.4.1
3131
plugin_platform_interface: ^2.1.3
32+
33+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
34+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
35+
dependency_overrides:
36+
{webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../webview_flutter/webview_flutter_wkwebview}}

packages/webview_flutter/webview_flutter_android/example/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,8 @@ flutter:
3333
- assets/sample_video.mp4
3434
- assets/www/index.html
3535
- assets/www/styles/style.css
36+
37+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
38+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
39+
dependency_overrides:
40+
{webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}

packages/webview_flutter/webview_flutter_android/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,8 @@ dev_dependencies:
2828
sdk: flutter
2929
mockito: 5.4.1
3030
pigeon: ^9.2.4
31+
32+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
33+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
34+
dependency_overrides:
35+
{webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}

packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/javascript_log_level.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ enum JavaScriptLogLevel {
1111
/// Indicates a debug message was logged using the `console.debug` method.
1212
debug,
1313

14+
/// Indicates an informational message was logged using the `console.info`
15+
/// method.
16+
info,
17+
1418
/// Indicates a log message was logged using the `console.log` method.
1519
log,
1620
}

packages/webview_flutter/webview_flutter_web/example/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,8 @@ dev_dependencies:
2828

2929
flutter:
3030
uses-material-design: true
31+
32+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
33+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
34+
dependency_overrides:
35+
{webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}

packages/webview_flutter/webview_flutter_web/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,8 @@ dev_dependencies:
2828
flutter_test:
2929
sdk: flutter
3030
mockito: 5.4.1
31+
32+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
33+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
34+
dependency_overrides:
35+
{webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}

packages/webview_flutter/webview_flutter_wkwebview/example/pubspec.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,8 @@ flutter:
3232
- assets/sample_video.mp4
3333
- assets/www/index.html
3434
- assets/www/styles/style.css
35+
36+
# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
37+
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
38+
dependency_overrides:
39+
{webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}, webview_flutter_wkwebview: {path: ../../../webview_flutter/webview_flutter_wkwebview}}

packages/webview_flutter/webview_flutter_wkwebview/example/pubspec_overrides.yaml

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,14 @@ class WebKitWebViewController extends PlatformWebViewController {
540540
_onConsoleLogCallback!(
541541
JavaScriptLogLevel.warning, consoleLog['message']! as String);
542542
break;
543-
case 'default':
543+
case 'debug':
544544
_onConsoleLogCallback!(
545545
JavaScriptLogLevel.debug, consoleLog['message']! as String);
546546
break;
547+
case 'info':
548+
_onConsoleLogCallback!(
549+
JavaScriptLogLevel.info, consoleLog['message']! as String);
550+
break;
547551
case 'log':
548552
default:
549553
_onConsoleLogCallback!(
@@ -574,11 +578,13 @@ function log(type, args) {
574578
}
575579
576580
let originalLog = console.log;
581+
let originalInfo = console.info;
577582
let originalWarn = console.warn;
578583
let originalError = console.error;
579584
let originalDebug = console.debug;
580585
581586
console.log = function() { log("log", arguments); originalLog.apply(null, arguments) };
587+
console.info = function() { log("info", arguments); originalInfo.apple(null, arguments) };
582588
console.warn = function() { log("warning", arguments); originalWarn.apply(null, arguments) };
583589
console.error = function() { log("error", arguments); originalError.apply(null, arguments) };
584590
console.debug = function() { log("debug", arguments); originalDebug.apply(null, arguments) };

0 commit comments

Comments
 (0)