Skip to content

Commit e6a7144

Browse files
[go_router] Remove unused dependency (#4545)
Removes `adaptive_dialog` from the example pubspec, as it is not used, and removes the repository allowance for it. Also updates the comments for the remaining pinned dependency exceptions to reflect the results of the audit. Part of flutter/flutter#130897
1 parent 46a1361 commit e6a7144

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

packages/go_router/example/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ environment:
88
flutter: ">=3.3.0"
99

1010
dependencies:
11-
adaptive_dialog: 1.8.2
1211
adaptive_navigation: ^0.0.4
1312
collection: ^1.15.0
1413
cupertino_icons: ^1.0.2

script/configs/allowed_pinned_deps.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@
44
# All entries here should have an explanation for why they are here.
55

66
# TODO(stuartmorgan): Eliminate this in favor of standardizing on
7-
# mockito.
7+
# mockito. See https://github.com/flutter/flutter/issues/130757
88
- mocktail
99

10-
# Legacy allowances, for dependencies that predate the tooling.
11-
# TODO(stuartmorgan): Audit these. See
12-
# https://github.com/flutter/flutter/issues/122713
10+
# Test-only dependency, so does not impact package clients, and
11+
# has limited impact so could be easily removed if there are
12+
# ever maintenance issues in the future.
1313
- lcov_parser
14-
- adaptive_dialog
14+
15+
# This should be removed; see
16+
# https://github.com/flutter/flutter/issues/130897
1517
- provider
1618

1719
## Allowed by default

0 commit comments

Comments
 (0)