Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 586faa631499
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8a2c4e499973
Choose a head ref
  • 8 commits
  • 144 files changed
  • 5 contributors

Commits on Jun 6, 2024

  1. Disable sandboxing for macOS tests in CI (#6866) 

    macOS 14 added new requirements that un-codesigned sandbox apps must be granted access when changed. Waiting for this UI caused macOS tests to fail on macOS 14. Additionally, adding codesigning is not sufficient, since it must still be approved before codesigning is enough to pass the check. As a workaround, this PR disables sandboxing for macOS tests in CI.

![Screenshot 2024-05-30 at 2 41 33�PM](https://github.com/flutter/flutter/assets/682784/1bc32620-5edb-420a-866c-5cc529b2ac55)

https://developer.apple.com/documentation/updates/security#June-2023)
> App Sandbox now associates your macOS app with its sandbox container using its code signature. The operating system asks the person using your app to grant permission if it tries to access a sandbox container associated with a different app. For more information, see [Accessing files from the macOS App Sandbox](https://developer.apple.com/documentation/security/app_sandbox/accessing_files_from_the_macos_app_sandbox).

And that link explains why this is happening on a macOS 14 update:

> In macOS 14 and later, the operating system uses your app�s code signature to associate it with its sandbox container. If your app tries to access the sandbox container owned by another app, the system asks the person using your app whether to grant access. If the person denies access and your app is already running, then it can�t read or write the files in the other app�s sandbox container. If the person denies access while your app is launching and trying to enter the other app�s sandbox container, your app fails to launch.
> 
> The operating system also tracks the association between an app�s code signing identity and its sandbox container for helper tools, including launch agents. If a person denies permission for a launch agent to enter its sandbox container and the app fails to start, launchd starts the launch agent again and the operating system re-requests access.

Fixes packages part of flutter/flutter#149264.

Verified tests pass:
https://ci.chromium.org/ui/p/flutter/builders/staging.shadow/Mac_arm64%20macos_platform_tests%20master%20-%20packages/6/overview
    @vashworth
    vashworth authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3282c23 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter from 27e0656 to 4608a89 (17 revisions) (#6876) 

    flutter/flutter@27e0656...4608a89

2024-06-06 [email protected] Fix InputDecorator suffixIcon color when in error and hovered (flutter/flutter#149643)
2024-06-06 [email protected] Roll Flutter Engine from 32c3b9b7cbe1 to 92d0cd9370f7 (1 revision) (flutter/flutter#149789)
2024-06-06 [email protected] Roll Flutter Engine from 0edca2e9d3d2 to 32c3b9b7cbe1 (2 revisions) (flutter/flutter#149786)
2024-06-06 [email protected] Roll Flutter Engine from f51e0ad3abbe to 0edca2e9d3d2 (8 revisions) (flutter/flutter#149785)
2024-06-06 [email protected] Roll Flutter Engine from f37733035060 to f51e0ad3abbe (3 revisions) (flutter/flutter#149778)
2024-06-05 [email protected] Remove abi key from local golden file testing (flutter/flutter#149696)
2024-06-05 [email protected] Fixes Router transaction to respect operation order (flutter/flutter#149763)
2024-06-05 [email protected] Send q once (flutter/flutter#149767)
2024-06-05 [email protected] Marks Mac_ios rrect_blur_perf_ios__timeline_summary to be unflaky (flutter/flutter#149729)
2024-06-05 [email protected] Add `contrastLevel` parameter to `ColorScheme.fromSeed` (flutter/flutter#149705)
2024-06-05 [email protected] Roll Flutter Engine from 11a32d43e3f6 to f37733035060 (11 revisions) (flutter/flutter#149770)
2024-06-05 [email protected] Remove unused code from an older test artifact. (flutter/flutter#149746)
2024-06-05 [email protected] Create CarouselView widget - Part 1 (flutter/flutter#148094)
2024-06-05 [email protected] [flutter_tools] Remove additional listener on VM service that simply logged incoming messages (flutter/flutter#149756)
2024-06-05 [email protected] Fix signature for TokenTemplate.updateFile (flutter/flutter#149673)
2024-06-05 [email protected] Remove temporary LayoutBuilder migration flag, defer `markNeedsLayout` (flutter/flutter#149637)
2024-06-05 [email protected] Revert "make output of flutter run web tests verbose (#149694)" (flutter/flutter#149766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a051bd6 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter (stable) from a14f74f to 761747b (6 revisions) (#6878) 

    flutter/flutter@a14f74f...761747b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-stable-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    027c7d0 View commit details
    Browse the repository at this point in the history

  4. [pigeon] Moves all codec logic to singular custom codec (#6600) 

    [pigeon] Moves all codec logic to singular custom codec.

Also fixes a few small codec related bugs that have cropped up over time.

fixes flutter/flutter#147454
fixes flutter/flutter#147127
fixes flutter/flutter#147587
fixes flutter/flutter#148065
    @tarrinneal
    tarrinneal authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2e928d7 View commit details
    Browse the repository at this point in the history

  5. Disable sandboxing directly for macOS tests (#6880) 

    macOS 14 requires sandboxing to be disabled in CI (see flutter/flutter#149618 for details). This is handled via the tool in flutter/flutter#149618, but that commit has yet to land in stable. To allow packages stable tests to run on macOS 14, disable sandboxing directly for macOS example apps.

Verified tests pass on macOS 14:
https://ci.chromium.org/ui/p/flutter/builders/staging.shadow/Mac_arm64%20macos_platform_tests%20stable%20-%20packages/6/infra
https://ci.chromium.org/ui/p/flutter/builders/staging.shadow/Mac_arm64%20custom_package_tests%20stable/3/overview
    @vashworth
    vashworth authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4a178f1 View commit details
    Browse the repository at this point in the history

  6. Run tests on macOS 13 or 14 (#6877) 

    In preparation of upgrading our fleet to macOS 14, allow tests to run on either macOS 13 or 14.

Fixes flutter/flutter#148873.
    @vashworth
    vashworth authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6a01138 View commit details
    Browse the repository at this point in the history

  7. [two_dimensional_scrollables] Adds generics to the callbacks and buil… 

    …ders of TreeView (#6864)

This PR adds generics to the callbacks and builders of the TreeView widget. This removes the need to type cast the content of a TreeViewNode.

Fixes flutter/flutter#149656
    @baumths
    baumths authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fb1eeff View commit details
    Browse the repository at this point in the history

  8. Revert "Migrate video_player/android from SurfaceTexture->`Surfac… 

    …eProducer`." (#6882)

Reverts #6456
    Jonah Williams authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8a2c4e4 View commit details
    Browse the repository at this point in the history
Loading