From d745c39c6e68196d507a430a1534478a86d2f719 Mon Sep 17 00:00:00 2001 From: Camille Simon Date: Tue, 21 Oct 2025 11:03:54 -0700 Subject: [PATCH] change temp extension to mp4 --- .../camera_android_camerax/CHANGELOG.md | 4 ++ .../lib/src/android_camera_camerax.dart | 2 +- .../camera_android_camerax/pubspec.yaml | 2 +- .../test/android_camera_camerax_test.dart | 46 +++++++++---------- 4 files changed, 29 insertions(+), 25 deletions(-) diff --git a/packages/camera/camera_android_camerax/CHANGELOG.md b/packages/camera/camera_android_camerax/CHANGELOG.md index 7f9950e4cbf..e95bf96c6b1 100644 --- a/packages/camera/camera_android_camerax/CHANGELOG.md +++ b/packages/camera/camera_android_camerax/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.24 + +* Change plugin to assume mp4 format for capture videos. + ## 0.6.23+3 * Bumps camerax_version from 1.5.0 to 1.5.1. diff --git a/packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart b/packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart index 5ba79f7f710..f88abd5eb7e 100644 --- a/packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart +++ b/packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart @@ -1181,7 +1181,7 @@ class AndroidCameraCameraX extends CameraPlatform { videoOutputPath = await systemServicesManager.getTempFilePath( videoPrefix, - '.temp', + '.mp4', ); pendingRecording = await recorder!.prepareRecording(videoOutputPath!); diff --git a/packages/camera/camera_android_camerax/pubspec.yaml b/packages/camera/camera_android_camerax/pubspec.yaml index 67a1cb516e9..12d68972dc6 100644 --- a/packages/camera/camera_android_camerax/pubspec.yaml +++ b/packages/camera/camera_android_camerax/pubspec.yaml @@ -2,7 +2,7 @@ name: camera_android_camerax description: Android implementation of the camera plugin using the CameraX library. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.6.23+3 +version: 0.6.24 environment: sdk: ^3.9.0 diff --git a/packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart b/packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart index f49264de33a..3df67d25f35 100644 --- a/packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart +++ b/packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart @@ -3311,7 +3311,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -3350,7 +3350,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -3480,7 +3480,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -3519,7 +3519,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -3607,7 +3607,7 @@ void main() { verify( camera.systemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).called(1); verifyNoMoreInteractions(camera.systemServicesManager); @@ -3650,7 +3650,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Analyzer for testing. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -3689,7 +3689,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -3807,7 +3807,7 @@ void main() { camera.enableRecordingAudio = false; // Tell plugin to mock call to get current video orientation and mock Camera2CameraInfo retrieval. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -3848,7 +3848,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -4354,7 +4354,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -4696,7 +4696,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -7600,7 +7600,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -7639,7 +7639,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -7744,7 +7744,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -7783,7 +7783,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -7888,7 +7888,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newObserver: ({ @@ -7927,7 +7927,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -8037,7 +8037,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newAnalyzer: ({ @@ -8091,7 +8091,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -8205,7 +8205,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newAnalyzer: ({ @@ -8259,7 +8259,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager; @@ -8365,7 +8365,7 @@ void main() { camera.captureOrientationLocked = true; // Tell plugin to create detached Observer when camera info updated. - const String outputPath = '/temp/REC123.temp'; + const String outputPath = '/temp/REC123.mp4'; camera.proxy = CameraXProxy( newAnalyzer: ({ @@ -8419,7 +8419,7 @@ void main() { when( mockSystemServicesManager.getTempFilePath( camera.videoPrefix, - '.temp', + '.mp4', ), ).thenAnswer((_) async => outputPath); return mockSystemServicesManager;