From 2a4845ffc54584ffcd8265d9b09976a67ae99c83 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Thu, 18 Jan 2024 03:40:53 +0100 Subject: [PATCH 1/8] feat(kotlin_generator.dart): implement screaming snake case conversion for enum member names to follow Kotlin naming conventions test(kotlin_generator_test.dart): update test cases to reflect changes in enum member name conversion --- packages/pigeon/lib/kotlin_generator.dart | 7 ++++++- .../pigeon/test/kotlin_generator_test.dart | 18 +++++++++--------- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/packages/pigeon/lib/kotlin_generator.dart b/packages/pigeon/lib/kotlin_generator.dart index a61eb42865d..701a69ac39e 100644 --- a/packages/pigeon/lib/kotlin_generator.dart +++ b/packages/pigeon/lib/kotlin_generator.dart @@ -127,7 +127,12 @@ class KotlinGenerator extends StructuredGenerator { enumerate(anEnum.members, (int index, final EnumMember member) { addDocumentationComments( indent, member.documentationComments, _docCommentSpec); - indent.write('${member.name.toUpperCase()}($index)'); + final String nameScreamingSnakeCase = member.name + .replaceAllMapped( + RegExp(r'(?<=[a-z])[A-Z]'), + (Match m) => '_${m.group(0)}') + .toUpperCase(); + indent.write('$nameScreamingSnakeCase($index)'); if (index != anEnum.members.length - 1) { indent.addln(','); } else { diff --git a/packages/pigeon/test/kotlin_generator_test.dart b/packages/pigeon/test/kotlin_generator_test.dart index f51c68b32bc..711ecbcf4a4 100644 --- a/packages/pigeon/test/kotlin_generator_test.dart +++ b/packages/pigeon/test/kotlin_generator_test.dart @@ -845,12 +845,12 @@ void main() { expect(code, matches('fun doSomething.*Input.*callback.*Output.*Unit')); }); - test('gen one enum class', () { + test('gen one enum class with screaming snake case conversion', () { final Enum anEnum = Enum( - name: 'Enum1', + name: 'SampleEnum', members: [ - EnumMember(name: 'one'), - EnumMember(name: 'two'), + EnumMember(name: 'sampleVersion'), + EnumMember(name: 'sampleTest'), ], ); final Class classDefinition = Class( @@ -858,11 +858,11 @@ void main() { fields: [ NamedType( type: TypeDeclaration( - baseName: 'Enum1', + baseName: 'SampleEnum', associatedEnum: emptyEnum, isNullable: true, ), - name: 'enum1', + name: 'sampleEnum', ), ], ); @@ -881,9 +881,9 @@ void main() { dartPackageName: DEFAULT_PACKAGE_NAME, ); final String code = sink.toString(); - expect(code, contains('enum class Enum1(val raw: Int)')); - expect(code, contains('ONE(0)')); - expect(code, contains('TWO(1)')); + expect(code, contains('enum class SampleEnum(val raw: Int)')); + expect(code, contains('SAMPLE_VERSION(0)')); + expect(code, contains('SAMPLE_TEST(1)')); }); Iterable makeIterable(String string) sync* { From 531f87c5b9e790950188aa794d2089e712a69446 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Thu, 18 Jan 2024 03:51:56 +0100 Subject: [PATCH 2/8] chore(pigeon): update pigeon package version to 17.0.0 in generator_tools.dart and pubspec.yaml to reflect new changes docs(pigeon): update CHANGELOG.md with details of the new version and migration note for users --- packages/pigeon/CHANGELOG.md | 8 ++++++++ packages/pigeon/lib/generator_tools.dart | 2 +- packages/pigeon/pubspec.yaml | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/pigeon/CHANGELOG.md b/packages/pigeon/CHANGELOG.md index 6a901e11287..8c7540f78ce 100644 --- a/packages/pigeon/CHANGELOG.md +++ b/packages/pigeon/CHANGELOG.md @@ -1,3 +1,11 @@ +## 17.0.0 + +* **Breaking Change** [kotlin] Converts Kotlin enum case generation to SCREAMING_SNAKE_CASE. + * Updates `writeEnum` function to adhere to Kotlin naming conventions. + * Improves handling of complex names with enhanced regex patterns. + * Expands unit tests for comprehensive name conversion validation. + * **Migration Note**: This change modifies the naming convention of Kotlin enum cases generated from the Pigeon package. It is recommended to review the impact on your existing codebase and update any dependent code accordingly. + ## 16.0.3 * [kotlin] Separates message call code generation into separate methods. diff --git a/packages/pigeon/lib/generator_tools.dart b/packages/pigeon/lib/generator_tools.dart index 31a4d0e778b..adf93f4c470 100644 --- a/packages/pigeon/lib/generator_tools.dart +++ b/packages/pigeon/lib/generator_tools.dart @@ -13,7 +13,7 @@ import 'ast.dart'; /// The current version of pigeon. /// /// This must match the version in pubspec.yaml. -const String pigeonVersion = '16.0.3'; +const String pigeonVersion = '17.0.0'; /// Read all the content from [stdin] to a String. String readStdin() { diff --git a/packages/pigeon/pubspec.yaml b/packages/pigeon/pubspec.yaml index c6029d4ed30..525c3706db6 100644 --- a/packages/pigeon/pubspec.yaml +++ b/packages/pigeon/pubspec.yaml @@ -2,7 +2,7 @@ name: pigeon description: Code generator tool to make communication between Flutter and the host platform type-safe and easier. repository: https://github.com/flutter/packages/tree/main/packages/pigeon issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22 -version: 16.0.3 # This must match the version in lib/generator_tools.dart +version: 17.0.0 # This must match the version in lib/generator_tools.dart environment: sdk: ">=3.0.0 <4.0.0" From 35423a7d254e25b7c4ca99c66367e498f79538ec Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Fri, 19 Jan 2024 20:40:53 +0100 Subject: [PATCH 3/8] refactor(kotlin_generator_test.dart): use original test description for enum class generation --- packages/pigeon/test/kotlin_generator_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pigeon/test/kotlin_generator_test.dart b/packages/pigeon/test/kotlin_generator_test.dart index 711ecbcf4a4..df587c6623a 100644 --- a/packages/pigeon/test/kotlin_generator_test.dart +++ b/packages/pigeon/test/kotlin_generator_test.dart @@ -845,7 +845,7 @@ void main() { expect(code, matches('fun doSomething.*Input.*callback.*Output.*Unit')); }); - test('gen one enum class with screaming snake case conversion', () { + test('gen one enum class', () { final Enum anEnum = Enum( name: 'SampleEnum', members: [ From 1fa26d63c73642e965b41970792515a295703f22 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Fri, 19 Jan 2024 22:21:50 +0100 Subject: [PATCH 4/8] feat(kotlin_generator.dart, enum.dart, enum.gen.dart, EnumTest.kt): add SnakeCase enum member to EnumState refactor(kotlin_generator.dart): simplify nameScreamingSnakeCase regex replacement logic test(EnumTest.kt): update test cases to use new SnakeCase enum member for better coverage --- packages/pigeon/lib/kotlin_generator.dart | 3 +-- packages/pigeon/pigeons/enum.dart | 3 +++ .../shared_test_plugin_code/lib/src/generated/enum.gen.dart | 3 +++ .../src/test/kotlin/com/example/test_plugin/EnumTest.kt | 4 ++-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/pigeon/lib/kotlin_generator.dart b/packages/pigeon/lib/kotlin_generator.dart index 701a69ac39e..2647e81a785 100644 --- a/packages/pigeon/lib/kotlin_generator.dart +++ b/packages/pigeon/lib/kotlin_generator.dart @@ -129,8 +129,7 @@ class KotlinGenerator extends StructuredGenerator { indent, member.documentationComments, _docCommentSpec); final String nameScreamingSnakeCase = member.name .replaceAllMapped( - RegExp(r'(?<=[a-z])[A-Z]'), - (Match m) => '_${m.group(0)}') + RegExp(r'(?<=[a-z])[A-Z]'), (Match m) => '_${m.group(0)}') .toUpperCase(); indent.write('$nameScreamingSnakeCase($index)'); if (index != anEnum.members.length - 1) { diff --git a/packages/pigeon/pigeons/enum.dart b/packages/pigeon/pigeons/enum.dart index 7a39e0bea2c..b060fe5a53d 100644 --- a/packages/pigeon/pigeons/enum.dart +++ b/packages/pigeon/pigeons/enum.dart @@ -18,6 +18,9 @@ enum EnumState { /// This comment is to test enum member (Error) documentation comments. Error, + + /// This comment is to test enum member (SnakeCase) documentation comments. + SnakeCase, } /// This comment is to test class documentation comments. diff --git a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/enum.gen.dart b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/enum.gen.dart index 8354d159d33..c585d3a8325 100644 --- a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/enum.gen.dart +++ b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/enum.gen.dart @@ -40,6 +40,9 @@ enum EnumState { /// This comment is to test enum member (Error) documentation comments. Error, + + /// This comment is to test enum member (SnakeCase) documentation comments. + SnakeCase, } /// This comment is to test class documentation comments. diff --git a/packages/pigeon/platform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/EnumTest.kt b/packages/pigeon/platform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/EnumTest.kt index 8e78e7abd2f..1117a8a3a1e 100644 --- a/packages/pigeon/platform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/EnumTest.kt +++ b/packages/pigeon/platform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/EnumTest.kt @@ -21,7 +21,7 @@ internal class EnumTest : TestCase() { val api = mockk() val channelName = "dev.flutter.pigeon.pigeon_integration_tests.EnumApi2Host.echo" - val input = DataWithEnum(EnumState.SUCCESS) + val input = DataWithEnum(EnumState.SNAKE_CASE) val handlerSlot = slot() @@ -52,7 +52,7 @@ internal class EnumTest : TestCase() { val binaryMessenger = mockk() val api = EnumApi2Flutter(binaryMessenger) - val input = DataWithEnum(EnumState.SUCCESS) + val input = DataWithEnum(EnumState.SNAKE_CASE) every { binaryMessenger.send(any(), any(), any()) } answers { From 5d9c6ba5b98a95013616d2a981ab15c020e24b76 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Wed, 7 Feb 2024 21:57:30 +0100 Subject: [PATCH 5/8] feat(core_tests.dart): add new enum values 'fourtyTwo' and 'fourHundredTwentyTwo' to AnEnum for extended test coverage --- packages/pigeon/pigeons/core_tests.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/pigeon/pigeons/core_tests.dart b/packages/pigeon/pigeons/core_tests.dart index a0c6a3ccf29..9a4b7c4e52c 100644 --- a/packages/pigeon/pigeons/core_tests.dart +++ b/packages/pigeon/pigeons/core_tests.dart @@ -8,6 +8,8 @@ enum AnEnum { one, two, three, + fourtyTwo, + fourHundredTwentyTwo, } /// A class containing all supported types. From 630191bc33e7e00bbc01ae2ca0e2dea652dea177 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Wed, 7 Feb 2024 22:52:13 +0100 Subject: [PATCH 6/8] feat(core_tests.gen.dart): add new enum values 'fourtyTwo' and 'fourHundredTwentyTwo' to AnEnum to extend test coverage --- .../lib/src/generated/core_tests.gen.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart index 6815f461c94..3e0ef78c748 100644 --- a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart +++ b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart @@ -34,6 +34,8 @@ enum AnEnum { one, two, three, + fourtyTwo, + fourHundredTwentyTwo, } /// A class containing all supported types. From 4fd43eef2ac025e31d0e1cbb335b6836c35bde10 Mon Sep 17 00:00:00 2001 From: erdzan12 <32931186+erdzan12@users.noreply.github.com> Date: Wed, 7 Feb 2024 22:53:46 +0100 Subject: [PATCH 7/8] fix(core_tests.dart): correct spelling of 'fourtyTwo' to 'fortyTwo' in AnEnum for better code readability and to follow correct English spelling conventions --- packages/pigeon/pigeons/core_tests.dart | 2 +- .../lib/src/generated/core_tests.gen.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/pigeon/pigeons/core_tests.dart b/packages/pigeon/pigeons/core_tests.dart index 9a4b7c4e52c..9d571688a09 100644 --- a/packages/pigeon/pigeons/core_tests.dart +++ b/packages/pigeon/pigeons/core_tests.dart @@ -8,7 +8,7 @@ enum AnEnum { one, two, three, - fourtyTwo, + fortyTwo, fourHundredTwentyTwo, } diff --git a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart index 3e0ef78c748..98c1aea5c08 100644 --- a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart +++ b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/src/generated/core_tests.gen.dart @@ -34,7 +34,7 @@ enum AnEnum { one, two, three, - fourtyTwo, + fortyTwo, fourHundredTwentyTwo, } From 679cc3d1f9c3790130cafef211f091a9c53a5306 Mon Sep 17 00:00:00 2001 From: tarrinneal Date: Wed, 7 Feb 2024 14:16:30 -0800 Subject: [PATCH 8/8] integration tests --- .../CoreTests.java | 4 +- .../ios/Classes/CoreTests.gen.h | 2 + .../macos/Classes/CoreTests.gen.h | 2 + .../lib/integration_tests.dart | 58 ++++++++++++++++++- .../com/example/test_plugin/CoreTests.gen.kt | 4 +- .../ios/Classes/CoreTests.gen.swift | 2 + .../macos/Classes/CoreTests.gen.swift | 2 + .../windows/pigeon/core_tests.gen.h | 8 ++- 8 files changed, 77 insertions(+), 5 deletions(-) diff --git a/packages/pigeon/platform_tests/alternate_language_test_plugin/android/src/main/java/com/example/alternate_language_test_plugin/CoreTests.java b/packages/pigeon/platform_tests/alternate_language_test_plugin/android/src/main/java/com/example/alternate_language_test_plugin/CoreTests.java index 8585b13315a..0917a8cfa79 100644 --- a/packages/pigeon/platform_tests/alternate_language_test_plugin/android/src/main/java/com/example/alternate_language_test_plugin/CoreTests.java +++ b/packages/pigeon/platform_tests/alternate_language_test_plugin/android/src/main/java/com/example/alternate_language_test_plugin/CoreTests.java @@ -77,7 +77,9 @@ protected static FlutterError createConnectionError(@NonNull String channelName) public enum AnEnum { ONE(0), TWO(1), - THREE(2); + THREE(2), + FORTY_TWO(3), + FOUR_HUNDRED_TWENTY_TWO(4); final int index; diff --git a/packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h b/packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h index 782c3794a13..e7022baa940 100644 --- a/packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h +++ b/packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h @@ -18,6 +18,8 @@ typedef NS_ENUM(NSUInteger, AnEnum) { AnEnumOne = 0, AnEnumTwo = 1, AnEnumThree = 2, + AnEnumFortyTwo = 3, + AnEnumFourHundredTwentyTwo = 4, }; /// Wrapper for AnEnum to allow for nullability. diff --git a/packages/pigeon/platform_tests/alternate_language_test_plugin/macos/Classes/CoreTests.gen.h b/packages/pigeon/platform_tests/alternate_language_test_plugin/macos/Classes/CoreTests.gen.h index 782c3794a13..e7022baa940 100644 --- a/packages/pigeon/platform_tests/alternate_language_test_plugin/macos/Classes/CoreTests.gen.h +++ b/packages/pigeon/platform_tests/alternate_language_test_plugin/macos/Classes/CoreTests.gen.h @@ -18,6 +18,8 @@ typedef NS_ENUM(NSUInteger, AnEnum) { AnEnumOne = 0, AnEnumTwo = 1, AnEnumThree = 2, + AnEnumFortyTwo = 3, + AnEnumFourHundredTwentyTwo = 4, }; /// Wrapper for AnEnum to allow for nullability. diff --git a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart index 6b60a87e146..4ebee6b740a 100644 --- a/packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart +++ b/packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart @@ -138,7 +138,7 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { 'd': false, 'e': null }, - anEnum: AnEnum.two, + anEnum: AnEnum.fortyTwo, anObject: 1, ); @@ -166,7 +166,7 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { ], nullableMapWithAnnotations: {}, nullableMapWithObject: {}, - aNullableEnum: AnEnum.two, + aNullableEnum: AnEnum.fourHundredTwentyTwo, aNullableObject: 0, ); @@ -443,6 +443,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(receivedEnum, sentEnum); }); + testWidgets('multi word enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fortyTwo; + final AnEnum receivedEnum = await api.echoEnum(sentEnum); + expect(receivedEnum, sentEnum); + }); + testWidgets('required named parameter', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); // This number corresponds with the default value of this method. @@ -648,6 +657,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(echoEnum, sentEnum); }); + testWidgets('multi word nullable enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fourHundredTwentyTwo; + final AnEnum? echoEnum = await api.echoNullableEnum(sentEnum); + expect(echoEnum, sentEnum); + }); + testWidgets('null lists serialize and deserialize correctly', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); @@ -887,6 +905,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(echoEnum, sentEnum); }); + testWidgets('multi word enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fourHundredTwentyTwo; + final AnEnum echoEnum = await api.echoAsyncEnum(sentEnum); + expect(echoEnum, sentEnum); + }); + testWidgets('nullable Int async serialize and deserialize correctly', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); @@ -1004,6 +1031,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(echoEnum, sentEnum); }); + testWidgets('nullable enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fortyTwo; + final AnEnum? echoEnum = await api.echoAsyncNullableEnum(sentEnum); + expect(echoEnum, sentEnum); + }); + testWidgets('null Ints async serialize and deserialize correctly', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); @@ -1243,6 +1279,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(echoEnum, sentEnum); }); + testWidgets('multi word enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fortyTwo; + final AnEnum echoEnum = await api.callFlutterEchoEnum(sentEnum); + expect(echoEnum, sentEnum); + }); + testWidgets('nullable booleans serialize and deserialize correctly', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); @@ -1407,6 +1452,15 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) { expect(echoEnum, sentEnum); }); + testWidgets('multi word nullable enums serialize and deserialize correctly', + (WidgetTester _) async { + final HostIntegrationCoreApi api = HostIntegrationCoreApi(); + + const AnEnum sentEnum = AnEnum.fourHundredTwentyTwo; + final AnEnum? echoEnum = await api.callFlutterEchoNullableEnum(sentEnum); + expect(echoEnum, sentEnum); + }); + testWidgets('null enums serialize and deserialize correctly', (WidgetTester _) async { final HostIntegrationCoreApi api = HostIntegrationCoreApi(); diff --git a/packages/pigeon/platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/CoreTests.gen.kt b/packages/pigeon/platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/CoreTests.gen.kt index 798d6684989..c3ec9d98caf 100644 --- a/packages/pigeon/platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/CoreTests.gen.kt +++ b/packages/pigeon/platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/CoreTests.gen.kt @@ -51,7 +51,9 @@ class CoreTestsError( enum class AnEnum(val raw: Int) { ONE(0), TWO(1), - THREE(2); + THREE(2), + FORTY_TWO(3), + FOUR_HUNDRED_TWENTY_TWO(4); companion object { fun ofRaw(raw: Int): AnEnum? { diff --git a/packages/pigeon/platform_tests/test_plugin/ios/Classes/CoreTests.gen.swift b/packages/pigeon/platform_tests/test_plugin/ios/Classes/CoreTests.gen.swift index 14bcb9a4113..62682b44c2c 100644 --- a/packages/pigeon/platform_tests/test_plugin/ios/Classes/CoreTests.gen.swift +++ b/packages/pigeon/platform_tests/test_plugin/ios/Classes/CoreTests.gen.swift @@ -53,6 +53,8 @@ enum AnEnum: Int { case one = 0 case two = 1 case three = 2 + case fortyTwo = 3 + case fourHundredTwentyTwo = 4 } /// A class containing all supported types. diff --git a/packages/pigeon/platform_tests/test_plugin/macos/Classes/CoreTests.gen.swift b/packages/pigeon/platform_tests/test_plugin/macos/Classes/CoreTests.gen.swift index 14bcb9a4113..62682b44c2c 100644 --- a/packages/pigeon/platform_tests/test_plugin/macos/Classes/CoreTests.gen.swift +++ b/packages/pigeon/platform_tests/test_plugin/macos/Classes/CoreTests.gen.swift @@ -53,6 +53,8 @@ enum AnEnum: Int { case one = 0 case two = 1 case three = 2 + case fortyTwo = 3 + case fourHundredTwentyTwo = 4 } /// A class containing all supported types. diff --git a/packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.h b/packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.h index 53c3320b3cf..484d5e349bc 100644 --- a/packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.h +++ b/packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.h @@ -65,7 +65,13 @@ class ErrorOr { std::variant v_; }; -enum class AnEnum { one = 0, two = 1, three = 2 }; +enum class AnEnum { + one = 0, + two = 1, + three = 2, + fortyTwo = 3, + fourHundredTwentyTwo = 4 +}; // A class containing all supported types. //