From 8863ea508da7b4bf2f5c70f1f5ea9f46a19c9176 Mon Sep 17 00:00:00 2001 From: Huan Lin Date: Thu, 1 Aug 2024 21:07:49 -0700 Subject: [PATCH 1/2] [pointer_interceptor]add performance warning on using pointer interceptor on iOS --- packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md | 1 + packages/pointer_interceptor/pointer_interceptor/README.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md index 0a47b7de02e..cb8bae6aa70 100644 --- a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md +++ b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md @@ -1,5 +1,6 @@ ## NEXT +* Adds performance warning about using multiple pointer interceptors on iOS. * Updates minimum supported SDK version to Flutter 3.16/Dart 3.2. ## 0.10.1+1 diff --git a/packages/pointer_interceptor/pointer_interceptor/README.md b/packages/pointer_interceptor/pointer_interceptor/README.md index a2033491ae2..2b06883e4df 100644 --- a/packages/pointer_interceptor/pointer_interceptor/README.md +++ b/packages/pointer_interceptor/pointer_interceptor/README.md @@ -6,6 +6,8 @@ `PointerInterceptor` is a widget that prevents mouse events from being captured by an underlying [`HtmlElementView`](https://api.flutter.dev/flutter/widgets/HtmlElementView-class.html) in web, or an underlying [`PlatformView`](https://api.flutter.dev/flutter/widgets/PlatformViewLink-class.html) on iOS. +Using multiple `PointerInterceptor` on iOS can be slow with increased memory usage, due to performance overhead of the underlying platform view. + ## What is the problem? When overlaying Flutter widgets on top of `HtmlElementView`/`PlatformView` widgets that respond to mouse gestures (handle clicks, for example), the clicks will be consumed by the `HtmlElementView`/`PlatformView`, and not relayed to Flutter. From 887f09790c71b4ff17396358a00946c47171b5d3 Mon Sep 17 00:00:00 2001 From: Huan Lin Date: Mon, 5 Aug 2024 11:31:22 -0700 Subject: [PATCH 2/2] address feedback --- packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md | 2 +- packages/pointer_interceptor/pointer_interceptor/README.md | 2 +- packages/pointer_interceptor/pointer_interceptor/pubspec.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md index cb8bae6aa70..46a6f15db1b 100644 --- a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md +++ b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md @@ -1,4 +1,4 @@ -## NEXT +## 0.10.1+2 * Adds performance warning about using multiple pointer interceptors on iOS. * Updates minimum supported SDK version to Flutter 3.16/Dart 3.2. diff --git a/packages/pointer_interceptor/pointer_interceptor/README.md b/packages/pointer_interceptor/pointer_interceptor/README.md index 2b06883e4df..ebeb90cc02d 100644 --- a/packages/pointer_interceptor/pointer_interceptor/README.md +++ b/packages/pointer_interceptor/pointer_interceptor/README.md @@ -6,7 +6,7 @@ `PointerInterceptor` is a widget that prevents mouse events from being captured by an underlying [`HtmlElementView`](https://api.flutter.dev/flutter/widgets/HtmlElementView-class.html) in web, or an underlying [`PlatformView`](https://api.flutter.dev/flutter/widgets/PlatformViewLink-class.html) on iOS. -Using multiple `PointerInterceptor` on iOS can be slow with increased memory usage, due to performance overhead of the underlying platform view. +Using multiple `PointerInterceptor` instances on iOS can be slow and increases memory usage due to the performance overhead of the underlying platform view. ## What is the problem? diff --git a/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml index 3e10acce31b..af3f843cd0c 100644 --- a/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml @@ -2,7 +2,7 @@ name: pointer_interceptor description: A widget to prevent clicks from being swallowed by underlying HtmlElementViews on the web. repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pointer_interceptor%22 -version: 0.10.1+1 +version: 0.10.1+2 environment: sdk: ^3.2.0