From 52a73afee0b268630272002bb44a52973b977658 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Thu, 27 Mar 2025 12:55:17 -0400 Subject: [PATCH 1/2] fix --- packages/interactive_media_ads/CHANGELOG.md | 4 ++++ .../packages/interactive_media_ads/AdsRequestProxyApi.kt | 2 +- .../AdsManagerDelegateProxyAPIDelegate.swift | 1 + .../AdsRequestProxyAPIDelegate.swift | 2 +- .../InteractiveMediaAdsLibrary.g.swift | 8 +++++++- .../lib/src/ios/ios_ads_manager.dart | 1 + packages/interactive_media_ads/pubspec.yaml | 2 +- 7 files changed, 16 insertions(+), 4 deletions(-) diff --git a/packages/interactive_media_ads/CHANGELOG.md b/packages/interactive_media_ads/CHANGELOG.md index ca42a6b8ede..16ac45af260 100644 --- a/packages/interactive_media_ads/CHANGELOG.md +++ b/packages/interactive_media_ads/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.2.3+10 + +* Fixes `AdEventType`s not triggering on iOS in release mode. + ## 0.2.3+9 * Bumps gradle from 8.0.0 to 8.9.0. diff --git a/packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt b/packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt index e3f8e331305..c66838486ed 100644 --- a/packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt +++ b/packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt @@ -21,7 +21,7 @@ class AdsRequestProxyApi(override val pigeonRegistrar: ProxyApiRegistrar) : * * This must match the version in pubspec.yaml. */ - const val pluginVersion = "0.2.3+9" + const val pluginVersion = "0.2.3+10" } override fun setAdTagUrl(pigeon_instance: AdsRequest, adTagUrl: String) { diff --git a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift index 8b48f77a30b..93f2a0aa1f5 100644 --- a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift +++ b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift @@ -14,6 +14,7 @@ class AdsManagerDelegateImpl: NSObject, IMAAdsManagerDelegate { } func adsManager(_ adsManager: IMAAdsManager, didReceive event: IMAAdEvent) { + print("Swift: \(event.typeString)") api.didReceiveAdEvent(pigeonInstance: self, adsManager: adsManager, event: event) { _ in } } diff --git a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift index b21476e3dea..90fe2e8a83d 100644 --- a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift +++ b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift @@ -13,7 +13,7 @@ class AdsRequestProxyAPIDelegate: PigeonApiDelegateIMAAdsRequest { /// The current version of the `interactive_media_ads` plugin. /// /// This must match the version in pubspec.yaml. - static let pluginVersion = "0.2.3+9" + static let pluginVersion = "0.2.3+10" func pigeonDefaultConstructor( pigeonApi: PigeonApiIMAAdsRequest, adTagUrl: String, adDisplayContainer: IMAAdDisplayContainer, diff --git a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift index 5f5211ca0c1..2f0b6402842 100644 --- a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift +++ b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift @@ -321,7 +321,13 @@ private class InteractiveMediaAdsLibraryPigeonInstanceManagerApi { let args = message as! [Any?] let identifierArg = args[0] as! Int64 do { - let _: AnyObject? = try instanceManager.removeInstance(withIdentifier: identifierArg) + let o: AnyObject? = try instanceManager.removeInstance(withIdentifier: identifierArg) + print("GBC Object:") + if let o = o { + print(o) + } else { + print("null") + } reply(wrapResult(nil)) } catch { reply(wrapError(error)) diff --git a/packages/interactive_media_ads/lib/src/ios/ios_ads_manager.dart b/packages/interactive_media_ads/lib/src/ios/ios_ads_manager.dart index 9d8c1c5ac4c..740d568c9dd 100644 --- a/packages/interactive_media_ads/lib/src/ios/ios_ads_manager.dart +++ b/packages/interactive_media_ads/lib/src/ios/ios_ads_manager.dart @@ -22,6 +22,7 @@ class IOSAdsManager extends PlatformAdsManager { // This must maintain a reference to the delegate because the native // `IMAAdsManagerDelegate.delegate` property is only a weak reference. // Therefore, this would be garbage collected without this explicit reference. + @pragma('vm:entry-point') // ignore: unused_field late IOSAdsManagerDelegate _delegate; diff --git a/packages/interactive_media_ads/pubspec.yaml b/packages/interactive_media_ads/pubspec.yaml index 140f3a473a2..4ce4525f312 100644 --- a/packages/interactive_media_ads/pubspec.yaml +++ b/packages/interactive_media_ads/pubspec.yaml @@ -2,7 +2,7 @@ name: interactive_media_ads description: A Flutter plugin for using the Interactive Media Ads SDKs on Android and iOS. repository: https://github.com/flutter/packages/tree/main/packages/interactive_media_ads issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22 -version: 0.2.3+9 # This must match the version in +version: 0.2.3+10 # This must match the version in # `android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt` and # `ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift` From d43eb1dc74a525a748462af29f251fb351a43f3a Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Thu, 27 Mar 2025 12:58:48 -0400 Subject: [PATCH 2/2] remove prints --- .../AdsManagerDelegateProxyAPIDelegate.swift | 1 - .../InteractiveMediaAdsLibrary.g.swift | 8 +------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift index 93f2a0aa1f5..8b48f77a30b 100644 --- a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift +++ b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsManagerDelegateProxyAPIDelegate.swift @@ -14,7 +14,6 @@ class AdsManagerDelegateImpl: NSObject, IMAAdsManagerDelegate { } func adsManager(_ adsManager: IMAAdsManager, didReceive event: IMAAdEvent) { - print("Swift: \(event.typeString)") api.didReceiveAdEvent(pigeonInstance: self, adsManager: adsManager, event: event) { _ in } } diff --git a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift index 2f0b6402842..5f5211ca0c1 100644 --- a/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift +++ b/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/InteractiveMediaAdsLibrary.g.swift @@ -321,13 +321,7 @@ private class InteractiveMediaAdsLibraryPigeonInstanceManagerApi { let args = message as! [Any?] let identifierArg = args[0] as! Int64 do { - let o: AnyObject? = try instanceManager.removeInstance(withIdentifier: identifierArg) - print("GBC Object:") - if let o = o { - print(o) - } else { - print("null") - } + let _: AnyObject? = try instanceManager.removeInstance(withIdentifier: identifierArg) reply(wrapResult(nil)) } catch { reply(wrapError(error))