From c31b4bdf4c57b3dc5d3d3f9a1f04db690743c07d Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Mon, 14 Oct 2019 17:36:06 -0700 Subject: [PATCH] [image_picker] Fix iOS build and analyzer warnings --- packages/image_picker/CHANGELOG.md | 4 ++++ .../image_picker/ios/Classes/FLTImagePickerMetaDataUtil.m | 1 + .../image_picker/ios/Classes/FLTImagePickerPhotoAssetUtil.h | 2 +- packages/image_picker/pubspec.yaml | 2 +- script/lint_darwin_plugins.sh | 1 - 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/image_picker/CHANGELOG.md b/packages/image_picker/CHANGELOG.md index bfc368b308af..bdaa9638ab59 100644 --- a/packages/image_picker/CHANGELOG.md +++ b/packages/image_picker/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.1+8 + +* Fix iOS build and analyzer warnings. + ## 0.6.1+7 * Android: Fix ImagePickerPlugin#onCreate casting context which causes exception. diff --git a/packages/image_picker/ios/Classes/FLTImagePickerMetaDataUtil.m b/packages/image_picker/ios/Classes/FLTImagePickerMetaDataUtil.m index 67b6efa8a8a8..9786f61e1e67 100644 --- a/packages/image_picker/ios/Classes/FLTImagePickerMetaDataUtil.m +++ b/packages/image_picker/ios/Classes/FLTImagePickerMetaDataUtil.m @@ -45,6 +45,7 @@ + (NSDictionary *)getMetaDataFromImageData:(NSData *)imageData { CGImageSourceRef source = CGImageSourceCreateWithData((CFDataRef)imageData, NULL); NSDictionary *metadata = (NSDictionary *)CFBridgingRelease(CGImageSourceCopyPropertiesAtIndex(source, 0, NULL)); + CFRelease(source); return metadata; } diff --git a/packages/image_picker/ios/Classes/FLTImagePickerPhotoAssetUtil.h b/packages/image_picker/ios/Classes/FLTImagePickerPhotoAssetUtil.h index 709b6ca65143..1e6fda2cf786 100644 --- a/packages/image_picker/ios/Classes/FLTImagePickerPhotoAssetUtil.h +++ b/packages/image_picker/ios/Classes/FLTImagePickerPhotoAssetUtil.h @@ -24,7 +24,7 @@ NS_ASSUME_NONNULL_BEGIN // Save image with correct meta data and extention copied from image picker result info. + (NSString *)saveImageWithPickerInfo:(nullable NSDictionary *)info image:(UIImage *)image - imageQuality:(NSNumber *)imageQuality; + imageQuality:(nullable NSNumber *)imageQuality; @end diff --git a/packages/image_picker/pubspec.yaml b/packages/image_picker/pubspec.yaml index ce1b46c63366..6ad8153e66da 100755 --- a/packages/image_picker/pubspec.yaml +++ b/packages/image_picker/pubspec.yaml @@ -5,7 +5,7 @@ authors: - Flutter Team - Rhodes Davis Jr. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker -version: 0.6.1+7 +version: 0.6.1+8 flutter: plugin: diff --git a/script/lint_darwin_plugins.sh b/script/lint_darwin_plugins.sh index 0ae55c957f69..3ca9af8b892a 100755 --- a/script/lint_darwin_plugins.sh +++ b/script/lint_darwin_plugins.sh @@ -21,7 +21,6 @@ function lint_package() { # TODO: These packages have analyzer warnings. Remove plugins from this list as issues are fixed. local skip_analysis_packages=( "camera.podspec" # https://github.com/flutter/flutter/issues/42673 - "image_picker.podspec" # https://github.com/flutter/flutter/issues/42678 "in_app_purchase.podspec" # https://github.com/flutter/flutter/issues/42679 ) find "${package_dir}" -type f -name "*\.podspec" | while read podspec; do