Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Only call onWebResourceError for main frame #3078

Merged
fluttergithubbot merged 9 commits into from
Aug 10, 2021
Merged

[webview_flutter] Only call onWebResourceError for main frame #3078

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0f98055
Only call onWebResourceError for main frame
bparrishMines Sep 24, 2020
1989ef5
add wait to doesNotComplete
bparrishMines Sep 24, 2020
98caa90
Update docs
bparrishMines Sep 24, 2020
407ee1f
Merge branch 'master' of github.com:flutter/plugins into webresource
bparrishMines Jun 5, 2021
177ee2f
Merge branch 'master' of github.com:flutter/plugins into webresource
bparrishMines Aug 2, 2021
d6fd3f3
add comment for wait
bparrishMines Aug 5, 2021
6b2f10e
wait for page to finish
bparrishMines Aug 5, 2021
c8a0a0b
Merge branch 'master' of github.com:flutter/plugins into webresource
bparrishMines Aug 5, 2021
a5fd634
version bump
bparrishMines Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add wait to doesNotComplete
  • Loading branch information
@bparrishMines
bparrishMines committed Sep 24, 2020
commit 1989ef53b0c792df4d5301988e7f43420145bba3
1 change: 1 addition & 0 deletions packages/webview_flutter/example/integration_test/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,7 @@ void main() {
);

expect(errorCompleter.future, doesNotComplete);
await Future.delayed(Duration(seconds: 5));
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this when looking at the PR before; why is there a 5-second sleep at the end of these tests? At the very least this needs a clear comment, but is there really not some reliable thing we can wait for to do whatever this is intended to do, rather than relying on timing?

Copy link
Contributor Author

@bparrishMines bparrishMines Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I believed there was a chance for an error to occur after the page finished loading, but I just tested it and that doesn't look like the case for the url provided. I changed it to wait for onPageFinished.

});

testWidgets(
Expand Down