Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add buildViewWithTextDirection to platform interface #4121

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Add buildViewWithTextDirection to platform interface #4121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dcb21d8
add method to platform interface
bparrishMines Jun 30, 2021
130bd44
default impl
bparrishMines Aug 2, 2021
2c3c65b
comment
bparrishMines Aug 2, 2021
d5709ce
default value for textDirection
bparrishMines Aug 2, 2021
a2dabf9
review comments
bparrishMines Aug 4, 2021
9607819
move impl to buildViewWithTextDirection
bparrishMines Aug 4, 2021
3e150f6
Merge branch 'master' of github.com:flutter/plugins into maps_interface
bparrishMines Aug 4, 2021
1b9ee61
conditional and required
bparrishMines Aug 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
default value for textDirection
  • Loading branch information
@bparrishMines
bparrishMines committed Aug 2, 2021
commit d5709ce79bbdf40ddc40bd3e22d25c56bfb42484
2 changes: 1 addition & 1 deletion ...flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ class MethodChannelGoogleMapsFlutter extends GoogleMapsFlutterPlatform {
int creationId,
PlatformViewCreatedCallback onPlatformViewCreated, {
required CameraPosition initialCameraPosition,
required TextDirection textDirection,
TextDirection textDirection = TextDirection.ltr,
Set<Marker> markers = const <Marker>{},
Set<Polygon> polygons = const <Polygon>{},
Set<Polyline> polylines = const <Polyline>{},
Expand Down
4 changes: 2 additions & 2 deletions ...s_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ abstract class GoogleMapsFlutterPlatform extends PlatformInterface {

/// Returns a widget displaying the map view.
///
/// This method is similar to [buildView], but requires a parameter for
/// This method is similar to [buildView], but contains a parameter for
/// platforms that require a text direction.
///
/// Default behavior passes all parameters except `textDirection` to
Expand All @@ -368,7 +368,7 @@ abstract class GoogleMapsFlutterPlatform extends PlatformInterface {
int creationId,
PlatformViewCreatedCallback onPlatformViewCreated, {
required CameraPosition initialCameraPosition,
required TextDirection textDirection,
TextDirection textDirection = TextDirection.ltr,
Set<Marker> markers = const <Marker>{},
Set<Polygon> polygons = const <Polygon>{},
Set<Polyline> polylines = const <Polyline>{},
Expand Down