From 81ff9b337f08a44bacf87f072e2f5ca78f3a666c Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Mon, 24 Apr 2017 09:30:50 +0200 Subject: [PATCH 1/2] Remove UrlLauncher class --- packages/url-launcher/example/lib/main.dart | 4 ++-- packages/url-launcher/lib/url_launcher.dart | 14 +++++--------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/url-launcher/example/lib/main.dart b/packages/url-launcher/example/lib/main.dart index a81a3bb0ef4e..e91add22e5e7 100644 --- a/packages/url-launcher/example/lib/main.dart +++ b/packages/url-launcher/example/lib/main.dart @@ -28,7 +28,7 @@ class MyHomePage extends StatefulWidget { class _MyHomePageState extends State { void _launchUrl() { - UrlLauncher.launch("https://flutter.io"); + launch("https://flutter.io"); } @override @@ -54,4 +54,4 @@ class _MyHomePageState extends State { ), ); } -} \ No newline at end of file +} diff --git a/packages/url-launcher/lib/url_launcher.dart b/packages/url-launcher/lib/url_launcher.dart index 1e02a9589e64..53460316144e 100644 --- a/packages/url-launcher/lib/url_launcher.dart +++ b/packages/url-launcher/lib/url_launcher.dart @@ -2,12 +2,8 @@ import 'dart:async'; import 'package:flutter/services.dart'; -class UrlLauncher { - static const MethodChannel _channel = - const MethodChannel('plugins.flutter.io/URLLauncher'); - - /// Parse the specified URL string and delegate handling of the same to the - /// underlying platform. - static Future launch(String urlString) => - _channel.invokeMethod('UrlLauncher.launch', urlString); -} +/// Parse the specified URL string and delegate handling of the same to the +/// underlying platform. +Future launch(String urlString) => + const MethodChannel('plugins.flutter.io/URLLauncher') + .invokeMethod('UrlLauncher.launch', urlString); From 9b5cd44aa3c8e9d2d7b355d545aab5e4e2a1dbf1 Mon Sep 17 00:00:00 2001 From: Sarah Zakarias Date: Mon, 24 Apr 2017 09:41:47 +0200 Subject: [PATCH 2/2] comments --- packages/url-launcher/example/lib/main.dart | 2 +- packages/url-launcher/lib/url_launcher.dart | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/url-launcher/example/lib/main.dart b/packages/url-launcher/example/lib/main.dart index e91add22e5e7..86018261b4ac 100644 --- a/packages/url-launcher/example/lib/main.dart +++ b/packages/url-launcher/example/lib/main.dart @@ -28,7 +28,7 @@ class MyHomePage extends StatefulWidget { class _MyHomePageState extends State { void _launchUrl() { - launch("https://flutter.io"); + launch('https://flutter.io'); } @override diff --git a/packages/url-launcher/lib/url_launcher.dart b/packages/url-launcher/lib/url_launcher.dart index 53460316144e..cef7d7a82a2d 100644 --- a/packages/url-launcher/lib/url_launcher.dart +++ b/packages/url-launcher/lib/url_launcher.dart @@ -4,6 +4,9 @@ import 'package:flutter/services.dart'; /// Parse the specified URL string and delegate handling of the same to the /// underlying platform. -Future launch(String urlString) => - const MethodChannel('plugins.flutter.io/URLLauncher') - .invokeMethod('UrlLauncher.launch', urlString); +Future launch(String urlString) { + return const MethodChannel('plugins.flutter.io/URLLauncher').invokeMethod( + 'UrlLauncher.launch', + urlString, + ); +}