Skip to content

Commit fc1bc16

Browse files
committed
Only reinitialize if ChewieController changed
1 parent 2bd06b7 commit fc1bc16

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

lib/src/cupertino_controls.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,14 @@ class _CupertinoControlsState extends State<CupertinoControls> {
7272

7373
@override
7474
void didChangeDependencies() {
75+
final _oldController = chewieController;
7576
chewieController = ChewieController.of(context);
7677
controller = chewieController.videoPlayerController;
7778

78-
_dispose();
79-
_initialize();
79+
if (_oldController != chewieController) {
80+
_dispose();
81+
_initialize();
82+
}
8083

8184
super.didChangeDependencies();
8285
}

lib/src/material_controls.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,14 @@ class _MaterialControlsState extends State<MaterialControls> {
6565

6666
@override
6767
void didChangeDependencies() {
68+
final _oldController = chewieController;
6869
chewieController = ChewieController.of(context);
6970
controller = chewieController.videoPlayerController;
7071

71-
_dispose();
72-
_initialize();
72+
if (_oldController != chewieController) {
73+
_dispose();
74+
_initialize();
75+
}
7376

7477
super.didChangeDependencies();
7578
}

0 commit comments

Comments
 (0)