Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: robrighter/node-xml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: forissier/node-xml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 14, 2013

  1. Fix leak of util variable into global scope. 

    Mocha (http://visionmedia.github.com/mocha/) reports the following error
when running tests on code that calls SaxParser().parseString():
  Error: global leak detected: util
    @forissier
    forissier committed Mar 14, 2013
    Configuration menu
    Copy the full SHA
    8d4a10d View commit details
    Browse the repository at this point in the history

  2. Fix more leaks of variables into global namespace. 

    Fixes the follwing Mocha error:
  Error: global leaks detected: iRet, theatts, splits, nameobject, that
    @forissier
    forissier committed Mar 14, 2013
    Configuration menu
    Copy the full SHA
    b0911c7 View commit details
    Browse the repository at this point in the history
Loading