Skip to content

Conversation

@vishal-thenge
Copy link

@vishal-thenge vishal-thenge commented Apr 18, 2025

Overview

A prospect found out that python deps named 0,1,2 . Turns out these were *req.txt files being scanned from their Documentation/ directory. Added Documentation/ to the default ignoredPaths

Acceptance criteria

Directories with names Documentation/ documentation/ should be default ignored from scans.

Testing plan

Haven't tested this manually. Only added Documentation/ & documentation/ to the list of ignoredPaths

Example:

  1. Add a file name something_req.txt in a directory named Documentation/ OR documentation/.
  2. Run fossa analyze to ensure these files are not picked up as python manifest files.

This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).

Risks

_I havent seen cases of valid source code, manifest files present in Documentation/ , documentation directories. if there are source, valid manifest files in these dirs , we risk missing them. _

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

Highlighted by prospect (Actia) over an email

Example:

  • None_

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@vishal-thenge vishal-thenge requested a review from a team as a code owner April 18, 2025 16:52
@vishal-thenge vishal-thenge requested a review from nficca April 18, 2025 16:52
Copy link
Contributor

@nficca nficca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks harmless to me. You might need to re-run the integration test, looks like it may have flaked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants