Swan #16
Closed
Swan #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Jul 13, 2021
Owner
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
To be unified all files have to be renamed with _R5.
As you change the switch definition to ARDUINO_SWAN_R5 the build.board have to be renamed.
And also the variant_SWAN.h else the variant_{build.board}.h will not be aligned.
Owner
|
Just a warn but you made your PR not on top of the branch so the USART3 pin inversion was not part of your branch |
Owner
|
@bsatrom |
Owner
|
I've rebased and clean up with the new name in the Swan branch: https://github.com/fpistm/Arduino_Core_STM32/tree/Swan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_3V3alias to PE4. This pin, when pulled High, enables 3V3 OUT on the Swan so we'd like to add this for ease of use.