Skip to content

Commit 5f36409

Browse files
committed
Update readme, minor fix
1 parent 602b941 commit 5f36409

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## Changes in 2.3.1
2+
3+
- Fixed a bug where the `render` function would not wait until all the assets were copied, thanks @joebain!
4+
15
## Changes in 2.3:
26

37
- Added the new header hover links feature, along with the relevant CSS for each built in layout.

lib/render.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ var fs = require('fs'),
77

88
module.exports = function(argv, onDone) {
99

10-
var finalDone = onDone || function(){};
11-
var doneCount = 0;
12-
var expectedDoneCount = 2;
13-
onDone = function() {
14-
if (++doneCount == expectedDoneCount) {
15-
finalDone();
16-
}
17-
};
10+
var finalDone = onDone || function(){};
11+
var doneCount = 0;
12+
var expectedDoneCount = 2;
13+
onDone = function() {
14+
if (++doneCount == expectedDoneCount) {
15+
finalDone();
16+
}
17+
};
1818

1919

2020
// --export
@@ -93,5 +93,7 @@ module.exports = function(argv, onDone) {
9393
.pipe(pi.devnull().once('finish', onDone));
9494
} else {
9595
console.log('Assets path does not exist: ' + assetDir + ', so no assets were copied.');
96+
// always call onDone to increment the number of completed tasks
97+
onDone();
9698
}
9799
};

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ It exists, and uses the same options as `generate-md`. Docs TODO, see `bin/gener
284284

285285
## Acknowledgments
286286

287-
I'd like to thank @AaronJan for contributing a patch that adds support for Windows (for `v.2.2.0`+).
287+
I'd like to thank @AaronJan for contributing a patch that adds support for Windows (for `v.2.2.0`+) and @joebain for a fix related to using markdown-styles with grunt.
288288

289289
I'd like to thank the following people for either contributing to markdown-styles directly or making CSS stylesheets available with a permissive open source license:
290290

0 commit comments

Comments
 (0)