Skip to content

Commit 5397f94

Browse files
committed
adds isLoggedIn middleware globally to userRouter and privilegeRouter instead of at each individual route handler
1 parent 5f0f989 commit 5397f94

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

api/server.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const cors = require("cors");
44
const server = express();
55
const helmet = require("helmet");
66
const morgan = require("morgan");
7-
const { assignId, accessLogStream } = require("../middleware");
7+
const { assignId, accessLogStream, isLoggedIn } = require("../middleware");
88

99
// global middleware
1010
server.use(helmet());
@@ -25,7 +25,7 @@ server.use(
2525
const { userRouter, authRouter ,privilegeRouter } = require("../routers");
2626

2727
// use routers
28-
server.use("/users", userRouter);
28+
server.use("/users", isLoggedIn, userRouter);
2929
server.use("/auth", authRouter);
3030
server.use("/privileges", privilegeRouter);
3131

routers/privilegeRouter.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const { isLoggedIn } = require("../middleware");
77
const { privileges } = require("../models");
88

99
// GET all provileges info
10-
router.get("/", isLoggedIn, (req, res, next) => {
10+
router.get("/", (req, res, next) => {
1111
privileges
1212
.find()
1313
.then((privRes) => {
@@ -22,7 +22,7 @@ router.get("/", isLoggedIn, (req, res, next) => {
2222
});
2323

2424
// GET privilege by ID
25-
router.get("/:id", isLoggedIn, (req, res, next) => {
25+
router.get("/:id", (req, res, next) => {
2626
privileges
2727
.findById(req.params.id)
2828
.then((privRes) => {
@@ -63,6 +63,7 @@ router.put("/", async (req, res, next) => {
6363
privileges
6464
.updatePrivilege(req.body)
6565
.then((updateRes) => {
66+
console.log('updateRes: ', updateRes)
6667
res.status(200).json(updateRes[0]);
6768
})
6869
.catch(next);
@@ -82,7 +83,7 @@ router.delete("/:id", async (req, res, next) => {
8283
.deletePrivilege(req.params.id)
8384
.then((delRes) => {
8485
if (delRes) {
85-
checkPrivExists.message= "Successfully Deleted"
86+
checkPrivExists.message = "Successfully Deleted";
8687
return res.status(200).json(checkPrivExists);
8788
}
8889
})

routers/userRouter.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22
const express = require("express");
33
const router = express.Router();
44

5-
const { isLoggedIn } = require("../middleware");
6-
75
const { users } = require("../models");
86

97
// get all users
108
// -if logged in
11-
router.get("/", isLoggedIn, (req, res, next) => {
9+
router.get("/", (req, res, next) => {
1210
users
1311
.find()
1412
.then((users) => {
@@ -21,7 +19,7 @@ router.get("/", isLoggedIn, (req, res, next) => {
2119
});
2220

2321
// get user by id
24-
router.get("/:id", isLoggedIn, (req, res, next) => {
22+
router.get("/:id", (req, res, next) => {
2523
const { id } = req.params;
2624
users
2725
.findById(id)
@@ -35,7 +33,7 @@ router.get("/:id", isLoggedIn, (req, res, next) => {
3533
});
3634

3735
// update a user
38-
router.put("/", isLoggedIn, (req, res, next) => {
36+
router.put("/", (req, res, next) => {
3937
users
4038
.updateUser(req.body)
4139
.then((user) => {
@@ -49,7 +47,7 @@ router.put("/", isLoggedIn, (req, res, next) => {
4947
});
5048

5149
// delete a user
52-
router.delete("/:id", isLoggedIn, (req, res, next) => {
50+
router.delete("/:id", (req, res, next) => {
5351
const { id } = req.params;
5452
// returns number of affected rows
5553
users

0 commit comments

Comments
 (0)